Message ID | 7d0c7283-1a62-4c19-b5a1-43e09ab38af9@linux.ibm.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 816DD3858C31 for <patchwork@sourceware.org>; Thu, 19 Sep 2024 23:40:43 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 374923858D29 for <gcc-patches@gcc.gnu.org>; Thu, 19 Sep 2024 23:40:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 374923858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 374923858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726789211; cv=none; b=P/D647jSQ9cc4f1zG6LZZL87e5N+fOk7giAkGHYBgtCSUrvY+wghxAqmS+yZnmMTJglOcVx6TZlHKTu3cYWU+i2VQOujdx03LXyVynTVMUWG9Slqzq9O3Bun3ssQeGnIcGmpX9WhpoTfQmA3aYBR4k7PzyE0GrmhgjnHFT3ZMiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726789211; c=relaxed/simple; bh=5Uz3q1e3SqloyDcNpxSt6IVImxiasgtRYpCL3cvI7to=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=NNetr8bWX1Lv35tYScFeB76A7c1rXsb230HxjQqpwe82yNmd+0WueqAOHedkuVASJ09w4r57OYkDGV+I5L+7GgIWzmKJTGgknDKmto44H2WKqzpSFScWYZI8yea3TNqsqPs5EXruT+N6N/tBMXUL/6x90P7dp7ou6/WgLdw9OGE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48JIxcq2007628; Thu, 19 Sep 2024 23:40:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:to:from:subject:content-type :content-transfer-encoding; s=pp1; bh=T8tHMLe3Nc3MRwhDSR9qqKStqH 2tbnwKIZPSIbcTato=; b=Up27r7kOK9ANDT2uL5gDPijebCmnWXsrMz8fpRg/9h NqfhFi0+QnH4wDrtc3v2KH9/lz6igEaMTI5P5amu4AzuX2YRAjQDWq75XNhFId46 VJotPUwHxpwTqgKO4Y7ZtiA0yjxI4UGE01MhxlOSR06XDUk9EJpnq5cYbjsJJ+UL nu9mqfsjAmaPv6aVSK9i0Xpb/GfmJx39TXGD3npJF4JDJJWzd572Y2sm4ZcXYz54 leRorxWVIqvDfs34EvoV1ki+ZncGCNl13/nSn8bTFpF75owl8RSGgtBVsgnGEG5C TFDnl6nJJMhDtOBkCkzu1B6qB3T8LvX3lsy7uEZo/dLg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41pht8yqpf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 23:40:09 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 48JNe8xk017172; Thu, 19 Sep 2024 23:40:08 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41pht8yqpd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 23:40:08 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48JKCLtR025033; Thu, 19 Sep 2024 23:40:08 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 41nq1nc2dr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 23:40:08 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48JNe7xg45547882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Sep 2024 23:40:07 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A79D58056; Thu, 19 Sep 2024 23:40:07 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B09B358052; Thu, 19 Sep 2024 23:40:06 +0000 (GMT) Received: from [9.67.2.251] (unknown [9.67.2.251]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 19 Sep 2024 23:40:06 +0000 (GMT) Message-ID: <7d0c7283-1a62-4c19-b5a1-43e09ab38af9@linux.ibm.com> Date: Thu, 19 Sep 2024 16:40:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: segher <segher@kernel.crashing.org>, Peter Bergner <bergner@linux.ibm.com>, David Edelsohn <dje.gcc@gmail.com>, cel <cel@linux.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org> From: Carl Love <cel@linux.ibm.com> Subject: [PATCH] rs6000, Fix test builtins-1-p10-runnable.c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GOqyYIRRTmawVThTso9ywzWlmBM91zHM X-Proofpoint-ORIG-GUID: PqVOgkedxVPMNtTwVe_uCvHAzSvrbySy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-19_22,2024-09-19_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 clxscore=1011 malwarescore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409190157 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
rs6000, Fix test builtins-1-p10-runnable.c
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | fail | Patch failed to apply |
Commit Message
Carl Love
Sept. 19, 2024, 11:40 p.m. UTC
GCC maintainers: This patch removes an expected value change that was made to verify the error checking for the test was working. Apparently, it didn't get removed from the final patch. The patch fixes the single test error in the builtins-1-10-runnable.c test. The patch was run on a Power 10. Please let me know if the patch is acceptable for mainline. Thanks. Carl Love ----------------------------------------------------------------- rs6000, Fix test builtins-1-p10-runnable.c The first element of the expected result was apparently changed for testing purposes. The change didn't get removed before the commit. The issue was introduced in commit: commit f1ad419ebfdcfaf26117e069b10bd1b154276049 Author: Carl Love <cel@us.ibm.com> Date: Fri Sep 4 19:24:22 2020 -0500 rs6000, vector integer multiply/divide/modulo instructions Remove the test input. gcc/testsuite/ChangeLog: * gcc.target/powerpc/builtins-1-p10-runnable.c: Remove expected value for testing. Uncomment correct expected result. --- gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Comments
GCC maintainers: Please ignore this patch. Attached the wrong patch to the message. Sorry for the noise. Carl On 9/19/24 4:40 PM, Carl Love wrote: > GCC maintainers: > > This patch removes an expected value change that was made to verify > the error checking for the test was working. Apparently, it didn't > get removed from the final patch. > > The patch fixes the single test error in the builtins-1-10-runnable.c > test. > > The patch was run on a Power 10. > > Please let me know if the patch is acceptable for mainline. Thanks. > > Carl Love > > ----------------------------------------------------------------- > rs6000, Fix test builtins-1-p10-runnable.c > > The first element of the expected result was apparently changed > for testing purposes. The change didn't get removed before the > commit. > > The issue was introduced in commit: > > commit f1ad419ebfdcfaf26117e069b10bd1b154276049 > Author: Carl Love <cel@us.ibm.com> > Date: Fri Sep 4 19:24:22 2020 -0500 > > rs6000, vector integer multiply/divide/modulo instructions > > Remove the test input. > > gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/builtins-1-p10-runnable.c: Remove > expected value for testing. Uncomment correct expected > result. > --- > gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git > a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > index 222c8b3a409..5402852f82b 100644 > --- a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > @@ -281,8 +281,7 @@ int main() > /* Signed word multiply high */ > i_arg1 = (vector int){ 2147483648, 2147483648, 2147483648, > 2147483648 }; > i_arg2 = (vector int){ 2, 3, 4, 5}; > - // vec_i_expected = (vector int){-1, -2, -2, -3}; > - vec_i_expected = (vector int){1, -2, -2, -3}; > + vec_i_expected = (vector int){-1, -2, -2, -3}; > > vec_i_result = vec_mulh (i_arg1, i_arg2); >
diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c index 222c8b3a409..5402852f82b 100644 --- a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c @@ -281,8 +281,7 @@ int main() /* Signed word multiply high */ i_arg1 = (vector int){ 2147483648, 2147483648, 2147483648, 2147483648 }; i_arg2 = (vector int){ 2, 3, 4, 5}; - // vec_i_expected = (vector int){-1, -2, -2, -3}; - vec_i_expected = (vector int){1, -2, -2, -3}; + vec_i_expected = (vector int){-1, -2, -2, -3}; vec_i_result = vec_mulh (i_arg1, i_arg2);