From patchwork Mon Nov 7 08:51:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 60075 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DC033865C2C for ; Mon, 7 Nov 2022 08:51:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id BDE64385C332 for ; Mon, 7 Nov 2022 08:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDE64385C332 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 621B61F890; Mon, 7 Nov 2022 08:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1667811069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VU8oH/jFpfXos+yH5ZkFLAMJO/gAX3vUy2B6DYah4N0=; b=khKip4cSZg38Hx/RS4FsVP3cyfAQ59bfeN3m12qKuZkf0/gAvKPNzd/FoaMC4lO/0hJ+C6 DmGRFOqGL9RZNz/XkVy8zzGJym3xKHmgWCHfvBMarcdaYojLQyRP55CQJbLelK17G2c1Dd Y0sdLCwpx+vGbPQh/mHoE2Nd625Ayrs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1667811069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VU8oH/jFpfXos+yH5ZkFLAMJO/gAX3vUy2B6DYah4N0=; b=9tUaoGeckpnJHwI5omA3R1PtDgkWphpjllqpsZQ2hFz/M3SLnJSW8j2OBOXIEinONmvVSD IAiq0DzV+KLzTgCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A93413494; Mon, 7 Nov 2022 08:51:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wcsTEP3GaGO1NwAAMHmgww (envelope-from ); Mon, 07 Nov 2022 08:51:09 +0000 Message-ID: <75e3842a-f9d2-b90a-5e19-30afcf0f1fa6@suse.cz> Date: Mon, 7 Nov 2022 09:51:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH (pushed)] Mitigate clang warnings: To: gcc-patches@gcc.gnu.org Content-Language: en-US Cc: Andrew MacLeod , Aldy Hernandez X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" gcc/range-op.cc:1752:16: warning: 'wi_fold' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/range-op.cc:1757:16: warning: 'wi_op_overflows' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/range-op.cc:1759:16: warning: 'op1_range' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/range-op.cc:1763:16: warning: 'op2_range' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/range-op.cc:1928:16: warning: 'wi_fold' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/range-op.cc:1933:16: warning: 'wi_op_overflows' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/ChangeLog: * range-op.cc: Add final override keywords. --- gcc/range-op.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gcc/range-op.cc b/gcc/range-op.cc index 25c004d8287..5e94c3d2282 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -1753,17 +1753,18 @@ public: const wide_int &lh_lb, const wide_int &lh_ub, const wide_int &rh_lb, - const wide_int &rh_ub) const; + const wide_int &rh_ub) const final override; virtual bool wi_op_overflows (wide_int &res, tree type, - const wide_int &w0, const wide_int &w1) const; + const wide_int &w0, const wide_int &w1) + const final override; virtual bool op1_range (irange &r, tree type, const irange &lhs, const irange &op2, - relation_trio) const; + relation_trio) const final override; virtual bool op2_range (irange &r, tree type, const irange &lhs, const irange &op1, - relation_trio) const; + relation_trio) const final override; } op_mult; bool @@ -1929,9 +1930,10 @@ public: const wide_int &lh_lb, const wide_int &lh_ub, const wide_int &rh_lb, - const wide_int &rh_ub) const; + const wide_int &rh_ub) const final override; virtual bool wi_op_overflows (wide_int &res, tree type, - const wide_int &, const wide_int &) const; + const wide_int &, const wide_int &) + const final override; virtual bool fold_range (irange &r, tree type, const irange &lh, const irange &rh, relation_trio trio) const final override;