diff mbox series

ifcvt: Lower bitfields only if suitable for scalar register [PR tree/109005]

Message ID 716e6395-4108-0864-4272-f96b232989d2@arm.com
State Committed
Commit b109964ddb421cf481828a2f3465751a2bd6a8f6
Headers
Series ifcvt: Lower bitfields only if suitable for scalar register [PR tree/109005] |

Commit Message

Andre Vieira (lists) March 13, 2023, 3:53 p.m. UTC 
  This patch fixes the condition check for eligilibity of lowering bitfields,
where before we would check for non-BLKmode types, in the hope of excluding
unsuitable aggregate types, we now check directly the representative is 
not an
aggregate type, i.e. suitable for a scalar register.

I tried adding the reduced testcase mentioned in the PR, but I couldn't 
get the Ada testsuite to run, so could an Ada maintainer add the test 
after verifying it runs properly?

OK for trunk?

gcc/ChangeLog:

	PR tree/109005
	* tree-if-conv.cc (get_bitfield_rep): Replace BLKmode check with
	aggregate type check.

Comments

Richard Biener March 13, 2023, 5:47 p.m. UTC | #1 
> Am 13.03.2023 um 16:54 schrieb Andre Vieira (lists) via Gcc-patches <gcc-patches@gcc.gnu.org>:
> 
> This patch fixes the condition check for eligilibity of lowering bitfields,
> where before we would check for non-BLKmode types, in the hope of excluding
> unsuitable aggregate types, we now check directly the representative is not an
> aggregate type, i.e. suitable for a scalar register.
> 
> I tried adding the reduced testcase mentioned in the PR, but I couldn't get the Ada testsuite to run, so could an Ada maintainer add the test after verifying it runs properly?
> 
> OK for trunk?

Ok

Richard 

> gcc/ChangeLog:
> 
>    PR tree/109005
>    * tree-if-conv.cc (get_bitfield_rep): Replace BLKmode check with
>    aggregate type check.
> <pr109005.patch>
diff mbox series

Patch

diff --git a/gcc/tree-if-conv.cc b/gcc/tree-if-conv.cc
index f133102ad3350a0fd3a09ad836c68e840f316a0e..ca1abd8656c6c47c314d2b2c9fa515e150d1703b 100644
--- a/gcc/tree-if-conv.cc
+++ b/gcc/tree-if-conv.cc
@@ -3317,9 +3317,9 @@  get_bitfield_rep (gassign *stmt, bool write, tree *bitpos,
   tree field_decl = TREE_OPERAND (comp_ref, 1);
   tree rep_decl = DECL_BIT_FIELD_REPRESENTATIVE (field_decl);
 
-  /* Bail out if the representative is BLKmode as we will not be able to
-     vectorize this.  */
-  if (TYPE_MODE (TREE_TYPE (rep_decl)) == E_BLKmode)
+  /* Bail out if the representative is not a suitable type for a scalar
+     register variable.  */
+  if (!is_gimple_reg_type (TREE_TYPE (rep_decl)))
     return NULL_TREE;
 
   /* Bail out if the DECL_SIZE of the field_decl isn't the same as the BF's