From patchwork Wed Feb 9 20:51:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 50976 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCF08385842B for ; Wed, 9 Feb 2022 20:51:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCF08385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1644439910; bh=hBK2AU4qK5srvxTf9sTN6hJtQm88M+84ltX3IQVk9Lw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=PU2Y8C4a2a8dvWBDc67vQwLYM6eNtxEMAUP60Lcsq98EpcJB5+m6qsDmkiW583AOs ntZzASEFLjMRCltDA9lGvYePToflc/x5cXDk6GpiFs93TkaIs7b2hiWnumZoO9mh7A qCf1Vs+2Y7mtBES709FTcUwiw7PYpkfgjoXL+kk8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 83AB93858D28 for ; Wed, 9 Feb 2022 20:51:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83AB93858D28 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219KbLeF024744; Wed, 9 Feb 2022 20:51:17 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e3ny9ny1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Feb 2022 20:51:17 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 219KbeOZ029180; Wed, 9 Feb 2022 20:51:17 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 3e3ny9ny1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Feb 2022 20:51:17 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 219Ki5Vf029762; Wed, 9 Feb 2022 20:51:15 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01wdc.us.ibm.com with ESMTP id 3e1gvbafd9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Feb 2022 20:51:15 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 219KpF9H36766164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Feb 2022 20:51:15 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9F526A04D; Wed, 9 Feb 2022 20:51:14 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BED606A04F; Wed, 9 Feb 2022 20:51:14 +0000 (GMT) Received: from [9.211.95.26] (unknown [9.211.95.26]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 9 Feb 2022 20:51:14 +0000 (GMT) Message-ID: <6b18b3aa-441f-22f5-7b1d-6bb962cd55f0@linux.ibm.com> Date: Wed, 9 Feb 2022 14:51:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 To: GCC Patches Subject: [PATCH] rs6000: Rename vec_clrl and vec_clrr to agreed-upon names X-TM-AS-GCONF: 00 X-Proofpoint-GUID: hvoOvGReRd3tq3iG6QmnkYTyCXvY3mox X-Proofpoint-ORIG-GUID: _AlN75nYyvHKxWzslKEnkaMnnqqPeLns X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-09_11,2022-02-09_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090107 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Bill Schmidt via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: wschmidt@linux.ibm.com Cc: David Edelsohn , Segher Boessenkool Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! After vec_clrl and vec_clrr were implemented and during review of the documentation, it was agreed to change their names to vec_clr_first and vec_clr_last to more clearly describe their bi-endian semantics. ("Left" and "right" are the wrong terms to be using.) It looks like I neglected to make that change, so fixing it now. Bootstrapped and tested on powerpc64le-linux-gnu with no regressions. Is this okay for trunk, and for backport to gcc 11 after some burn-in? Thanks! Bill 2022-02-09 Bill Schmidt gcc/ * config/rs6000/rs6000-overload.def (VEC_CLR_FIRST): Rename from VEC_CLRL. (VEC_CLR_LAST): Rename from VEC_CLRR. gcc/testsuite/ * gcc.target/powerpc/vec-clrl-0.c: Adjust to new names. * gcc.target/powerpc/vec-clrl-1.c: Likewise. * gcc.target/powerpc/vec-clrl-2.c: Likewise. * gcc.target/powerpc/vec-clrl-3.c: Likewise. * gcc.target/powerpc/vec-clrr-0.c: Likewise. * gcc.target/powerpc/vec-clrr-1.c: Likewise. * gcc.target/powerpc/vec-clrr-2.c: Likewise. * gcc.target/powerpc/vec-clrr-3.c: Likewise. --- gcc/config/rs6000/rs6000-overload.def | 12 ++++++------ gcc/testsuite/gcc.target/powerpc/vec-clrl-0.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrl-1.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrl-2.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrl-3.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrr-0.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrr-1.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrr-2.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/vec-clrr-3.c | 4 ++-- 9 files changed, 22 insertions(+), 22 deletions(-) diff --git a/gcc/config/rs6000/rs6000-overload.def b/gcc/config/rs6000/rs6000-overload.def index 44e2945aaa0..0b68cc3c3b2 100644 --- a/gcc/config/rs6000/rs6000-overload.def +++ b/gcc/config/rs6000/rs6000-overload.def @@ -557,16 +557,16 @@ vuc __builtin_vec_vcipherlast_be (vuc, vuc); VCIPHERLAST_BE -[VEC_CLRL, vec_clrl, __builtin_vec_clrl] - vsc __builtin_vec_clrl (vsc, unsigned int); +[VEC_CLR_FIRST, vec_clr_first, __builtin_vec_clr_first] + vsc __builtin_vec_clr_first (vsc, unsigned int); VCLRLB VCLRLB_S - vuc __builtin_vec_clrl (vuc, unsigned int); + vuc __builtin_vec_clr_first (vuc, unsigned int); VCLRLB VCLRLB_U -[VEC_CLRR, vec_clrr, __builtin_vec_clrr] - vsc __builtin_vec_clrr (vsc, unsigned int); +[VEC_CLR_LAST, vec_clr_last, __builtin_vec_clr_last] + vsc __builtin_vec_clr_last (vsc, unsigned int); VCLRRB VCLRRB_S - vuc __builtin_vec_clrr (vuc, unsigned int); + vuc __builtin_vec_clr_last (vuc, unsigned int); VCLRRB VCLRRB_U ; We skip generating a #define because of the C-versus-C++ complexity diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrl-0.c b/gcc/testsuite/gcc.target/powerpc/vec-clrl-0.c index d0b183ebfaf..df055c6535e 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrl-0.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrl-0.c @@ -5,11 +5,11 @@ extern void abort (void); -/* Vector string clear left-most bytes of unsigned char. */ +/* Vector string clear first bytes of unsigned char. */ vector unsigned char clrl (vector unsigned char arg, int n) { - return vec_clrl (arg, n); + return vec_clr_first (arg, n); } /* { dg-final { scan-assembler {\mvclrlb\M} { target be } } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrl-1.c b/gcc/testsuite/gcc.target/powerpc/vec-clrl-1.c index 43ab32c0278..692f83e033b 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrl-1.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrl-1.c @@ -7,11 +7,11 @@ extern void abort (void); -/* Vector string clear left-most bytes of unsigned char. */ +/* Vector string clear first bytes of unsigned char. */ vector unsigned char clrl (vector unsigned char arg, int n) { - return vec_clrl (arg, n); + return vec_clr_first (arg, n); } int main (int argc, char *argv []) diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrl-2.c b/gcc/testsuite/gcc.target/powerpc/vec-clrl-2.c index b9676b8b04c..ffecf432736 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrl-2.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrl-2.c @@ -5,11 +5,11 @@ extern void abort (void); -/* Vector string clear left-most bytes of unsigned char. */ +/* Vector string clear first bytes of unsigned char. */ vector signed char clrl (vector signed char arg, int n) { - return vec_clrl (arg, n); + return vec_clr_first (arg, n); } /* { dg-final { scan-assembler {\mvclrlb\M} { target be } } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrl-3.c b/gcc/testsuite/gcc.target/powerpc/vec-clrl-3.c index 0ae5abcee50..456f655e7aa 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrl-3.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrl-3.c @@ -7,11 +7,11 @@ extern void abort (void); -/* Vector string clear left-most bytes of unsigned char. */ +/* Vector string clear first bytes of unsigned char. */ vector signed char clrl (vector signed char arg, int n) { - return vec_clrl (arg, n); + return vec_clr_first (arg, n); } int main (int argc, char *argv []) diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrr-0.c b/gcc/testsuite/gcc.target/powerpc/vec-clrr-0.c index 2aa1454d140..5cd10fa900c 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrr-0.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrr-0.c @@ -5,11 +5,11 @@ extern void abort (void); -/* Vector string clear right-most bytes of unsigned char. */ +/* Vector string clear last bytes of unsigned char. */ vector unsigned char clrr (vector unsigned char arg, int n) { - return vec_clrr (arg, n); + return vec_clr_last (arg, n); } /* { dg-final { scan-assembler {\mvclrrb\M} { target be } } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrr-1.c b/gcc/testsuite/gcc.target/powerpc/vec-clrr-1.c index c72ae86cd32..b261ec84dc6 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrr-1.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrr-1.c @@ -7,11 +7,11 @@ extern void abort (void); -/* Vector string clear right-most bytes of unsigned char. */ +/* Vector string clear last bytes of unsigned char. */ vector unsigned char clrr (vector unsigned char arg, int n) { - return vec_clrr (arg, n); + return vec_clr_last (arg, n); } int main (int argc, char *argv []) diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrr-2.c b/gcc/testsuite/gcc.target/powerpc/vec-clrr-2.c index f09be49e0ab..0b7f096f95f 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrr-2.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrr-2.c @@ -5,11 +5,11 @@ extern void abort (void); -/* Vector string clear right-most bytes of unsigned char. */ +/* Vector string clear last bytes of unsigned char. */ vector signed char clrr (vector signed char arg, int n) { - return vec_clrr (arg, n); + return vec_clr_last (arg, n); } /* { dg-final { scan-assembler {\mvclrrb\M} { target be } } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/vec-clrr-3.c b/gcc/testsuite/gcc.target/powerpc/vec-clrr-3.c index 1413c11b872..66297245374 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-clrr-3.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-clrr-3.c @@ -7,11 +7,11 @@ extern void abort (void); -/* Vector string clear right-most bytes of unsigned char. */ +/* Vector string clear last bytes of unsigned char. */ vector signed char clrr (vector signed char arg, int n) { - return vec_clrr (arg, n); + return vec_clr_last (arg, n); } int main (int argc, char *argv [])