rs6000: Fix the check of bif argument number [PR104482]
Commit Message
Hi,
PR104482 is one regression about the handlings on different argument
numbers from its prototype of built-in function. Without the patch,
the code only catches the case when argument number is more than the
one of prototype, but it ignores the possibility that the number of
arguments can be more as the PR shows.
Bootstrapped and regtested on powerpc64-linux-gnu P8 and
powerpc64le-linux-gnu P9 and P10.
Is it ok for trunk?
BR,
Kewen
------
PR target/104482
gcc/ChangeLog:
* config/rs6000/rs6000-c.cc (altivec_resolve_overloaded_builtin): Fix
the equality check for argument number, and adjust this hunk's
location.
---
gcc/config/rs6000/rs6000-c.cc | 60 +++++++++++++++++------------------
1 file changed, 30 insertions(+), 30 deletions(-)
@@ -1747,6 +1747,36 @@ altivec_resolve_overloaded_builtin (location_t loc, tree fndecl,
vec<tree, va_gc> *arglist = static_cast<vec<tree, va_gc> *> (passed_arglist);
unsigned int nargs = vec_safe_length (arglist);
+ /* If the number of arguments did not match the prototype, return NULL
+ and the generic code will issue the appropriate error message. Skip
+ this test for functions where we don't fully describe all the possible
+ overload signatures in rs6000-overload.def (because they aren't relevant
+ to the expansion here). If we don't, we get confusing error messages. */
+ /* As an example, for vec_splats we have:
+
+; There are no actual builtins for vec_splats. There is special handling for
+; this in altivec_resolve_overloaded_builtin in rs6000-c.cc, where the call
+; is replaced by a constructor. The single overload here causes
+; __builtin_vec_splats to be registered with the front end so that can happen.
+[VEC_SPLATS, vec_splats, __builtin_vec_splats]
+ vsi __builtin_vec_splats (vsi);
+ ABS_V4SI SPLATS_FAKERY
+
+ So even though __builtin_vec_splats accepts all vector types, the
+ infrastructure cheats and just records one prototype. We end up getting
+ an error message that refers to this specific prototype even when we
+ are handling a different argument type. That is completely confusing
+ to the user, so it's best to let these cases be handled individually
+ in the resolve_vec_splats, etc., helper functions. */
+
+ if (expected_args != nargs
+ && !(fcode == RS6000_OVLD_VEC_PROMOTE
+ || fcode == RS6000_OVLD_VEC_SPLATS
+ || fcode == RS6000_OVLD_VEC_EXTRACT
+ || fcode == RS6000_OVLD_VEC_INSERT
+ || fcode == RS6000_OVLD_VEC_STEP))
+ return NULL;
+
for (n = 0;
!VOID_TYPE_P (TREE_VALUE (fnargs)) && n < nargs;
fnargs = TREE_CHAIN (fnargs), n++)
@@ -1806,36 +1836,6 @@ altivec_resolve_overloaded_builtin (location_t loc, tree fndecl,
types[n] = type;
}
- /* If the number of arguments did not match the prototype, return NULL
- and the generic code will issue the appropriate error message. Skip
- this test for functions where we don't fully describe all the possible
- overload signatures in rs6000-overload.def (because they aren't relevant
- to the expansion here). If we don't, we get confusing error messages. */
- /* As an example, for vec_splats we have:
-
-; There are no actual builtins for vec_splats. There is special handling for
-; this in altivec_resolve_overloaded_builtin in rs6000-c.cc, where the call
-; is replaced by a constructor. The single overload here causes
-; __builtin_vec_splats to be registered with the front end so that can happen.
-[VEC_SPLATS, vec_splats, __builtin_vec_splats]
- vsi __builtin_vec_splats (vsi);
- ABS_V4SI SPLATS_FAKERY
-
- So even though __builtin_vec_splats accepts all vector types, the
- infrastructure cheats and just records one prototype. We end up getting
- an error message that refers to this specific prototype even when we
- are handling a different argument type. That is completely confusing
- to the user, so it's best to let these cases be handled individually
- in the resolve_vec_splats, etc., helper functions. */
-
- if (n != expected_args
- && !(fcode == RS6000_OVLD_VEC_PROMOTE
- || fcode == RS6000_OVLD_VEC_SPLATS
- || fcode == RS6000_OVLD_VEC_EXTRACT
- || fcode == RS6000_OVLD_VEC_INSERT
- || fcode == RS6000_OVLD_VEC_STEP))
- return NULL;
-
/* Some overloads require special handling. */
tree returned_expr = NULL;
resolution res = unresolved;