From patchwork Fri Sep 12 09:32:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 120127 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B7EB3857C6C for ; Fri, 12 Sep 2025 09:33:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B7EB3857C6C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=eNtdn98T X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 37E1A3857C6C for ; Fri, 12 Sep 2025 09:32:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37E1A3857C6C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37E1A3857C6C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757669559; cv=none; b=FfpLU47HE7k85nthrFwzlO9z7YY0HrkP22euv1ggtlNX96AKh/7xvd5gSrg2SLoM5v8PRUTAxZjX0s+TtHNLDloDLwlJmbgCLTT1jEyr/mgdPX+540TKMp0nHY8FtCoWkS5p5WHepxp3bmdrK+UzXCZhX0PGWVsCSYNpmcl92Xc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757669559; c=relaxed/simple; bh=JteSiJn63qwCUug05hoSBaRrGkmOuLbxlaEK3YISSAU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=F70g1iuF67W+z/SYB6EeH59VDbbFGnVCJe4j8UvCuDnstrCS2vUBvUghXzZ6lN2svuubKvqQ2ZOL12OcUr5YQRjvDLse6ORvuk+YPUfmAJYWKpXfc8EYmVCplXDM25StcM0R60due+jUCYnyrHtwyTnJnMZvKjQ48AAhkew3/RY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37E1A3857C6C Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3e75fb6b2e2so1813445f8f.3 for ; Fri, 12 Sep 2025 02:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1757669558; x=1758274358; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HGNhoW1wq4OFKLUcBtLRnv0bwF7uq2Nwb8iQzCoJMZ8=; b=eNtdn98TS8VBjMLLngg9rrzMChIKJWGy7z+euly3Q9JA4cf+yreZjbgWyHhd9yCwSZ qogVAYOG/rj1zPv9VRisI8vGJMd2bwdSJ5U7AbRoAYwKOVd7WhVpshYu5kfe9uG/uvyZ Kx2E2wZ0rdKvblZoJHomOsE70GA06Vn2FX1IpnPU7BfS/xMtIAMX0QdKtvej9RxqSLQC VuwVdTuu1lufVZwQXB7wbw4sjivDuEZLSsobn/cxPssWRi0KZg/p/QPGpaYd4nj9eJUu m3IY8PZLoF9aeUnpOQI5citkkW3KEg6I/xTP5kZ1cOmVlVAp2YCBrLYp3EgrDsRd7Kvt ZvKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757669558; x=1758274358; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HGNhoW1wq4OFKLUcBtLRnv0bwF7uq2Nwb8iQzCoJMZ8=; b=WdsGl1v7QpyPrwhnGnJ8ozQAi8KEyQvIRC8kRhQBVZ9jWP0Syk410syd25yner3Ki6 KHCv9VgAiaptV2pJPLpYnx5H8rIrV2orV0m+jnDnQOlbzj45RszLTQU8LlTsMs/Wfzkr UbBaXUJ9HgT2KPkdh1FV5vdfdot1EbHiEo6Y6Li28RMiyecCaTLQgfSEpCT+SZxby3xV xkbu97E6xM99f9lPC5rsITHxDu0ccOvLhZRCTG8QUHLzszzAOXaavokevoZNZMRicwm9 a8pNCx9OR0SfOUf7ILfuODdiNV1tZ5NwG8Gv0XQKOAWbSq+KlPjr5o8VwAQ8C5aiZiBk AIPQ== X-Gm-Message-State: AOJu0YzartddpnzlNFI+Rdl0AOLtVyjIpowQy2L3naUQ+NtGYGw2GcEA ujC2t3L27TGsaBTZzoxfzFkMnkXXhZdXqqS61VFEl4DKL5hbvKsRh7Q1JMhxYANX+JA4IVrJCvE Q1Qs= X-Gm-Gg: ASbGncu76TLLXRk3eTp42kXxUh122GRrE3yOab19MshexmeanDx5AHAPM9uP9mpFIER Ly9Ap5dlqUry4hwhieBH/sXlUS2STzLn7VgN3IwpqDuY61LODb/Wlon252mHRPX4VjTTUcEt0xW DgM6se2AZoNJGSvs8XDUg425n83gpc0S5QHBmKOuYDifkbvOuPT//5/zMZXiMAzH0s8Kuc7Kiv2 hBXkz7zQfK1Kwi/AsW3XP6VXY8BYcgXHCSAZTNfzO6vYNt7KUlqTBqosgSFWFyQ3yGpWVpTXE0S BVb73NWVXM3Q2EmdYhYYvoON+XAgPpmZue1F4ThTERmtQ3jgwhQtnKFY1L82uZI6mBFAE2IhSqL aWp1c7xWu25aMaBhZI4aURQ0HIYdoQnUfVHw= X-Google-Smtp-Source: AGHT+IGGt8OVK1d1C87kxRRBwtF+/mtEW0vPih/ssO7Ulcu3WJfI41V/PmYaCQAxJoOREUSM6pvRpw== X-Received: by 2002:a05:6000:24c7:b0:3d1:c805:81e with SMTP id ffacd0b85a97d-3e765782b76mr1727089f8f.4.1757669557644; Fri, 12 Sep 2025 02:32:37 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e037c3cbdsm60072005e9.17.2025.09.12.02.32.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 02:32:37 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: [PATCH] Minor tweaks to ipa-pure-const.cc Date: Fri, 12 Sep 2025 11:32:36 +0200 Message-ID: <4981805.OV4Wx5bFTl@fomalhaut> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Tested on x86-64/Linux, applied to mainline as obvious. 2025-09-12 Eric Botcazou * ipa-pure-const.cc (check_stmt): Minor formatting tweaks. (pass_data_nothrow): Fix pasto in description. diff --git a/gcc/ipa-pure-const.cc b/gcc/ipa-pure-const.cc index 2519fb8a03b..1af9da16781 100644 --- a/gcc/ipa-pure-const.cc +++ b/gcc/ipa-pure-const.cc @@ -771,8 +771,7 @@ check_stmt (gimple_stmt_iterator *gsip, funct_state local, bool ipa) print_gimple_stmt (dump_file, stmt, 0); } - if (gimple_has_volatile_ops (stmt) - && !gimple_clobber_p (stmt)) + if (gimple_has_volatile_ops (stmt) && !gimple_clobber_p (stmt)) { local->pure_const_state = IPA_NEITHER; if (dump_file) @@ -781,11 +780,10 @@ check_stmt (gimple_stmt_iterator *gsip, funct_state local, bool ipa) /* Look for loads and stores. */ walk_stmt_load_store_ops (stmt, local, - ipa ? check_ipa_load : check_load, - ipa ? check_ipa_store : check_store); + ipa ? check_ipa_load : check_load, + ipa ? check_ipa_store : check_store); - if (gimple_code (stmt) != GIMPLE_CALL - && stmt_could_throw_p (cfun, stmt)) + if (gimple_code (stmt) != GIMPLE_CALL && stmt_could_throw_p (cfun, stmt)) { if (cfun->can_throw_non_call_exceptions) { @@ -2310,7 +2308,7 @@ make_pass_warn_function_noreturn (gcc::context *ctxt) return new pass_warn_function_noreturn (ctxt); } -/* Simple local pass for pure const discovery reusing the analysis from +/* Simple local pass for nothrow discovery reusing the analysis from ipa_pure_const. This pass is effective when executed together with other optimization passes in early optimization pass queue. */