From patchwork Mon Jan 10 09:19:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 49782 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 610373891C18 for ; Mon, 10 Jan 2022 09:19:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 610373891C18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641806389; bh=VYjCxgFbwu7J0LJ752yzDEjxG7BpjAyyrw27sSjFmjM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=M6+5CtVYBSjMctPjxfSicRKH4S9mUeWB5BgS6kuqUCNOwWWczPA4trIIW9y6McZbO Z5ry7o3jYSUL2J04mj534l5nGsp3gSDwZ8s3HVcnTxYQHSH+plExS5w5oLFj+sFZyS WkrliibJizmLWFKKP0RTzjrl7P8qyve+RRhp0V9c= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 014CD3891C0F for ; Mon, 10 Jan 2022 09:19:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 014CD3891C0F Received: by mail-wm1-x32d.google.com with SMTP id n19-20020a7bc5d3000000b003466ef16375so9301081wmk.1 for ; Mon, 10 Jan 2022 01:19:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=VYjCxgFbwu7J0LJ752yzDEjxG7BpjAyyrw27sSjFmjM=; b=hZMQdE9D+5mZI8Lv6X3PX+bk4uKIZU0JPeXE0nF7Wr6ivvml641kuJDSU5Uii8bh6w H+8l7pc6VdWQ2P1g2GVQOy5nB00y/JFtmOdfRHkiHKo2D5tskAnJXhLmfV4MZfJYE74r AcaeSewbOnC5RqfJWASbivK1PPWQxRiIfM3yBR4BI7z1CRD0tdxMMCytIarP6VahMgr3 DpwRvGJnxnBDgNC9pO9x3AwpzGgYNEbFCCpojRdgjwgZbcNyguo6ZVqffaVmF/HPtl7O pXY+BzPZ5q/nlSRxLWgJPHB0UiwjFlkS1MG/ekqoRze/LBwD0QbcVONh/yf6LVmVQtqf KaPA== X-Gm-Message-State: AOAM5300qF286+oF2/IKhky7rIqZwKmvjlt7t3qd+LjOAAmdIfcajEQO C0KEJOUL4rnkxePFIntuWh7XRv3r7899yhHC X-Google-Smtp-Source: ABdhPJxHrAAPr1nhkgFQOAiO6a3drmJ4fnGPT5+309Zt5MA+wwsxI/xF1I8tjr4nlVCw2F64i2H2bg== X-Received: by 2002:a05:600c:4998:: with SMTP id h24mr20973535wmp.188.1641806344958; Mon, 10 Jan 2022 01:19:04 -0800 (PST) Received: from fomalhaut.localnet ([2a01:e0a:41b:84f0:cf71:f5e0:b050:bede]) by smtp.gmail.com with ESMTPSA id b13sm6297356wrh.32.2022.01.10.01.19.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 01:19:04 -0800 (PST) X-Google-Original-From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: [patch] Fix PR target/103465 Date: Mon, 10 Jan 2022 10:19:03 +0100 Message-ID: <4369935.LvFx2qVVIh@fomalhaut> MIME-Version: 1.0 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eric Botcazou via Gcc-patches From: Eric Botcazou Reply-To: Eric Botcazou Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi, this PR uncovered that -freorder-blocks-and-partition was working by accident on 64-bit Windows, i.e. the middle-end was supposed to disable it with SEH. After Martin's change, the middle-end properly disables it now, which is too bad since a significant amount of work went into its implementation for SEH. Tested on x86-64/Windows, OK for all active branches? 2022-01-10 Eric Botcazou PR target/103465 * coretypes.h (unwind_info_type): Swap UI_SEH and UI_TARGET. diff --git a/gcc/coretypes.h b/gcc/coretypes.h index 5d0fc1d915d..506cd334401 100644 --- a/gcc/coretypes.h +++ b/gcc/coretypes.h @@ -228,15 +228,17 @@ enum stack_protector { SPCT_FLAG_EXPLICIT = 4 }; -/* Types of unwind/exception handling info that can be generated. */ +/* Types of unwind/exception handling info that can be generated. + Note that a UI_TARGET (or larger) setting is considered to be + incompatible with -freorder-blocks-and-partition. */ enum unwind_info_type { UI_NONE, UI_SJLJ, UI_DWARF2, - UI_TARGET, - UI_SEH + UI_SEH, + UI_TARGET }; /* Callgraph node profile representation. */