diff mbox series

gcn/mkoffload.cc: Pass -save-temps on for the hsaco step

Message ID 41a0d8cc-f505-7ffd-ccbb-da39e2cb38e0@codesourcery.com
State Committed
Commit 7ef44579787af646d5bae13a91a49ef5d2048f5c
Headers
Series gcn/mkoffload.cc: Pass -save-temps on for the hsaco step |

Commit Message

Tobias Burnus March 13, 2023, 12:25 p.m. UTC 
  Found when comparing '-v -Wl,-v' output as despite -save-temps multiple runs
yielded differed results.

Fixed as attached.
OK for mainline?

Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

Comments

Andrew Stubbs March 13, 2023, 12:59 p.m. UTC | #1 
On 13/03/2023 12:25, Tobias Burnus wrote:
> Found when comparing '-v -Wl,-v' output as despite -save-temps multiple 
> runs
> yielded differed results.
> 
> Fixed as attached.
> OK for mainline?

OK.

Andrew
diff mbox series

Patch

gcn/mkoffload.cc: Pass -save-temps on for the hsaco step

For the assembly/linking step of the device code, the "-save-temps" was not
passed on, such that amdgcn-amdhsa/bin/as and amdgcn-amdhsa's collect2
were invoked with '-o /tmp/cc...' and '@/tmp/cc...', respectively.
The -dump... prefix (...mkoffload.hsaco) was already properly set.

gcc/ChangeLog:

	* config/gcn/mkoffload.cc (main): Pass -save-temps on for the
	hsaco assemble/link.
	

diff --git a/gcc/config/gcn/mkoffload.cc b/gcc/config/gcn/mkoffload.cc
index 9493f89fec3..61bc9273077 100644
--- a/gcc/config/gcn/mkoffload.cc
+++ b/gcc/config/gcn/mkoffload.cc
@@ -1082,6 +1082,9 @@  main (int argc, char **argv)
       if (verbose)
 	obstack_ptr_grow (&ld_argv_obstack, "-v");
 
+      if (save_temps)
+	obstack_ptr_grow (&ld_argv_obstack, "-save-temps");
+
       for (int i = 1; i < argc; i++)
 	if (startswith (argv[i], "-l")
 	    || startswith (argv[i], "-Wl")