RISC-V: Add builtin .def file dependencies

Message ID 375a15e0c2c1c5d0a6f98378973eb7ec5fe941a2.1695084790.git.research_trasio@irq.a4lg.com
State Committed
Commit f45cca26263c3563e9db15e0ba64d4a114316808
Delegated to: Kito Cheng
Headers
Series RISC-V: Add builtin .def file dependencies |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm warning Patch is already merged
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gcc_check--master-arm warning Patch is already merged

Commit Message

Tsukasa OI Sept. 19, 2023, 12:53 a.m. UTC
  From: Tsukasa OI <research_trasio@irq.a4lg.com>

riscv-builtins.cc includes riscv-cmo.def and riscv-scalar-crypto.def
(making dependencies) but their dependencies must be explicitly defined at
the configuration file, t-riscv.

They were the last two .def files without correct dependency information.

gcc/ChangeLog:

	* config/riscv/t-riscv: Add dependencies for riscv-builtins.cc,
	riscv-cmo.def and riscv-scalar-crypto.def.
---
 gcc/config/riscv/t-riscv | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: 68845f7c4d58186cc0a5b09f7511f3c0a8f07e88
  

Comments

Kito Cheng Sept. 19, 2023, 2:43 a.m. UTC | #1
LGTM, thanks for fixing that :)

On Tue, Sep 19, 2023 at 8:54 AM Tsukasa OI via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> riscv-builtins.cc includes riscv-cmo.def and riscv-scalar-crypto.def
> (making dependencies) but their dependencies must be explicitly defined at
> the configuration file, t-riscv.
>
> They were the last two .def files without correct dependency information.
>
> gcc/ChangeLog:
>
>         * config/riscv/t-riscv: Add dependencies for riscv-builtins.cc,
>         riscv-cmo.def and riscv-scalar-crypto.def.
> ---
>  gcc/config/riscv/t-riscv | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/t-riscv b/gcc/config/riscv/t-riscv
> index 104f85c6c8b1..f137e1f17ef3 100644
> --- a/gcc/config/riscv/t-riscv
> +++ b/gcc/config/riscv/t-riscv
> @@ -8,7 +8,9 @@ riscv-builtins.o: $(srcdir)/config/riscv/riscv-builtins.cc $(CONFIG_H) \
>    $(DIAGNOSTIC_CORE_H) $(OPTABS_H) $(RISCV_BUILTINS_H) \
>    $(srcdir)/config/riscv/riscv-ftypes.def \
>    $(srcdir)/config/riscv/riscv-vector-builtins-types.def \
> -  $(srcdir)/config/riscv/riscv-modes.def
> +  $(srcdir)/config/riscv/riscv-modes.def \
> +  $(srcdir)/config/riscv/riscv-cmo.def \
> +  $(srcdir)/config/riscv/riscv-scalar-crypto.def
>         $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \
>                 $(srcdir)/config/riscv/riscv-builtins.cc
>
>
> base-commit: 68845f7c4d58186cc0a5b09f7511f3c0a8f07e88
> --
> 2.42.0
>
  

Patch

diff --git a/gcc/config/riscv/t-riscv b/gcc/config/riscv/t-riscv
index 104f85c6c8b1..f137e1f17ef3 100644
--- a/gcc/config/riscv/t-riscv
+++ b/gcc/config/riscv/t-riscv
@@ -8,7 +8,9 @@  riscv-builtins.o: $(srcdir)/config/riscv/riscv-builtins.cc $(CONFIG_H) \
   $(DIAGNOSTIC_CORE_H) $(OPTABS_H) $(RISCV_BUILTINS_H) \
   $(srcdir)/config/riscv/riscv-ftypes.def \
   $(srcdir)/config/riscv/riscv-vector-builtins-types.def \
-  $(srcdir)/config/riscv/riscv-modes.def
+  $(srcdir)/config/riscv/riscv-modes.def \
+  $(srcdir)/config/riscv/riscv-cmo.def \
+  $(srcdir)/config/riscv/riscv-scalar-crypto.def
 	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \
 		$(srcdir)/config/riscv/riscv-builtins.cc