From patchwork Wed Jun 19 16:13:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Love X-Patchwork-Id: 92455 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DED443886C55 for ; Wed, 19 Jun 2024 16:13:46 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id F2CAB3885C1B for ; Wed, 19 Jun 2024 16:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2CAB3885C1B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2CAB3885C1B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718813601; cv=none; b=Vc3IWagStMnjyWXlIPIawoFmF4MBIWVTGJ4kxAW3jY73QmwzB0vX+/vB7PZt0skjz4d4ljMpTKkL6qvQCvphhbEnPf9uWEfQR6tpuj6ieea59QNpCfATCoxXCCzwOxojkEQUpYMUJW1dak3W79iEcn/NqFO7oLzm0GB1EcGE6eU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718813601; c=relaxed/simple; bh=yTfu4TKXBX/EVo9iZAU+Nl5JTkZ1SqbBKRqJ1PTIWiI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=ONyQtKCosXfW8Ez/lnJ5yRgss4myURwJpwJkzP701ScsJ9wlMZSedV8PZi7dYBQjlNZeJ7vY/2K7xIfrerREpEF9HiIYnH/dMp83Rww7qyb+fwqGF5k/19ZkEtn4ko/+UaOoNrS27jgHkwwSVnyHhmNt2bLSI5wGGYq3e9YaBZ4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JEUHYV017893; Wed, 19 Jun 2024 16:13:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:to:from:subject:content-type :content-transfer-encoding; s=pp1; bh=YqCOK7wP92rp8gRor2kLEXHWB9 3kxHPYsepvaWs5p9U=; b=HX02dn9Xh2eC3+2tzgIMIuq6E6ElSSRWZeKBWH7Bvx +Zit6VsQxL35UR08W+cg1HXY23nU0zf0upRKlQrZfm2RG0XzOJc4XR5QKxG/dTl6 Gdcws6TLkx7ajGDb7Tbq5qOz+GBrXXsL+WAqY9k5AqbqIXhZ+hNGxZmOf0m3aQLr Z3U5n4u+ccjVkVS9xm4TVB+8mXZID1o9fI38HmY2FebCidcPDlf98oHx5t5mz0Bz B34ujqzo6OqgjbFM3lMnPYtMZBwIN/uNBur4waxpeurtqr8t84Lc1zkTVq4wVQna 1ebxWV8McvZ8DO1TIc1xoOuK+TIVf7hEI4Ty/ZG4A5Hg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yv14uga55-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 16:13:19 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45JG4qqs009422; Wed, 19 Jun 2024 16:13:18 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ysqgmww3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 16:13:18 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45JGDEne43123034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 16:13:16 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0F1558083; Wed, 19 Jun 2024 16:13:12 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 231FC58078; Wed, 19 Jun 2024 16:13:12 +0000 (GMT) Received: from [9.67.109.151] (unknown [9.67.109.151]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Jun 2024 16:13:11 +0000 (GMT) Message-ID: <23145286-6f27-41c5-b843-35c7a2283069@linux.ibm.com> Date: Wed, 19 Jun 2024 09:13:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: gcc-patches@gcc.gnu.org, Segher Boessenkool , "bergner@linux.ibm.com" , "Kewen.Lin" , Carl Love From: Carl Love Subject: [PATCH ver2] rs6000, altivec-2-runnable.c update the require-effective-target X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4Dt906fE5g-t59SIz6DGapBqMRRhTkGa X-Proofpoint-ORIG-GUID: 4Dt906fE5g-t59SIz6DGapBqMRRhTkGa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 clxscore=1015 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190119 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org GCC maintainers: version 2: Updated per the feedback from Peter, Kewen and Segher. Note, Peter suggested the -mdejagnu-cpu= value must be power7. The test fails if -mdejagnu-cpu= is set to power7, needs to be power8. Patch has been retested on a Power 10 box, it succeeds with 2 passes and no fails. Per the additional feedback after patch: commit c892525813c94b018464d5a4edc17f79186606b7 Author: Carl Love Date: Tue Jun 11 14:01:16 2024 -0400 rs6000, altivec-2-runnable.c should be a runnable test The test case has "dg-do compile" set not "dg-do run" for a runnable test. This patch changes the dg-do command argument to run. gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog: * gcc.target/powerpc/altivec-2-runnable.c: Change dg-do argument to run. was approved and committed, I have updated the dg-require-effective-target and dg-options as requested so the test will compile with -O2 on a machine that has a minimum support of Power 8 vector hardware. The patch has been tested on Power 10 with no regression failures. Please let me know if this patch is acceptable for mainline. Thanks. Carl ---------------------------------------------------------------- rs6000, altivec-2-runnable.c update the require-effective-target The test requires a minimum of Power8 vector HW and a compile level of -O2. gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog: * gcc.target/powerpc/altivec-2-runnable.c: Change the require-effective-target for the test. --- gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c index 17b23eb9d50..9e7ef89327b 100644 --- a/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c @@ -1,7 +1,7 @@ -/* { dg-do run } */ -/* { dg-options "-mvsx" } */ -/* { dg-additional-options "-mdejagnu-cpu=power8" { target { ! has_arch_pwr8 } } } */ -/* { dg-require-effective-target powerpc_vsx } */ +/* { dg-do run { target vsx_hw } } */ +/* { dg-do compile { target { ! vmx_hw } } } */ +/* { dg-options "-O2 -mdejagnu-cpu=power8" } */ +/* { dg-require-effective-target powerpc_altivec } */ #include