| Message ID | 20261011132538.37431-1-iain@sandoe.co.uk |
|---|---|
| State | Committed |
| Commit | 93bcb5098e398d2df50c125a11978ac435680ebd |
| Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E60654BA23DB for <patchwork@sourceware.org>; Sun, 11 Oct 2026 13:26:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E60654BA23DB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Aw2I8Nih X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id EC1D24BA23C8 for <gcc-patches@gcc.gnu.org>; Sun, 11 Oct 2026 13:25:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC1D24BA23C8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EC1D24BA23C8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791725141; cv=none; b=ZP5XknpN5261W0U3E4/NW7loBmpap/lftiOYCRqUz1NMDSnZC9Zzov8bQhSqZGagMYROwBi6s7A31DYjq6/WFANhXnDoNn6VbY5ewJUqW6m5ZHASA/JKWa6fUV7EmFo0E/XCZzgzMwx/nP9ge4hSr5dt71gZfu7A4u4jFIo5E7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791725141; c=relaxed/simple; bh=ELQ2pD8Q9xeDXiPOHkCEHtPvybhGYNPHeAcold+urbo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ls8sCDYwsu67bEmA4qKFT+AKPP/ARVZl4psDyi1uEfBO1WbuoyTnyhVL15/SRZQ+6OGb8UKR2+ZkWGJgTpPEZLIyYagkBeCf2Yho4bdN61JB74NAOW4znsX+j0Y8fvuS8K4Cqipqp/5n0N5Hm5lzdRlnCKqV2saNAdNeXCcoevU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Aw2I8Nih DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC1D24BA23C8 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-48c02782159so620648f8f.0 for <gcc-patches@gcc.gnu.org>; Sun, 11 Oct 2026 06:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791725140; x=1792329940; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yN/VMgGDspVMZVgr9ZPFI8AgsPFhmHHA+2MGHXlVg1o=; b=Aw2I8NihA8R95BQxUzVzGjScfuMGOoQsjWzXAKH6cWN2zTODFCZhxA83Fix8HF+Jeu VP5tMSGPXNC/JqCiR21HPd+2D5gUKdN8BheBskUo0XcNemJbmE3x/3c0IIEx1UQ3nDKL OoCkOqJ36uHOqVVaTgbOEpiiy6JQ2HqBcRWlz7wmBgSsTFz8UkSluDl4y4Jfm+HGADX9 zrJFye3TDZI4mPijvUq8NYYpQRzFd1CgKPN7CtxECjDrch7YJDB0m3thcjx02Jm/3rYp 8ciRODAfI3Ct20qMAp8UA645CFjoI3p3BEaSaSNcbn3T+aSx5TG86cDQMRaFLQseV7Ao fD1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791725140; x=1792329940; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yN/VMgGDspVMZVgr9ZPFI8AgsPFhmHHA+2MGHXlVg1o=; b=bQxNrfpxLmzYbsj1MuH6IvwKQRowMMpF2hidSeHxvHJypl0Gkzn+aOE/H8Y7uLA4nY R7iQSlbUtQ9L8xTz9NkppI6DQZyOmpSY5aRptKqrg09R8S6rikICpUuBmdV/9fYogw1E eJTxGlQ3682A4cchZVO2Z69tEBJEbiBpW8q4lhNdir/ZWnJ7GBgz2993gt1ZpVPM2Llx OalrLgsasDnvEoadbOXvcsUKBjoZ8OFYQoBj1VG9JzTlbxUIHlYw2j/M34eIV95elOqZ j2ilxinOg+TUNTJWAxjy0GwEmIkJ9B7pbIpsJAVK2ukjFWIhv9/1hbwF8ibAtl68Jz0v oxzg== X-Forwarded-Encrypted: i=1; AKwUvBw6B8xh4WllMqbj4AnpXFvPmlUyP94CNOYcr7TYp8yah3EPZL8OSxDS0hlklEDm5Z0NtVFnxzNKAhmqHQ==@gcc.gnu.org X-Gm-Message-State: AFq9FYL/s3Vw9Bmv2PUbxF8BE2BUq/5UoHsF5ssX433k8Q69Xyj/hKer 6CQmO2/KLVL/RQi8y84ee8ZUh5ZYchYXNoF9yNmfyZxK4sMKcOhKkZcd X-Gm-Gg: AYBFou1ccSPXEAyZk10JV8ijggX1BJBmHfYVR5mWokJsfJNyrF3Cdn4b9/tVydPNYNv RV5i9W/nimVRpff96J5DnIH5n4l845CsFUTxwZQ90KIKXrPoY0OTQuxfsAkTrA1G9GmFeDDZfjt H69uSOFjrduCS0TChi2hlinNnj4CdtpgDnpNyFwop2ri1dXk28LFL52K7ePgi4UcjiaSAffbRoE om7sh1pK4qIzScR1tgLrN+MG/PR0DWLHBDr0vnq6qTwKIFGJ7WJpiue1cnqHnpcKZmhsTMJZDNu tM/6qJtEwL5VcnzFvEh1ElBbkO2N3KwiwItpsDFHcevvw6xkP06jYAvdkrIpl8LsIa/zng4BZKA lHpRJXtn5Q6Ybnw//s//gpxV5JV/An+TcVUJ+OojkDteKt+jTeGoLSlKtpHJGaABYUPtwO1FnqB BIOfFw7ehIcKyF/bqsxmvcXa1beFjVw2oh5rOK5PnvM/1QjeRgkYzhPhWIzGFvDWmuQ/Zy7id6p nTI8jRVQ1Qm+p0QTiCBhlK/e/AQ2T9mZWU5LHckA1YuQdVXKxNtiQbo/g== X-Received: by 2002:a05:6000:41cc:b0:48d:bae6:d7ba with SMTP id ffacd0b85a97d-48dbae6d911mr11321474f8f.26.1791725139314; Sun, 11 Oct 2026 06:25:39 -0700 (PDT) Received: from localhost.localdomain (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db9abd574sm14498622f8f.34.2026.10.11.06.25.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 11 Oct 2026 06:25:39 -0700 (PDT) From: Iain Sandoe <iains.gcc@gmail.com> X-Google-Original-From: Iain Sandoe <iain@sandoe.co.uk> To: gaiusmod2@gmail.com, gcc-patches@gcc.gnu.org Subject: [PATCH] modula-2, make: Do not declare m2.pod .INTERMEDIATE Date: Sun, 11 Oct 2026 14:25:13 +0100 Message-ID: <20261011132538.37431-1-iain@sandoe.co.uk> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Reply-To: iain@sandoe.co.uk Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
| Series |
modula-2, make: Do not declare m2.pod .INTERMEDIATE
|
|
Commit Message
Iain Sandoe
Oct. 11, 2026, 1:25 p.m. UTC
As discussed at the Cauldron ..
Tested on x86_64-linux/darwin, OK for trunk?
thanks, Iain.
--- 8< ---
It appears that make 3.81 has a latent bug that is triggered by a combination
of modula2 build recipe entries that appear to be correct. In particular
marking the m2.pod file as .INTERMEDIATE produces a situation which a clean
build of the compiler works, as does any non-parallel rebuild. However any
parallel rebuild results in make spinning with a single process at 100%.
Other similar recipes in Fortran and D appear to work as expected, there is
some subtle difference in the m2 case.
The solution that works to allow a rebuild with j > 1 is to remove the
.INTERMEDIATE marking on the m2.pod (and to make it explictly deleted on
clean).
gcc/m2/ChangeLog:
* Make-lang.in: Do not mark m2.pod as .INTERMEDIATE but delete it
explicitly in clean targets.
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
---
gcc/m2/Make-lang.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
Iain Sandoe <iains.gcc@gmail.com> writes: > As discussed at the Cauldron .. > Tested on x86_64-linux/darwin, OK for trunk? > thanks, Iain. yes lgtm - many thanks! regards, Gaius > --- 8< --- > > It appears that make 3.81 has a latent bug that is triggered by a combination > of modula2 build recipe entries that appear to be correct. In particular > marking the m2.pod file as .INTERMEDIATE produces a situation which a clean > build of the compiler works, as does any non-parallel rebuild. However any > parallel rebuild results in make spinning with a single process at 100%. > > Other similar recipes in Fortran and D appear to work as expected, there is > some subtle difference in the m2 case. > > The solution that works to allow a rebuild with j > 1 is to remove the > .INTERMEDIATE marking on the m2.pod (and to make it explictly deleted on > clean). > > gcc/m2/ChangeLog: > > * Make-lang.in: Do not mark m2.pod as .INTERMEDIATE but delete it > explicitly in clean targets. > > Signed-off-by: Iain Sandoe <iain@sandoe.co.uk> > --- > gcc/m2/Make-lang.in | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/gcc/m2/Make-lang.in b/gcc/m2/Make-lang.in > index d7c46ec1a19..e4f37a155b9 100644 > --- a/gcc/m2/Make-lang.in > +++ b/gcc/m2/Make-lang.in > @@ -189,8 +189,6 @@ m2.install-pdf: $(M2_PDFFILES) > $(INSTALL_DATA) "$$d$$p" "$(DESTDIR)$(pdfdir)/gcc/$$f"; \ > done > > -.INTERMEDIATE: m2.pod > - > m2.pod: $(TEXISRC) | $(objdir)/m2/images/gnu.eps $(TEXILIBSRC) > -$(TEXI2POD) -I $(objdir)/m2 -D m2 < $< > $@ > > @@ -412,6 +410,7 @@ endif > > m2.mostlyclean: > -rm -f m2/*.o > + -rm -f m2.pod > > m2.clean: > -rm -f m2/*.o
diff --git a/gcc/m2/Make-lang.in b/gcc/m2/Make-lang.in index d7c46ec1a19..e4f37a155b9 100644 --- a/gcc/m2/Make-lang.in +++ b/gcc/m2/Make-lang.in @@ -189,8 +189,6 @@ m2.install-pdf: $(M2_PDFFILES) $(INSTALL_DATA) "$$d$$p" "$(DESTDIR)$(pdfdir)/gcc/$$f"; \ done -.INTERMEDIATE: m2.pod - m2.pod: $(TEXISRC) | $(objdir)/m2/images/gnu.eps $(TEXILIBSRC) -$(TEXI2POD) -I $(objdir)/m2 -D m2 < $< > $@ @@ -412,6 +410,7 @@ endif m2.mostlyclean: -rm -f m2/*.o + -rm -f m2.pod m2.clean: -rm -f m2/*.o