diff mbox series

toplevel: disable D for gettext-runtime

Message ID 20261002222815.147218-1-aarsenovic@baylibre.com
State New
Headers
Series toplevel: disable D for gettext-runtime |

Commit Message

Arsen Arsenović Oct. 2, 2026, 10:25 p.m. UTC 
  Hi Tamar,

I mentioned this today, and you mentioned it a while ago.

Didn't give it a full test yet, but:

  ~/gcc/_b_gcc/gettext$ grep BUILDD config.status
  S["BUILDD"]="no"

... and:

  ~/gcc/_b_gcc/gettext/intl-d$ make
  make: Nothing to be done for 'all'.

... seem to indicate it had the right effect (the former is 'yes' w/o
this patch).

Please try it in the configuration where you saw the build fails.

See ya tomorrow.
---------- >8 ----------
Added in a recent version of gettext, we don't use it but it risks
inducing build failures.

ChangeLog:

	* Makefile.def (host_modules gettext): Pass --disable-d via
	extra_configure_flags.
	* Makefile.in: Regenerate.
---
 Makefile.def |  2 +-
 Makefile.in  | 20 ++++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)

Comments

Iain Buclaw Oct. 15, 2026, 9:47 a.m. UTC | #1 
Excerpts from Arsen Arsenović's message of Oktober 3, 2026 12:25 am:
> Hi Tamar,
> 
> I mentioned this today, and you mentioned it a while ago.
> 
> Didn't give it a full test yet, but:
> 
>   ~/gcc/_b_gcc/gettext$ grep BUILDD config.status
>   S["BUILDD"]="no"
> 
> ... and:
> 
>   ~/gcc/_b_gcc/gettext/intl-d$ make
>   make: Nothing to be done for 'all'.
> 
> ... seem to indicate it had the right effect (the former is 'yes' w/o
> this patch).
> 
> Please try it in the configuration where you saw the build fails.
> 
> See ya tomorrow.
> ---------- >8 ----------
> Added in a recent version of gettext, we don't use it but it risks
> inducing build failures.
> 
> ChangeLog:
> 
> 	* Makefile.def (host_modules gettext): Pass --disable-d via
> 	extra_configure_flags.
> 	* Makefile.in: Regenerate.
> ---
>  Makefile.def |  2 +-
>  Makefile.in  | 20 ++++++++++----------
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 

Hi Arsen,

Would the same need to be done for modula2 as well?

And if not, then I'd be interested to know why.

Iain.
Arsen Arsenović Oct. 15, 2026, 9:51 a.m. UTC | #2 
Hi Iain,

Iain Buclaw <ibuclaw@gdcproject.org> writes:

> Would the same need to be done for modula2 as well?
>
> And if not, then I'd be interested to know why.

Yes, almost certainly.

I did not realize there are modula2 bindings in gettext.

Thanks for the heads-up.
Iain Buclaw Oct. 15, 2026, 10:29 a.m. UTC | #3 
Excerpts from Arsen Arsenović's message of Oktober 15, 2026 11:51 am:
> Hi Iain,
> 
> Iain Buclaw <ibuclaw@gdcproject.org> writes:
> 
>> Would the same need to be done for modula2 as well?
>>
>> And if not, then I'd be interested to know why.
> 
> Yes, almost certainly.
> 
> I did not realize there are modula2 bindings in gettext.
> 
> Thanks for the heads-up.

I fetched gettext-1.0 and peeked in the gnulib-local/m4 directory.

```
gettext-1.0 $ ls gnulib-local/m4/
backupfile.m4  d.m4  java.m4  libxml.m4  modula2.m4

gettext-1.0 $ ls gettext-runtime/intl-modula2/
HACKING  Libintl.def.in  LibintlFromC.def  Libintl.mod  Makefile.am  Makefile.in
```

Iain.
diff mbox series

Patch

diff --git a/Makefile.def b/Makefile.def
index c31ee798bba..998a40ea015 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -80,7 +80,7 @@  host_modules= { module= gettext; bootstrap=true; no_install=true;
 		// need it in some configurations, which is determined via nontrivial tests.
 		// Always enabling pic seems to make sense for something tied to
 		// user-facing output.
-		extra_configure_flags='--disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf';
+		extra_configure_flags='--disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf';
 		missing= pdf;
 		missing= html;
 		missing= info;
diff --git a/Makefile.in b/Makefile.in
index 7fd91da3f2d..59221c216a7 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -19991,7 +19991,7 @@  configure-gettext:
 	  $$s/$$module_srcdir/configure \
 	  --srcdir=$${topdir}/$$module_srcdir \
 	  $(HOST_CONFIGARGS) --build=${build_alias} --host=${host_alias} \
-	  --target=${target_alias} --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf \
+	  --target=${target_alias} --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf \
 	  || exit 1
 @endif gettext
 
@@ -20027,7 +20027,7 @@  configure-stage1-gettext:
 	  --target=${target_alias} \
 	   \
 	  $(STAGE1_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stage2-gettext maybe-configure-stage2-gettext
@@ -20061,7 +20061,7 @@  configure-stage2-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGE2_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stage3-gettext maybe-configure-stage3-gettext
@@ -20095,7 +20095,7 @@  configure-stage3-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGE3_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stage4-gettext maybe-configure-stage4-gettext
@@ -20129,7 +20129,7 @@  configure-stage4-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGE4_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stageprofile-gettext maybe-configure-stageprofile-gettext
@@ -20163,7 +20163,7 @@  configure-stageprofile-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGEprofile_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stagetrain-gettext maybe-configure-stagetrain-gettext
@@ -20197,7 +20197,7 @@  configure-stagetrain-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGEtrain_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stagefeedback-gettext maybe-configure-stagefeedback-gettext
@@ -20231,7 +20231,7 @@  configure-stagefeedback-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGEfeedback_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stageautoprofile-gettext maybe-configure-stageautoprofile-gettext
@@ -20265,7 +20265,7 @@  configure-stageautoprofile-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGEautoprofile_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap
 
 .PHONY: configure-stageautofeedback-gettext maybe-configure-stageautofeedback-gettext
@@ -20299,7 +20299,7 @@  configure-stageautofeedback-gettext:
 	  --target=${target_alias} \
 	  --with-build-libsubdir=$(HOST_SUBDIR) \
 	  $(STAGEautofeedback_CONFIGURE_FLAGS) \
-	  --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
+	  --disable-d --disable-shared --disable-threads --disable-java --disable-csharp --with-pic --disable-libasprintf
 @endif gettext-bootstrap