diff mbox series

rs6000: Fix vec-msumc.c failure on BE 32-bit multilib [PR 127278]

Message ID 20261002161329.14171-1-mmatti.gnu@gmail.com
State New
Headers
Series rs6000: Fix vec-msumc.c failure on BE 32-bit multilib [PR 127278] |

Commit Message

Manjunath Matti Oct. 2, 2026, 4:13 p.m. UTC 
  Add the int128 effective-target requirement, the test then
becomes UNSUPPORTED for -m32 and is unchanged for -m64 on both
endiannesses.

Tested on powerpc64-linux-gnu (-m64 and -m32) and
powerpc64le-linux-gnu.

2026-10-02  Manjunath Matti  <mmatti.gnu@gmail.com>

gcc/testsuite/
	PR target/127278
	* gcc.target/powerpc/vec-msumc.c: Add int128
	effective-target.

Comments

jeevitha Oct. 6, 2026, 11:02 a.m. UTC | #1 
On 02/10/26 9:43 pm, Manjunath S Matti wrote:
> Add the int128 effective-target requirement, the test then
> becomes UNSUPPORTED for -m32 and is unchanged for -m64 on both
> endiannesses.
>
 
Just a small wording change: use "int128 effective-target check"
instead of "int128 effective-target requirement"?

Other than this small change, it looks correct.

Thanks,
Jeevitha.

> Tested on powerpc64-linux-gnu (-m64 and -m32) and
> powerpc64le-linux-gnu.
> 
> 2026-10-02  Manjunath Matti  <mmatti.gnu@gmail.com>
> 
> gcc/testsuite/
> 	PR target/127278
> 	* gcc.target/powerpc/vec-msumc.c: Add int128
> 	effective-target.
> 
> diff --git a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> index 524a2225c6c..c9db899c2f9 100644
> --- a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> +++ b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run { target { power10_hw } } } */
> +/* { dg-require-effective-target int128 } */
>  /* { dg-require-effective-target power10_ok } */
>  /* { dg-options "-mdejagnu-cpu=power10 -O2" } */
>  #include <altivec.h>
Manjunath Matti Oct. 7, 2026, 5:57 a.m. UTC | #2 
Any other comments or is it good to go in? Since this is just a one line
fix.

On Tue, Oct 6, 2026 at 4:32 PM jeevitha <jeevitha@linux.ibm.com> wrote:

>
>
> On 02/10/26 9:43 pm, Manjunath S Matti wrote:
> > Add the int128 effective-target requirement, the test then
> > becomes UNSUPPORTED for -m32 and is unchanged for -m64 on both
> > endiannesses.
> >
>
> Just a small wording change: use "int128 effective-target check"
> instead of "int128 effective-target requirement"?
>
> Other than this small change, it looks correct.
>
> Thanks,
> Jeevitha.
>
> > Tested on powerpc64-linux-gnu (-m64 and -m32) and
> > powerpc64le-linux-gnu.
> >
> > 2026-10-02  Manjunath Matti  <mmatti.gnu@gmail.com>
> >
> > gcc/testsuite/
> >       PR target/127278
> >       * gcc.target/powerpc/vec-msumc.c: Add int128
> >       effective-target.
> >
> > diff --git a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > index 524a2225c6c..c9db899c2f9 100644
> > --- a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > +++ b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > @@ -1,4 +1,5 @@
> >  /* { dg-do run { target { power10_hw } } } */
> > +/* { dg-require-effective-target int128 } */
> >  /* { dg-require-effective-target power10_ok } */
> >  /* { dg-options "-mdejagnu-cpu=power10 -O2" } */
> >  #include <altivec.h>
>
>
Michael Meissner Oct. 7, 2026, 6 a.m. UTC | #3 
On Wed, Oct 07, 2026 at 11:27:06AM +0530, Manjunath Matti wrote:
> Any other comments or is it good to go in? Since this is just a one line
> fix.

Looks good to me.

> On Tue, Oct 6, 2026 at 4:32 PM jeevitha <jeevitha@linux.ibm.com> wrote:
> 
> >
> >
> > On 02/10/26 9:43 pm, Manjunath S Matti wrote:
> > > Add the int128 effective-target requirement, the test then
> > > becomes UNSUPPORTED for -m32 and is unchanged for -m64 on both
> > > endiannesses.
> > >
> >
> > Just a small wording change: use "int128 effective-target check"
> > instead of "int128 effective-target requirement"?
> >
> > Other than this small change, it looks correct.
> >
> > Thanks,
> > Jeevitha.
> >
> > > Tested on powerpc64-linux-gnu (-m64 and -m32) and
> > > powerpc64le-linux-gnu.
> > >
> > > 2026-10-02  Manjunath Matti  <mmatti.gnu@gmail.com>
> > >
> > > gcc/testsuite/
> > >       PR target/127278
> > >       * gcc.target/powerpc/vec-msumc.c: Add int128
> > >       effective-target.
> > >
> > > diff --git a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > > index 524a2225c6c..c9db899c2f9 100644
> > > --- a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > > +++ b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
> > > @@ -1,4 +1,5 @@
> > >  /* { dg-do run { target { power10_hw } } } */
> > > +/* { dg-require-effective-target int128 } */
> > >  /* { dg-require-effective-target power10_ok } */
> > >  /* { dg-options "-mdejagnu-cpu=power10 -O2" } */
> > >  #include <altivec.h>
> >
> >
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
index 524a2225c6c..c9db899c2f9 100644
--- a/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
+++ b/gcc/testsuite/gcc.target/powerpc/vec-msumc.c
@@ -1,4 +1,5 @@ 
 /* { dg-do run { target { power10_hw } } } */
+/* { dg-require-effective-target int128 } */
 /* { dg-require-effective-target power10_ok } */
 /* { dg-options "-mdejagnu-cpu=power10 -O2" } */
 #include <altivec.h>