From patchwork Wed Aug 5 14:17:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 140660 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A21A64BAE7EA for ; Wed, 5 Aug 2026 14:20:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A21A64BAE7EA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=quesejoda.com header.i=@quesejoda.com header.a=rsa-sha256 header.s=dreamhost header.b=Ac4HyN8d X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from duck.ash.relay.mailchannels.net (duck.ash.relay.mailchannels.net [23.83.222.52]) by sourceware.org (Postfix) with ESMTPS id 96A6B4BA9003 for ; Wed, 5 Aug 2026 14:18:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 96A6B4BA9003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=quesejoda.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quesejoda.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 96A6B4BA9003 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.222.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785939500; cv=none; b=xGngxYTs4KnzzIiATn2uNCmGCkiClBeF7GAL1sLJ7ZVrmOCWF4a/erhlTmOD0KMYhBW4OZoDu5L2rNESuh/dPigC33azmhpVGVwFj9HpWTi1jNvfGZOV8DIAI0zOJabYaYrxIIQ4HfSsyXYvH7sSGA587y+FNXwYRqf1sIQB1L0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785939500; c=relaxed/simple; bh=+QiqFZv7ThnsCJrdcq4W+QqjdVR+9YgSp6/xBWIBfdA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bRsZZVMoPibwJWZHJd4KDkof07ZzJYWW2IqwxlOQoh4r4aWf0j0QRwN4/MVUVSWoWzFDO8o7uuXt0KrbtZAuSScsf1xuflmN2xCj6Xmdwhq1dVIKTzmPO68l/10Y14gEXOKHJZi30BUf4em1GNtukgr70xJgqrhnqLDoXXltdWc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=quesejoda.com header.i=@quesejoda.com header.a=rsa-sha256 header.s=dreamhost header.b=Ac4HyN8d DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96A6B4BA9003 X-Sender-Id: dreamhost|x-authsender|aldy@quesejoda.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 58DE94617D5; Wed, 05 Aug 2026 14:18:18 +0000 (UTC) Received: from pdx1-sub0-mail-a205.dreamhost.com (trex-green-8.trex.outbound.svc.cluster.local [100.111.248.111]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1A228461468; Wed, 05 Aug 2026 14:18:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|aldy@quesejoda.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|aldy@quesejoda.com X-MailChannels-Auth-Id: dreamhost X-White-Cooing: 2ddfdd697d0878a9_1785939498233_3147736083 X-MC-Loop-Signature: 1785939498233:3180581256 X-MC-Ingress-Time: 1785939498233 Received: from pdx1-sub0-mail-a205.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.111.248.111 (trex/8.0.2); Wed, 05 Aug 2026 14:18:18 +0000 Received: from vesper.quesejoda.com (224.85-85-184.dynamic.clientes.euskaltel.es [85.85.184.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aldy@quesejoda.com) by pdx1-sub0-mail-a205.dreamhost.com (Postfix) with ESMTPSA id 4hFXYz5rkrz3J; Wed, 5 Aug 2026 07:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quesejoda.com; s=dreamhost; t=1785939480; bh=HVW16ZFopyhF4qWIMLBp2NuBb+UdvcBAT0FflwHXcUQ=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=Ac4HyN8dRFjwkMJwKmaNsiEzrWRAzT9R3X3GzFjwLDE5sVFnrKV+7L5VlEeGW0p3o /LolAYIoZpiWkulT3SGrIYQgKFzdCfz9YSL7lYevi5FIlTXeIf90Xc4Zyiada0n1/E BX1Pj9ya88kUOWs87cZyAEvvtANliB0YDQtgDctqz7PHEhZH3izwcoo0UzZCaLspPb sMImFFy1bNyhMCiJOMKTW3biOHhdNaFBopmEbcOvY+dArCqileC6Q8PLwEnyT5OFRm KzXn565D/6PRuCgzf7Qlvpw3brYEXLd1OS0Nx5H5CUbSb5VgSdaKRRXutNVknrUzla C9CRM143aTu9w== From: Aldy Hernandez To: gcc-patches@gcc.gnu.org Cc: jakub@redhat.com, amacleod@redhat.com, rguenther@suse.de, Aldy Hernandez Subject: [PATCH 2/4] Use !contains_zero_p for known nonzero tests instead of nonzero_p. Date: Wed, 5 Aug 2026 16:17:23 +0200 Message-ID: <20260805141722.3769280-6-aldy@quesejoda.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260805141722.3769280-2-aldy@quesejoda.com> References: <20260805141722.3769280-2-aldy@quesejoda.com> MIME-Version: 1.0 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_PBL, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org These callers ask whether a range excludes zero, which nonzero_p () only approximated (i.e. it is false for e.g. [1, 5]). Tested on ppc64le Linux. gcc/ChangeLog: * gimple-range-path.cc (path_range_query::adjust_for_non_null_uses): Use !contains_zero_p instead of nonzero_p. * tree-ssa-structalias.cc (find_what_p_points_to): Likewise. * tree-ssanames.cc (set_range_info): Likewise. * tree-vrp.cc (execute_ranger_vrp): Likewise. gcc/analyzer/ChangeLog: * region-model.cc (region_model::eval_condition): Likewise. --- gcc/analyzer/region-model.cc | 2 +- gcc/gimple-range-path.cc | 2 +- gcc/tree-ssa-structalias.cc | 2 +- gcc/tree-ssanames.cc | 2 +- gcc/tree-vrp.cc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index 8addf1d9a07..f385e008fa7 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -5161,7 +5161,7 @@ region_model::eval_condition (const svalue *lhs, { if (out.zero_p ()) return tristate::TS_FALSE; - if (out.nonzero_p ()) + if (!out.contains_zero_p ()) return tristate::TS_TRUE; } } diff --git a/gcc/gimple-range-path.cc b/gcc/gimple-range-path.cc index a8d137741f1..8a89da3dda3 100644 --- a/gcc/gimple-range-path.cc +++ b/gcc/gimple-range-path.cc @@ -460,7 +460,7 @@ path_range_query::adjust_for_non_null_uses (basic_block bb) if (get_cache (r, name)) { - if (r.nonzero_p ()) + if (!r.contains_zero_p ()) continue; } else diff --git a/gcc/tree-ssa-structalias.cc b/gcc/tree-ssa-structalias.cc index 30f911e2c72..76fb3600e74 100644 --- a/gcc/tree-ssa-structalias.cc +++ b/gcc/tree-ssa-structalias.cc @@ -934,7 +934,7 @@ find_what_p_points_to (tree fndecl, tree p) varinfo_t vi; prange vr; get_range_query (DECL_STRUCT_FUNCTION (fndecl))->range_of_expr (vr, p); - bool nonnull = vr.nonzero_p (); + bool nonnull = !vr.contains_zero_p (); /* For parameters, get at the points-to set for the actual parm decl. */ diff --git a/gcc/tree-ssanames.cc b/gcc/tree-ssanames.cc index d2ebb49909f..9ad860df65a 100644 --- a/gcc/tree-ssanames.cc +++ b/gcc/tree-ssanames.cc @@ -429,7 +429,7 @@ set_range_info (tree name, const vrange &r) { struct ptr_info_def *pi = get_ptr_info (name); // If R is nonnull and pi is not, set nonnull. - if (r.nonzero_p () && (!pi || pi->pt.null)) + if (!r.contains_zero_p () && (!pi || pi->pt.null)) set_ptr_nonnull (name); else return false; diff --git a/gcc/tree-vrp.cc b/gcc/tree-vrp.cc index 49eeedb8266..da65d67b405 100644 --- a/gcc/tree-vrp.cc +++ b/gcc/tree-vrp.cc @@ -1139,7 +1139,7 @@ execute_ranger_vrp (struct function *fun, bool final_p) { ipa_record_return_value_range (return_range); if (POINTER_TYPE_P (TREE_TYPE (TREE_TYPE (current_function_decl))) - && return_range.nonzero_p () + && !return_range.contains_zero_p () && cgraph_node::get (current_function_decl) ->add_detected_attribute ("returns_nonnull")) warn_function_returns_nonnull (current_function_decl);