From patchwork Wed Jun 3 02:07:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Pinski X-Patchwork-Id: 136347 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A61B4BA2E2C for ; Wed, 3 Jun 2026 02:08:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A61B4BA2E2C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=NxmQ1n/M; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=DGGcQ9So X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id 392094BA2E1C for ; Wed, 3 Jun 2026 02:07:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 392094BA2E1C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oss.qualcomm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 392094BA2E1C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780452434; cv=none; b=EJc1ewXVp+G5k2oqoEPRc4SBP6hgWkFmL/Mbjg8MutKJI+Fz9frOBxrTxQt0PduA+bknteRq0DFj0oq0x/2WqfkmB40SP2pQRvDWoO69T45UVqYocOysgRKpdBSCNcVZgf9SjXyPeUq1+XfRq+a1LlpxgTmE95XiovVSpu8Ud58= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780452434; c=relaxed/simple; bh=C5+06dE04pgx9uA1sQ9BJrfNmHX9N7JS4h0cTOIVPE8=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=MM+l+uN/2sdspM74H4aAe4MR9nPmDR7aqn3jJw8fUxE+F3nffezRpz233sX3WdOpMmU59dTL7cubxJmJFyS4hS3Ar41zh+VVky8NIH3VddsiKirJE34+ia+NpmgigFab3D80oJxYswJWKNdbNR4h99Pg9eGwJgOdKclnesfNPfM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=NxmQ1n/M; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=DGGcQ9So DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 392094BA2E1C Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65318Eb02388904 for ; Wed, 3 Jun 2026 02:07:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=//b7Xaw65LOR76bEExmk9/FUsottVardzXF ykYJWZ7M=; b=NxmQ1n/MWbNa/gslq5hvpnDkk1RO3A73JtmG0E8a7yK1Rx7stOo RbaOx5ueuXU3HI8byPljP5bGpIO90tJvrXEnjMOWYIFWXICRZJaMAqTdJtetCcRA HyUtldQtc/wlo4CggwqtjRotp+DOFp1yb0dqP+mfK8N+uFXOV/j0LukYNCLJSg3T 61BmcEWGfgfLBAbfnwH8xAs6JqDyjvfa/VQiXdt6pLa2vJ6SdjOF2z+/YqWgEGg1 BdGXD8GjP65rdAgEQ2eMiS7ZJo4hjdauQi3HzT7xE//73nHfvhHQIQUfycMmMdKE 8yVg2Ciiy80sabEVfCmUXQF2c9ZXAcCG+Kg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejabbr6am-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 02:07:13 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36d97a4e08fso2794028a91.0 for ; Tue, 02 Jun 2026 19:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780452432; x=1781057232; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=//b7Xaw65LOR76bEExmk9/FUsottVardzXFykYJWZ7M=; b=DGGcQ9SobZ9BC4wcKs5DCexchgRZfUfHU3jLogFJdr89ekIJp4ycTtS1FPVMQI/JgY pmdN7ce9rfQpqGOXhy1K6wJ+lwUVsiwGOi66yx4Hl7zNsTyyIgVw6NYJ2X/95WsoeY1i qq2It8DxZGQ2+6m5mcLSRno8P0JNHwWs6XbVeeycEnGHHtggtnTOt7zilXC6NMl1bf4V KdTBNBFmsZ38OK3PlT0SynV9l6XCXkgtEPc5v7WLdHU+ZIP5pFelU4LtLDnh1UPE7mF/ rzA1C67Q3rZN4C1TvyDkzI4VWhjT955zyCgulLcmh7EIOZUXJx2338c9FWQEtyfLes0F MzAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780452432; x=1781057232; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=//b7Xaw65LOR76bEExmk9/FUsottVardzXFykYJWZ7M=; b=pN69Z/TVL9hrJngwOcIDbTvZs7CJAha3qPIwO3/DuJqTeHV6cv69EnLPDNzaEHJ7np QW3T+e6TIlq+KkQU1AIa4wwzpl2lCySKgwpQOhJwc/LLr8ib/D+IXv70a4IOzrfAscQ5 Jrj1h6Zj4UxtMU+R4LfyEtSKnydc0j7njtzRBR6BNSdU5V4xSnEVtL/I+jVTn40vyE43 eu4yBv5I3cRqfr4TmAsj2qK9soUvwss7MP5w4zh7niSjQegwrQOVp2ZCh8WNAK6a308q c8vrtFJTNe8Oh1/6ILf+M5iXU6Grc456FEFU6PGuEMEvS1a68/nkaSVUwVuevJfXMzIN 1r4w== X-Gm-Message-State: AOJu0Yx0ogwnAiTsfl1lho/sOJ3nFV37KIkT07U+QdxlWnxMvsgqgoJC pMjC0IKVVfXZPTT4UAF+r3tBsxljheGqSRD4h3cLvbIEouST5vGq+XbPtcmoU+WPAzxTCtZDZfo rk+ZtBHVbQbx6TAA0CREN7udXi4g7apgaU3UfeCPSEODv2615yHTSCLKdcmD8Ri9ijUOn X-Gm-Gg: Acq92OHjXQeZltJmA105G8GSe/q4X0jrxrxueX4OLR4hwUkKgfXFdqp7IXtkFQHOiqx I0liMAJjElPyLFDwPH3dJbFWlnOnt5lBQe6jIiRCDQlP/0SHNJp3Cs0jheOZYdo4fn721c+6WSX k+o7dVLJiYehCBio2gSBob3N/0MpUpSXzS4Hk8AbPh3tW51rdWMQ8CSVvl5qh9nDs7UmofpLKQ6 zFBEdV1eCcYQktvvW+LNWvNcLNEVo6Lqz5kUBbVsaQybkbvAKwPwAj6eVHxa91++jVNjxnjUX8i p0Uk2Bqc6uRYM8RxHB+Ah8iiPlPKcUFQUB8bSccWQt+lPTArhGHEdbqSq+d08/HPobVQvmX//vu cloNafzioQRdYeJXtT5R8RPgG+vVjAeXEkIIrhycKJ0nBI5kWDSKpL20pksk= X-Received: by 2002:a17:90b:180d:b0:36b:9798:4f6a with SMTP id 98e67ed59e1d1-36e30e1463emr1279568a91.10.1780452432363; Tue, 02 Jun 2026 19:07:12 -0700 (PDT) X-Received: by 2002:a17:90b:180d:b0:36b:9798:4f6a with SMTP id 98e67ed59e1d1-36e30e1463emr1279538a91.10.1780452431806; Tue, 02 Jun 2026 19:07:11 -0700 (PDT) Received: from xeond2.wrightpinski.org ([98.97.35.182]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36dd91846f8sm4799556a91.4.2026.06.02.19.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 19:07:11 -0700 (PDT) From: Andrew Pinski To: gcc-patches@gcc.gnu.org Cc: Andrew Pinski Subject: [PATCH] tree-core: Remove ENUM_BITFIELD from tree-core.h [PR125507] Date: Tue, 2 Jun 2026 19:07:07 -0700 Message-ID: <20260603020707.2641580-1-andrew.pinski@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDAxNyBTYWx0ZWRfX/AL37XCz/PBW IktXz3Uyh05GzTgJYZU3xb88IfmPxwECfdQ57QzBuzuuCr6r52rlUvrFpjS8jTgGaUHOGe40z7p 0npgiT4R2ILSw2ZUs2RIVQwpw6yFcR5tEm7/TA0BYGnd9vZee9Qb1gsksKmxPJrpzPczQC6aa65 z3DlQcqqE2WWFRCTQ/jRcp2hropYSbIitcDHlee7X17a9dObXYW9I33omhFRMKNqTsKD4dNXE8i fgP2dEGzIcgcHoG7I0/hFOIH/qnSjXxjmWwvQ4XKegblV6d6+omf2005havNuZ1Sg82Q9HZLDdR CSvECGtayEVtHrksqAjU4GviDsIHZpXk+k4QvFpF17s0X2weFIRTk87L3TF+9jUPEkk9zHGIC8v Xi/DJ1xVn214HvvXjoJSFhHLsXyBoVTY28gISt5Im4ldXVDwpaa66ZRBdMaKoz0IlDCQeexnZcd 0b4TwrgxnS4b08XCZtw== X-Authority-Analysis: v=2.4 cv=UqZT8ewB c=1 sm=1 tr=0 ts=6a1f8c51 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=jpuWWtznm249gNHsVapybA==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=TuBu9op1T52I0_PjW88A:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 93MVRpDW_ayL9IE6jPT5csu4BMu9cm91 X-Proofpoint-GUID: 93MVRpDW_ayL9IE6jPT5csu4BMu9cm91 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030017 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_PBL, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org This removes ENUM_BITFIELD from tree-core.h. GCC has been written in C++ for years now. So enums can be bitfields. There is no reason for the macro. This removes the macro usage from tree-core.h. The other uses can be removed by others. Note gengtype needed to support for tree_code to remove the extra enum that is added for other others. Bootstrapped and tested on x86_64-linux-gnu. PR middle-end/125507 gcc/ChangeLog: * gengtype.cc (main): Add tree_code. * tree-core.h (struct tree_base): Remove ENUM_BITFIELD. (struct tree_type_common): Likewise. (struct tree_decl_common): Likewise. (struct tree_decl_with_vis): Likewise. (struct tree_function_decl): Likewise. Signed-off-by: Andrew Pinski --- gcc/gengtype.cc | 1 + gcc/tree-core.h | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gcc/gengtype.cc b/gcc/gengtype.cc index 06116239344..a348106d532 100644 --- a/gcc/gengtype.cc +++ b/gcc/gengtype.cc @@ -5257,6 +5257,7 @@ main (int argc, char **argv) POS_HERE (do_scalar_typedef ("JCF_u2", &pos)); POS_HERE (do_scalar_typedef ("void", &pos)); POS_HERE (do_scalar_typedef ("machine_mode", &pos)); + POS_HERE (do_scalar_typedef ("tree_code", &pos)); POS_HERE (do_scalar_typedef ("fixed_size_mode", &pos)); POS_HERE (do_scalar_typedef ("CONSTEXPR", &pos)); POS_HERE (do_typedef ("void *", diff --git a/gcc/tree-core.h b/gcc/tree-core.h index a70e60e3290..09c07c5c129 100644 --- a/gcc/tree-core.h +++ b/gcc/tree-core.h @@ -1136,7 +1136,7 @@ typedef tree (*walk_tree_lh) (tree *, int *, tree (*) (tree *, int *, void *), accessor macros. */ struct GTY(()) tree_base { - ENUM_BITFIELD(tree_code) code : 16; + tree_code code : 16; unsigned side_effects_flag : 1; unsigned constant_flag : 1; @@ -1805,7 +1805,7 @@ struct GTY(()) tree_type_common { tree attributes; unsigned int uid; - ENUM_BITFIELD(machine_mode) mode : MACHINE_MODE_BITSIZE; + machine_mode mode : MACHINE_MODE_BITSIZE; unsigned int precision : 16; unsigned lang_flag_0 : 1; @@ -1898,7 +1898,7 @@ struct GTY(()) tree_decl_common { struct tree_decl_minimal common; tree size; - ENUM_BITFIELD(machine_mode) mode : MACHINE_MODE_BITSIZE; + machine_mode mode : MACHINE_MODE_BITSIZE; unsigned nonlocal_flag : 1; unsigned virtual_flag : 1; @@ -2023,7 +2023,7 @@ struct GTY(()) tree_decl_with_vis { unsigned seen_in_bind_expr : 1; unsigned comdat_flag : 1; /* Used for FUNCTION_DECL, VAR_DECL and in C++ for TYPE_DECL. */ - ENUM_BITFIELD(symbol_visibility) visibility : 2; + enum symbol_visibility visibility : 2; unsigned visibility_specified : 1; /* Belong to FUNCTION_DECL exclusively. */ @@ -2091,7 +2091,7 @@ struct GTY(()) tree_function_decl { /* In a FUNCTION_DECL this is DECL_UNCHECKED_FUNCTION_CODE. */ unsigned int function_code; - ENUM_BITFIELD(built_in_class) built_in_class : 2; + enum built_in_class built_in_class : 2; unsigned static_ctor_flag : 1; unsigned static_dtor_flag : 1; unsigned uninlinable : 1; @@ -2109,7 +2109,7 @@ struct GTY(()) tree_function_decl { unsigned looping_const_or_pure_flag : 1; /* Align the bitfield to boundary of a byte. */ - ENUM_BITFIELD(function_decl_type) decl_type: 2; + enum function_decl_type decl_type: 2; unsigned has_debug_args_flag : 1; unsigned versioned_function : 1; unsigned replaceable_operator : 1;