From patchwork Wed May 6 14:10:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 134563 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B09724BA7990 for ; Wed, 6 May 2026 14:12:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B09724BA7990 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Po/2hHOu X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id CAC264BA7998 for ; Wed, 6 May 2026 14:11:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAC264BA7998 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CAC264BA7998 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778076660; cv=none; b=VuN4/mTlEtgSbljwoNvYBlRT+fe25GjQvPuNncNj10X5RRGAoDf6wkWW1VuTLJggxgcaEEMizm1OtlFChSDw8DoJLUGugyd4W4Kiiwzb5YBIotkMlUz/Buh5r/WzI+T6+d3jy7NSqqc/dOJ2uVhbSi8vyYoS+zhTBUea0bOLITE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778076660; c=relaxed/simple; bh=08/WDD9hcc9VTx4c0V7H6oG0MunFSB8yGZ3Bk5Iw18c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Fsf+pcNjgS8lJNuymkTiibLTL2WUHhtB4JVJy/3BDJDu7nlBgdcWsVewqm8IwovHfy6NEDeLH7ol/d/i8TOL6F+wTyHTZm9OT1JtVr5Vo9HxMRG0f1SrHcBOaulOscu+zE5kRnhZgrRDSAZ4GM438KYX3MEF1BkY5SnPS8Z/6OU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Po/2hHOu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CAC264BA7998 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778076660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8tNnpcDA3mD0Ysl1zWAQndyoRnUFFDzfBqsnqd/ZKDE=; b=Po/2hHOuWTtFltZoNHFYfb79CAfab08D3J3vW6z0jsxE1D26yv6OzF3DH5hIVXsIWEA5Ng SKGylx5ShZ9vJjmIMn2VShGDAET9tx2OJvm2vdVuK1xDA6v6SIx/YJG1MYiOzNM76J7F4/ C7CPCZa5nack+7YiYSgt7oyFiA4Um5k= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-aOvLKGpdMpuSdVohCPMJ3g-1; Wed, 06 May 2026 10:10:59 -0400 X-MC-Unique: aOvLKGpdMpuSdVohCPMJ3g-1 X-Mimecast-MFC-AGG-ID: aOvLKGpdMpuSdVohCPMJ3g_1778076658 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 381B8195606D for ; Wed, 6 May 2026 14:10:58 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.81.194]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 925D519560A6; Wed, 6 May 2026 14:10:57 +0000 (UTC) From: David Malcolm To: Andrew MacLeod , gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH] analyzer: show value ranges in svalue::dump Date: Wed, 6 May 2026 10:10:56 -0400 Message-ID: <20260506141056.2747121-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tA5jZSch_C6r7W-W6hxaBtAQavrHTqICeYcD9yWOU5k_1778076658 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org This patch adds value_range info where available to the various nodes in svalue dumps, such as: (gdb) call rhs2_sval->dump () (27): ‘long long unsigned int’: binop_svalue(bit_and_expr: ‘&’) value range: {[irange] long long unsigned int [0, 0]} ├─ (24): ‘long long unsigned int’: unaryop_svalue(nop_expr) value range: {[irange] long long unsigned int [0, 4294967295] MASK 0xffffffff VALUE 0x0} │ ╰─ (22): ‘unsigned int’: initial_svalue value range: {[irange] unsigned int VARYING} │ ╰─ m_reg: (21): ‘unsigned int’: decl_region(‘m’) │ ╰─ parent: (4): globals │ ╰─ parent: (0): root region ╰─ (26): ‘long long unsigned int’: constant_svalue (‘5497558138880’) value range: {[irange] long long unsigned int [5497558138880, 5497558138880]} where we can see that sval 27 has value range [0,0] and where that comes from (due to being a bit_and_expr of non-overlapping ranges from sval 24 and 26). Successfully bootstrapped & regrtested on aarch64-unknown-linux-gnu. Andrew: are the value-range parts OK for trunk? gcc/analyzer/ChangeLog: * svalue.cc (svalue::make_dump_widget): Show value ranges in svalue dumps. gcc/ChangeLog: * value-range.cc (value_range::print): New, based on value_range::dump. * value-range.h (value_range::print): New decl. Signed-off-by: David Malcolm --- gcc/analyzer/svalue.cc | 8 ++++++++ gcc/value-range.cc | 12 ++++++++++++ gcc/value-range.h | 1 + 3 files changed, 21 insertions(+) diff --git a/gcc/analyzer/svalue.cc b/gcc/analyzer/svalue.cc index fe22ae73ddd..1c0041ab75b 100644 --- a/gcc/analyzer/svalue.cc +++ b/gcc/analyzer/svalue.cc @@ -227,6 +227,14 @@ svalue::make_dump_widget (const text_art::dump_widget_info &dwi, print_dump_widget_label (&pp); + value_range out; + if (maybe_get_value_range (out)) + { + pp_printf (&pp, " value range: {"), + out.print (&pp); + pp_string (&pp, "}"); + } + std::unique_ptr w (text_art::tree_widget::make (dwi, &pp)); diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 657afa0acaa..a1e5c805057 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -157,6 +157,18 @@ value_range::dump (FILE *out) const fprintf (out, "NULL"); } +void +value_range::print (pretty_printer *pp) const +{ + if (m_vrange) + { + vrange_printer vrange_pp (pp); + m_vrange->accept (vrange_pp); + } + else + pp_string (pp, "NULL"); +} + DEBUG_FUNCTION void debug (const value_range &r) { diff --git a/gcc/value-range.h b/gcc/value-range.h index eaf29236d99..85deebab092 100644 --- a/gcc/value-range.h +++ b/gcc/value-range.h @@ -792,6 +792,7 @@ public: operator vrange &(); operator const vrange &() const; void dump (FILE *) const; + void print (pretty_printer *) const; static bool supports_type_p (const_tree type); tree type () { return m_vrange->type (); }