From patchwork Wed Apr 8 16:54:26 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 132822 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9765B4BA2E0D for ; Wed, 8 Apr 2026 16:55:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9765B4BA2E0D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=vrull.eu header.i=@vrull.eu header.a=rsa-sha256 header.s=google header.b=mR/lxGfR X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id A81864BA2E09 for ; Wed, 8 Apr 2026 16:54:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A81864BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A81864BA2E09 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775667271; cv=none; b=PcgxXsI6qsYmta7w1SKEvV706ZoCcNcW3AEQth/z2MSBd03rdWO0JnMXlcrjaKp8iA3OgntxhXdpVboa815wQikM1TK7BytGksUe/AjKrWW+k1Bzhr+JaODDMYJTg2q5Q40dH5xhjoofx2kD0a5V7tc6tsL86X2LX91zQ8cw3mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775667271; c=relaxed/simple; bh=LmC+tYEWcgISKmCEwq0Up2+2sqCqWTwyd+wB53gLTK4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vDNEIZfKRuLGlksq//5Syi+75whDel8hRUTlhAQu9Qu9/CJiQyyYBrKmJMyL9mN6unuyecObDlOpRTtycQyzwxjHhZ/dgQCnEKg4GGvwcXzKuwoDgTXCh4Qlx9XiIAVf1PqU1ix7CeNTh8p0mgEP7vuGXnpsheq2PUjJQMCe2CM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A81864BA2E09 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488ba840146so314585e9.1 for ; Wed, 08 Apr 2026 09:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1775667269; x=1776272069; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HcAB/PeKijCOATbVAtQ60cTv7o2M+e8fYQp3SveSh9o=; b=mR/lxGfRmQ3v/DgQdT/VM0HK2WvldWHOuTxifFp1lbL4F2mYB9SVUjgxT4zgEewTtr JWNDPoov+9UAnOd2LTtg0/0rL+DKR9GphuuqBZvkkXTCkVo7Sz6AvGRBSfQLK1DLXPMl G3fDy3PNI/LW4nN++hsL/ByRBo+VzcWGigptgjuKLFZUmRKKsgm1hPdJNp96lUlH5MMY qhsaSDl9fibHk1aBh3elzQmTRF27nTcDAMPHUuSgIDcGCqifGWNwCiU76nJIgXqHAeaV jmObto9MhslGUtkWz+dkAhFz871ZunP/Ns9+AckPF8OLBXiS+DB0eko980ms3DpuP/q7 F6KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775667269; x=1776272069; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HcAB/PeKijCOATbVAtQ60cTv7o2M+e8fYQp3SveSh9o=; b=Okl2if0x5aTv5FKTw18qIaj6qJYbCo0ystRjQ1rhdEL3yl1oyDO8ykOIJqlUsCIMf1 J7IOQVeBrifJvgIcS+zHsrM8kifKmGrOLbsOs1rI+uG6wSs+333elRQdUhuh7XZQ9z0G z+ptyHN9Wtrm8/+u+V3o/wi+s0IZbMMh7gNRkcSfrgONrInq/SS9Efn4HAShRT7ksXMl 5A9ciVlJUTalMJGVvU/psxUXQKrAjP0jULfPOLKlXnDdysUUPCytr/+xsgpsBhlIMaFP rpyVMyBDULV3IP7fL706hyh8kgcuCFMkKjqQHv5A4xwops6tmInxhhHdr6j0eCx+3lRg Pwww== X-Gm-Message-State: AOJu0Yxx0af8DwNeuvwBic82c8Q1Jxe8jUWP2/LVagQ4VCOzriVtMCQ9 BXLAqNVn1yJRn16NYYIAPUI/yjnDbdTjeC+uJLx05V63l031CKgWmJHRnFdZQsjfvcPy8H2ubeM WN8dK X-Gm-Gg: AeBDietJRNfSZxeDrFCi82I/6HfLolH+K3s2VZKPlBk8j+sl6LobgbYhJFDTUIJjJga t22HsMO4Zt6vjo6v9jR2Tz6/ydZvzYjTCST8gjT4QfZkprDsGOhep3f+yG2iwamwtL+rcwk4XKR rq/Wi1cvlmSxyGNlTrYlgT1iAFgqiUocRVWIJsdiejGo1xvSlv2eA/1ttonJqM2QjLWEdBR+m61 +mQ8P/pmWg+7ydqfSOvcFAVYE4bV90od2ZFJfIaOG93Uga+doeBWORRfm9zy2HuepdtjTV66VAH Ik61Nd9TNOgaIDoa+0uh/1+IhekPAGfF8v8N/gQMQn99gsh8xnS6FcIAHeDETpDu0w1BkxxF+UJ v6xjES+tOaZbXmEIt2cCp9xK1CIz41A8YkVi5eciSLRKKJveOJ1e4KdOkv5W049AtAd5KeFOnLQ 34M2aLX54o1/1hntAD9RLKtit3FNLRlME2zONNm2XU0ejc5LU82F6hMJYshAc4+ff/TjQkBKB5x QjWOMALO80t X-Received: by 2002:a05:600c:c0dc:b0:486:f4d2:eac6 with SMTP id 5b1f17b1804b1-488ccf71199mr6541025e9.13.1775667269224; Wed, 08 Apr 2026 09:54:29 -0700 (PDT) Received: from antares.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd1d647fsm5397665e9.14.2026.04.08.09.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 09:54:28 -0700 (PDT) From: =?utf-8?q?Christoph_M=C3=BCllner?= To: gcc-patches@gcc.gnu.org, Kito Cheng , Palmer Dabbelt , Robin Dapp , Andrew Waterman , Jim Wilson , Jeff Law , Shreya Munnangi Cc: =?utf-8?q?Christoph_M=C3=BCllner?= Subject: [PATCH] RISC-V: Fix Zbkb single-bit IOR/XOR synthesis [PR124818] Date: Wed, 8 Apr 2026 18:54:26 +0200 Message-ID: <20260408165426.4154722-1-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Only Zbs provides the bseti/binvi support that can directly handle a large single-bit immediate in scalar IOR/XOR operations. Zbkb alone does not, but synthesize_ior_xor treated Zbkb as sufficient and returned false for such constants. On RV32 with -march=rv32gc_zbkb this leaves an unmatchable (ior:SI reg (const_int 0x20000)) RTL insn, which later triggers an ICE in extract_insn during virtual register instantiation. Restrict the single-bit fast path to Zbs and add an RV32 Zbkb regression test for the reduced reproducer. PR target/124818 gcc/ChangeLog: * config/riscv/riscv.cc (synthesize_ior_xor): Do not treat TARGET_ZBKB as sufficient for single-bit immediate IOR/XOR. gcc/testsuite/ChangeLog: * gcc.target/riscv/pr124818.c: New test. Signed-off-by: Christoph Müllner --- gcc/config/riscv/riscv.cc | 2 +- gcc/testsuite/gcc.target/riscv/pr124818.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/riscv/pr124818.c diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index a6106547757..b743d3533f2 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -15919,7 +15919,7 @@ synthesize_ior_xor (rtx_code code, rtx operands[3]) { /* Trivial cases that don't need synthesis. */ if (SMALL_OPERAND (INTVAL (operands[2])) - || ((TARGET_ZBS || TARGET_ZBKB) + || (TARGET_ZBS && single_bit_mask_operand (operands[2], word_mode))) return false; diff --git a/gcc/testsuite/gcc.target/riscv/pr124818.c b/gcc/testsuite/gcc.target/riscv/pr124818.c new file mode 100644 index 00000000000..a629e8e96a2 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/pr124818.c @@ -0,0 +1,9 @@ +/* { dg-do compile { target { riscv32*-*-* } } } */ +/* { dg-options "-O2 -march=rv32gc_zbkb -mabi=ilp32" } */ + +int +f (unsigned int *flags) +{ + *flags |= 0x20000U; + return 1; +}