From patchwork Tue Apr 7 13:48:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 132766 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E93ED4BA2E26 for ; Tue, 7 Apr 2026 13:50:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E93ED4BA2E26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WAEt+9zQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1FzgPNs/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JLTICPNH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rVfZdcGJ X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id D6F4A4BA2E1D for ; Tue, 7 Apr 2026 13:48:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6F4A4BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6F4A4BA2E1D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775569706; cv=none; b=rF1j+aMppXTRsR3EI+DhIi2dXp1nDkUQg5sH3pkyavzjovdDA5/Vgd3t/8qYWYJeW+5ZsyEZsToD1A1o1hdvf+FJNaTTtW0IaEfL/r3jHNOnpnBj210HGbTa0aP6k9//ojrNDDtuf5XdEfL4W/vubhjb29+bnjZWEMXwAuc/LeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775569706; c=relaxed/simple; bh=+fJ45xuDbYudraL8nJ1MJn4z6nz1y7k6xf95+n8hVlU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=MapYR0ajelDgHyLCsKzshefO46WthVOW6pwjMlXDCVfn72ohKxlosG81ymwhpyop1xRVWCOSqsQv6cHaPU01YOsqAEL5UPTbHxA8sXpMPh84RYp0v6ijJg0K9HKc8nwTLINnlWsw/EeZ5QjJzxiZ1eBRIv41TMcz+9IfsBDccY0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6F4A4BA2E1D Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D81025BD6C for ; Tue, 7 Apr 2026 13:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569705; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=WAEt+9zQDn9/1c0oU0w2BTue575kYOqxFhJ8TNMnH+VbEIgQ4P4co8TUsz1OBtLumYdQhO Z1HwBC45y8PBiwRWNQ1PRRdXYCyWLIhOdx9jPiVneZwDmO0TuKN7DeYXCU7uh+iVoKe9hF /G+UB515Ax4M46ubqYgwPfUEEFTkZvA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569705; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=1FzgPNs/L7eH6SL7f+5AssyVBhIo2sfrayYcW56aqJphN0ZGqGumpZRDhawMOLHhn4I1TB ZRX/jPcZ7cPPAyAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569704; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=JLTICPNH83l6QjPbWfRQftfhwhcAJK3OiHa+zFRbL0fpuV/sRNWiZA9LEXejVrhzOcqrf7 0ZzUa3clJfTjPyqkrCymv1pim+PK0hnZBXwrT0s3Vpvpz5UNN+0XVjbSl6pR9V+mdElH9k 93zEkGW7vE0rhJmTPODS5OYhe4ZWkJE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569704; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=cpgBz58cMaVAB/bE0dRtcVB022pXkGqeJLrQEnBuKRQ=; b=rVfZdcGJ/r0X7DXuSkXVaXu8hB0i7KlfbeO/SkvzbqoQah8B1Gd7IbwdaZrRheMtBqK/ty zSn3Mu6BiPWK8VBg== Date: Tue, 7 Apr 2026 15:48:24 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/2] tree-optimization/124802 - avoid SLP_TREE_REPRESENTATIVE for permutes MIME-Version: 1.0 X-Spam-Score: -1.80 X-Spam-Level: X-Spamd-Result: default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[murzim.nue2.suse.org:helo] X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Message-Id: <20260407135001.E93ED4BA2E26@sourceware.org> The following avoids having a SLP_TREE_REPRESENTATIVE for permute nodes from two operator SLP matching. Bootstrap and regtest running on x86_64-unknown-linux-gnu. And this I plan to push for stage1. PR tree-optimization/124802 * tree-vect-slp.cc (vect_build_slp_tree_2): Reset SLP_TREE_REPRESENTATIVE for permute nodes built from a known set of scalar stmts. --- gcc/tree-vect-slp.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 9d2d0f98ea8..aa442d53999 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -3137,6 +3137,7 @@ fail: SLP_TREE_VECTYPE (pnode) = vectype; SLP_TREE_CHILDREN (pnode).quick_push (child); SLP_TREE_CHILDREN (pnode).quick_push (child); + SLP_TREE_REPRESENTATIVE (pnode) = NULL; lane_permutation_t& perm = SLP_TREE_LANE_PERMUTATION (pnode); children.safe_push (pnode); @@ -3166,6 +3167,7 @@ fail: SLP_TREE_CODE (node) = VEC_PERM_EXPR; SLP_TREE_CHILDREN (node).quick_push (one); SLP_TREE_CHILDREN (node).quick_push (two); + SLP_TREE_REPRESENTATIVE (node) = NULL; enum tree_code code0 = ERROR_MARK; enum tree_code ocode = ERROR_MARK; if (gassign *stmt = dyn_cast (stmts[0]->stmt))