diff mbox series

[3/5] c++, openmp: Fix copy-paste bug wrote to incrv instead of orig_declv

Message ID 20260407110826.8427-3-yangkun@disroot.org
State Committed
Commit e52b9f566bf0af9c7b0d284ad73f49ac82f6a515
Headers
Series [1/5] c++: gcc_assert(false) replaced with gcc_unreachable() |

Commit Message

yangkun April 7, 2026, 11:08 a.m. UTC 
  gcc/cp/ChangeLog:
	* parser.cc (cp_parser_omp_loop_nest): Write orig_declv, not incrv.
---
 gcc/cp/parser.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Jelinek April 7, 2026, 3:50 p.m. UTC | #1 
On Tue, Apr 07, 2026 at 07:08:24PM +0800, Yang Kun wrote:
> gcc/cp/ChangeLog:
> 	* parser.cc (cp_parser_omp_loop_nest): Write orig_declv, not incrv.
> ---
>  gcc/cp/parser.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
> index 832d03f9f..8e651ea8c 100644
> --- a/gcc/cp/parser.cc
> +++ b/gcc/cp/parser.cc
> @@ -49515,7 +49515,7 @@ cp_parser_omp_loop_nest (cp_parser *parser, bool *if_p)
>  	  TREE_VEC_ELT (omp_for_parse_state->condv, depth) = NULL_TREE;
>  	  TREE_VEC_ELT (omp_for_parse_state->incrv, depth) = NULL_TREE;
>  	  if (omp_for_parse_state->orig_declv)
> -	    TREE_VEC_ELT (omp_for_parse_state->incrv, depth) = NULL_TREE;
> +	    TREE_VEC_ELT (omp_for_parse_state->orig_declv, depth) = NULL_TREE;
>  	  vec_safe_push (omp_for_parse_state->init_blockv, NULL_TREE);
>  	  vec_safe_push (omp_for_parse_state->body_blockv, NULL_TREE);
>  	  vec_safe_push (omp_for_parse_state->init_placeholderv, NULL_TREE);

LGTM, but same legal question applies.

	Jakub
diff mbox series

Patch

diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
index 832d03f9f..8e651ea8c 100644
--- a/gcc/cp/parser.cc
+++ b/gcc/cp/parser.cc
@@ -49515,7 +49515,7 @@  cp_parser_omp_loop_nest (cp_parser *parser, bool *if_p)
 	  TREE_VEC_ELT (omp_for_parse_state->condv, depth) = NULL_TREE;
 	  TREE_VEC_ELT (omp_for_parse_state->incrv, depth) = NULL_TREE;
 	  if (omp_for_parse_state->orig_declv)
-	    TREE_VEC_ELT (omp_for_parse_state->incrv, depth) = NULL_TREE;
+	    TREE_VEC_ELT (omp_for_parse_state->orig_declv, depth) = NULL_TREE;
 	  vec_safe_push (omp_for_parse_state->init_blockv, NULL_TREE);
 	  vec_safe_push (omp_for_parse_state->body_blockv, NULL_TREE);
 	  vec_safe_push (omp_for_parse_state->init_placeholderv, NULL_TREE);