From patchwork Sun Apr 5 00:41:04 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Damianov X-Patchwork-Id: 132698 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 552554BA2E06 for ; Sun, 5 Apr 2026 00:47:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 552554BA2E06 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=disroot.org header.i=@disroot.org header.a=rsa-sha256 header.s=mail header.b=IItuiXyy X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) by sourceware.org (Postfix) with ESMTPS id 870964BA5436 for ; Sun, 5 Apr 2026 00:46:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 870964BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=disroot.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 870964BA5436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775350002; cv=none; b=kwyUt1vA9Nb8l30vJuYGrDhqWhFuGDcuoe8SpC13yiha8sMUqey/LzlOiObsGMZp9bYCHAg2du1obCIsAYiRHXQLCzoE8FTEYAI8mx7bt9a819/7Q1HayPP61nHPkvvdfAhhejnMgUd50B+H2sF40aBTo5Gs0J7sjUbb6Fj8vFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775350002; c=relaxed/simple; bh=n32bJOQGplYdl4WTYsIgl8S6SNQGKmZB0jn6i94ll50=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VCmWsttj28t5TLr6dVDhZOGJVQgvieTwsBAn5qbFazKdJypPGtv2uereKaRIcLDyGbusVZV/FtFKXfC3+/UKzncMNHnLoV/8yTw4un5A8Jp3HGIGHQJYTTOQJ1T6f7FfyCAYNzton9UnmCiYUvUwwNU3CRMsboTDvAFlmrng/BM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 870964BA5436 Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9A37A264CA; Sun, 5 Apr 2026 02:46:39 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id muUlz4f2Cmo0; Sun, 5 Apr 2026 02:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1775349998; bh=n32bJOQGplYdl4WTYsIgl8S6SNQGKmZB0jn6i94ll50=; h=From:To:Cc:Subject:Date; b=IItuiXyyqrg1PEIGOgaSegDlgT/g7q7jbxuRBAjjVpNWKGBD50PzsN85bENzEL4u1 QbqfglYX9yUaRI690y1Z8Hzf/MUqdsaJkaoXtVlIRbwm5fqt2rNvu6l2hTZXxY2WdX z6S4qJrNWrQw3eb3NNetJxvbVaAz6RmdWJXebWJzKwmqH0fUxv8F1QJiKQitbHo00h 3MdDQZqZJMKTFDvq834NEUvLS2C0gUZ7eDWkKZz0mz07C0v/Yf0kpsVhxg5bipw6JP F61e35nR0PqF5abcLb5n8Qd+2Ft+j9nwkflnqoenT/fmIa4m0TFS6Smz/JmXKDCBaO 6oKg/qpmdiwbg== From: Peter Damianov To: gcc-patches@gcc.gnu.org Cc: Sam James , Arsen Arsenovic , Jonathan Yong <10walls@gmail.com>, Andrew Pinski , Peter Damianov Subject: [PATCH] mingw: Remove obsolete STMP_FIXINC override from t-cygming Date: Sun, 5 Apr 2026 01:41:04 +0100 Message-ID: <20260405004102.3847-3-peter0x44@disroot.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org The STMP_FIXINC assignment in t-cygming dates back to r0-48723-g70e5e841b8b931, which introduced the shared cygwin/mingw makefile fragment and used it to force fixincludes on for those targets. That predates r0-63200-g53c7ffe7dd1c28, which made configure default STMP_FIXINC to stmp-fixinc, so the t-cygming assignment is now redundant in normal builds. Once --disable-fixincludes was added by r13-2319-gbe9dd80f933480, the old override became incorrect as well, because it forced stmp-fixinc back on for targets using t-cygming. Configuring for mingw targets with --disable-fixincludes would then fail with: make[1]: No rule to make target '../build-x86_64-pc-linux-gnu/fixincludes/fixinc.sh', needed by 'stmp-fixinc'. Stop. Remove the obsolete assignment so the configure-time default is used, including when honoring an explicit --disable-fixincludes. gcc/ChangeLog: * config/mingw/t-cygming: Remove obsolete STMP_FIXINC override. --- Resubmitting because I forgot to CC anyone on my first submission. I tested that this fixes the error I was seeing with --disable-fixincludes on x86_64-w64-mingw32. There's still more small files left over related to fixincludes, but I don't think they are worth addressing in this patch (or the next release). That is probably not specific to mingw at all. gcc/config/mingw/t-cygming | 2 -- 1 file changed, 2 deletions(-) diff --git a/gcc/config/mingw/t-cygming b/gcc/config/mingw/t-cygming index be3323d143a..4d0f99797c3 100644 --- a/gcc/config/mingw/t-cygming +++ b/gcc/config/mingw/t-cygming @@ -61,5 +61,3 @@ msformat-c.o: $(srcdir)/config/mingw/msformat-c.cc $(CONFIG_H) $(SYSTEM_H) \ $(TM_P_H) $(HASHTAB_H) $(GGC_H) $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \ $(srcdir)/config/mingw/msformat-c.cc - -STMP_FIXINC=stmp-fixinc