From patchwork Sun Dec 7 10:34:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 126091 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8480C43492E0 for ; Sun, 7 Dec 2025 10:34:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8480C43492E0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TayQetM5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lsJ5pkdI; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TayQetM5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lsJ5pkdI X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 79A6E43492C8 for ; Sun, 7 Dec 2025 10:34:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79A6E43492C8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79A6E43492C8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765103657; cv=none; b=rOjhEpzii7VQvdwZtqV6cb1YF1AsdNmZ9MNfrUYxbvh8XMrM82PpGyY4MyE6GCM5AdtKT59P3CvfpwbIYiNgAs2RfwjO4sC7Ma9fpkJXzINy2cLIQoCDRFLd9chPY1cVZK7eS3Dapq5+sqhHJ+wiMj9XSqT8yKJvfsuQDkJw2co= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765103657; c=relaxed/simple; bh=UCB/Ky3umlLlT8t7nwQlG/HLZ88lcZuCn1y95Kkw9kQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=V0qe9aR5d38J/4QeaG2ZifiCf/erfzy8wsphMJVIxj7gNxKHlTb7H3cRoqAYVubgXA1c7kIYAcUPUBnEF5A2OahNTWsNDpg2HArYh42iKXD2YGWkPUeU0CQz5FiLWIRndQbIy1xU8qWghD/5MOj30BywkbC0q/NZbGZMsnuqAQI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 79A6E43492C8 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 73BED5BCF1 for ; Sun, 7 Dec 2025 10:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1765103656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=GtVGAIX9pBeZu7hEaxkzp+AAgzkwA9od0GQdnXbwJMY=; b=TayQetM58wUeXqd3zEdoKYUSN/QByKlbfxQr6ckRIuyd90Y7mo/UyVY5/qf6Mmr1NS1NdK PrXViedr+S0qotV167F+/y5qLVN9MSQCDYjaYBoSfgiNQyK3K6AmCZTN/calHfup8S8GkQ PI9atyXNQ5HEELKeJLAWA4orWb1c0uQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1765103656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=GtVGAIX9pBeZu7hEaxkzp+AAgzkwA9od0GQdnXbwJMY=; b=lsJ5pkdI7P1+dmULz9zyGrBFIVIBPZSbIZSGqSBWJamYwqB2gxLUXQp6ztzHhLNbMu3dHB tFVwgwYQZqF4+oCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1765103656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=GtVGAIX9pBeZu7hEaxkzp+AAgzkwA9od0GQdnXbwJMY=; b=TayQetM58wUeXqd3zEdoKYUSN/QByKlbfxQr6ckRIuyd90Y7mo/UyVY5/qf6Mmr1NS1NdK PrXViedr+S0qotV167F+/y5qLVN9MSQCDYjaYBoSfgiNQyK3K6AmCZTN/calHfup8S8GkQ PI9atyXNQ5HEELKeJLAWA4orWb1c0uQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1765103656; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=GtVGAIX9pBeZu7hEaxkzp+AAgzkwA9od0GQdnXbwJMY=; b=lsJ5pkdI7P1+dmULz9zyGrBFIVIBPZSbIZSGqSBWJamYwqB2gxLUXQp6ztzHhLNbMu3dHB tFVwgwYQZqF4+oCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 54C173EA63 for ; Sun, 7 Dec 2025 10:34:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +ECbEihYNWkfSgAAD6G6ig (envelope-from ) for ; Sun, 07 Dec 2025 10:34:16 +0000 Date: Sun, 7 Dec 2025 11:34:15 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/123038 - FFS/CTZ pattern incompatible with reductions MIME-Version: 1.0 Message-Id: <20251207103416.54C173EA63@imap1.dmz-prg2.suse.org> X-Spamd-Result: default: False [-4.28 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.18)[-0.908]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:mid] X-Spam-Level: X-Spam-Score: -4.28 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org The pattern ends up using the argument more than one time which isn't supported. When FFS directly maps to CTZ + 1 it works though. Bootstrap and regtest running on x86_64-unknown-linux-gnu. PR tree-optimization/123038 * tree-vect-patterns.cc (vect_recog_ctz_ffs_pattern): Reject pattern for reductions when the call argument is used multiple times. * gcc.dg/vect/pr123038.c: New testcase. --- gcc/testsuite/gcc.dg/vect/pr123038.c | 8 ++++++++ gcc/tree-vect-patterns.cc | 14 ++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/vect/pr123038.c diff --git a/gcc/testsuite/gcc.dg/vect/pr123038.c b/gcc/testsuite/gcc.dg/vect/pr123038.c new file mode 100644 index 00000000000..bca831f9c08 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr123038.c @@ -0,0 +1,8 @@ +/* { dg-do compile } */ + +unsigned char f(int b) +{ + for (int a = 0; a < 10; a += 1) + b = __builtin_ffs(b); + return b; +} diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 555986b4fec..af64cb84e41 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -1914,6 +1914,9 @@ vect_recog_ctz_ffs_pattern (vec_info *vinfo, stmt_vec_info stmt_vinfo, && val_new == prec) || (ifnnew == IFN_POPCOUNT && ifn == IFN_CTZ)) { + if (vect_is_reduction (stmt_vinfo)) + return NULL; + /* .CTZ (X) = PREC - .CLZ ((X - 1) & ~X) .CTZ (X) = .POPCOUNT ((X - 1) & ~X). */ if (ifnnew == IFN_CLZ) @@ -1952,6 +1955,9 @@ vect_recog_ctz_ffs_pattern (vec_info *vinfo, stmt_vec_info stmt_vinfo, } else if (ifnnew == IFN_CLZ) { + if (vect_is_reduction (stmt_vinfo)) + return NULL; + /* .CTZ (X) = (PREC - 1) - .CLZ (X & -X) .FFS (X) = PREC - .CLZ (X & -X). */ sub = prec - (ifn == IFN_CTZ); @@ -1971,6 +1977,9 @@ vect_recog_ctz_ffs_pattern (vec_info *vinfo, stmt_vec_info stmt_vinfo, } else if (ifnnew == IFN_POPCOUNT) { + if (vect_is_reduction (stmt_vinfo)) + return NULL; + /* .CTZ (X) = PREC - .POPCOUNT (X | -X) .FFS (X) = (PREC + 1) - .POPCOUNT (X | -X). */ sub = prec + (ifn == IFN_FFS); @@ -1993,6 +2002,11 @@ vect_recog_ctz_ffs_pattern (vec_info *vinfo, stmt_vec_info stmt_vinfo, /* .FFS (X) = .CTZ (X) + 1. */ add = 1; val_cmp++; + + if (vect_is_reduction (stmt_vinfo) + && defined_at_zero + && (!defined_at_zero_new || val != val_cmp)) + return NULL; } /* Create B = .IFNNEW (A). */