| Message ID | 20251207001030.1024365-20-sloosemore@baylibre.com |
|---|---|
| State | New |
| Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 718CD40963A6 for <patchwork@sourceware.org>; Sun, 7 Dec 2025 00:24:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by sourceware.org (Postfix) with ESMTPS id D90C141436E2 for <gcc-patches@gcc.gnu.org>; Sun, 7 Dec 2025 00:11:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D90C141436E2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D90C141436E2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.210.66 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765066272; cv=none; b=FvBSp1VTlzoVTWXhzhMERK5Pf5KsrUhgGlfwRrg7D3aCkQGtgpu9O7znXDrlrzWT0jfV9Zbeujz9IfPDJelvGSDXpG3Y1ksng42QkMmjhk4ZfvkqmfOs/ufA8hQNS4WAcIC3OkXbXjU0f90JIphczyhi25666P5Ug+YMsVRMCtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765066272; c=relaxed/simple; bh=rJv8/o2EBNp2Yl0kok595l995ixOO5WT7UgTD/hx9CU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=IXKMshXH59BC7ShHcWnZf4/pJASsIi0/t1yBMv9kceNUr8dbcNXklrjNxU5KGT1svJa4Yf3mFWZwFGL9HUm+KMratWFf6ZIGG4QJ1PP1O8N34YHru0AOp8NE5tevlNVuuCrWIMtRzlMkay8fY/aZimoy+OqAgRrRnQsWqlj2t9o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D90C141436E2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=XBM7ods4 Received: by mail-ot1-f66.google.com with SMTP id 46e09a7af769-7c71cca8fc2so2558548a34.1 for <gcc-patches@gcc.gnu.org>; Sat, 06 Dec 2025 16:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765066271; x=1765671071; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xEOPAWfAT5XXoQN3Zw8b7ZuRf6MK3J2DXukRtmryzIA=; b=XBM7ods4zR9MNGvjq3XVZOd1SbQrSlEC7DB1As8gwbmJC987sexdsqiO1Xy9bzKuB5 2SqtoDoB9XZ+BWW9EXqg3G0pJo19tR+gHT5ybUYsjs4yy2w2mEHcnx92RJJ24f6RWq9J tlHYh07FLLDiwgAEzwLP9zB6P32VvSvTSnwQX6sBqH1nlhv5GK4QWg8iiCrB701fSMy1 hoCfjcff6bVozVDNa+wnJOqIyKVY6DZDefVsm9G9JLXGw1opIHTdtow/Vr32A3EQ3K+9 Jydy+l/KAtd3sF5Tz7uGHpmbw2PQ5kezS8PghZxpy7yl27X6Fq4/8moWJNn1bLaeiDzN C9xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765066271; x=1765671071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xEOPAWfAT5XXoQN3Zw8b7ZuRf6MK3J2DXukRtmryzIA=; b=lmn+Wj8SxaWLuFUQldCmE+xI5Xl/jwD8wKhmtIJcS5v2yRSawIc3kiON4JspI7Uyco Wn1FSZjoCdCw91NS6ioQNzYnasdMUWfC/8m7AU4MBVZ0woWwMm3em//1OEWoKauC8ovg RMgPOG5J0beYd2BOX5BuT2RPTxcqd2te/ZXMy2jrgBjIOZo/gzCpSGydZrmIiLDGyOvD iDEflrFPOmQ6TJBrzFnhRy1svFkFwnX/T/dmEKBYj5hHQQsPIAp70CV3oh0NsinqpT2J 76OKO2iNGGz436u0OZkHayY6xjrHjm4/CvZTiTXickUBA++0/Y/7PIvrG6KApiWWI7IP IbfQ== X-Gm-Message-State: AOJu0YwWqXyM7CgoBdQHHpcAvoLSMvTO6i5SiexaQ0vo1pJidHutF/pv fIjFsBYryDD6x6VnljrBOsDp1wa36ayBz6Vd2cpGIlf5UiDNclA2GhFEGtqwcYGT01i8gNg0vzC 3JvQjiCE= X-Gm-Gg: ASbGncu2b18mbYDHQgojQjhvWdev+HlF3vw89aSt9mvJd8CLHnT+4FmDKvB4gBQF3Hq hZ4ZPtuX2H+hGsuBPEnWI7ltHv84H1OQ2845mP/t/y3wQK09ca7rGz0wqkfhJ6b5hycMISWqfCs a+vblrvTceg9dNDbpgCkCXYX5eAh6jI2s0b/zGjjupkvMcCgrqXM00oHxxjv+0BmYRDF3FkKav8 fwYAr/VzEseBj9oBxWtY6DlvonEoxAyGqMhP0/tK142mNT2RB794GJlDU2Q9eXuK5WAXTIqKgCt Resle375HSXy6ID75W6LBF3G13deuSe9EbnGvLIzxKmoe9x1JWnWiU+Wf8QeUtlxqae+oicMr0E O4pjRHtb+PTDOxPOr9cLNPktUa5rjOQqwX7gdvC2FxVBzXZejhHutY8Z4gTY7V02zq3nBulQYln 1HA7PbflzC0V2/ X-Google-Smtp-Source: AGHT+IFkLKx1zj9vZQjIzuq6V8SOWzTV45EjyrlBnNWrYAGlrMxfs9QsakdlVBnEEqn/D7hkuwXEJg== X-Received: by 2002:a05:6830:3487:b0:7bc:f443:fa3c with SMTP id 46e09a7af769-7c970820191mr1494798a34.25.1765066271194; Sat, 06 Dec 2025 16:11:11 -0800 (PST) Received: from localhost.localdomain ([2601:281:d901:97c0::6b05]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c95a8f8d0bsm7598391a34.5.2025.12.06.16.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Dec 2025 16:11:10 -0800 (PST) From: Sandra Loosemore <sloosemore@baylibre.com> To: gcc-patches@gcc.gnu.org Cc: ni1d@arrl.net Subject: [PATCH 19/20] doc, pdp11: Clean up PDP-11 documentation [PR122243] Date: Sat, 6 Dec 2025 17:10:29 -0700 Message-Id: <20251207001030.1024365-20-sloosemore@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251207001030.1024365-1-sloosemore@baylibre.com> References: <20251207001030.1024365-1-sloosemore@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
| Series |
Second set of doc updates for target-specific options
|
|
Commit Message
Sandra Loosemore
Dec. 7, 2025, 12:10 a.m. UTC
While working on this patch I saw that this target has an -mlra option that still defaults to off. Although the LRA support was added in 2018 apparently it wasn't robust enough to enable by default. We are supposed to be deleting reload support and all targets that don't use LRA by default in GCC 16, so this target may be declared obsolete very soon, but I've made the documentation of other options consistent with the .opt files and conventions used for other targets anyway in case either somebody who can build/test for this target switches the default (see PR target/113947) or the reload removal is postponed. gcc/ChangeLog PR other/122243 * doc/invoke.texi (Option Summary) <PDP-11 Options>: Remove redundant -mno- forms from the list. (PDP-11 Options): Fix some markup issues. Merge documentation of positive and negative forms of -mac0. Index negative forms of -m40, -m45, -msplit, -mlra. --- gcc/doc/invoke.texi | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-)
Comments
The pdp-11 changes look mostly ok but I have two questions. 1. Why did you remove -munix-asm, mdec-asm and -mgnu-asm along with -mlro from the gccoptlist at the top? 2. -m40 and -m45 aren't supposed to have negative forms. I guess I'm missing RejectNegative in the option definition. paul > On Dec 6, 2025, at 7:10 PM, Sandra Loosemore <sloosemore@baylibre.com> wrote: > > While working on this patch I saw that this target has an -mlra option > that still defaults to off. Although the LRA support was added in > 2018 apparently it wasn't robust enough to enable by default. We are > supposed to be deleting reload support and all targets that don't use > LRA by default in GCC 16, so this target may be declared obsolete very > soon, but I've made the documentation of other options consistent with > the .opt files and conventions used for other targets anyway in case > either somebody who can build/test for this target switches the > default (see PR target/113947) or the reload removal is postponed. > > gcc/ChangeLog > PR other/122243 > * doc/invoke.texi (Option Summary) <PDP-11 Options>: Remove > redundant -mno- forms from the list. > (PDP-11 Options): Fix some markup issues. Merge documentation > of positive and negative forms of -mac0. Index negative forms > of -m40, -m45, -msplit, -mlra. > --- > gcc/doc/invoke.texi | 28 +++++++++++++++++----------- > 1 file changed, 17 insertions(+), 11 deletions(-) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index f403d20bc0b..413259f2fe3 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -1292,8 +1292,8 @@ Objective-C and Objective-C++ Dialects}. > -mcmodel=@var{code-model}} > > @emph{PDP-11 Options} (@ref{PDP-11 Options}) > -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 > --mint32 -mno-int16 -mint16 -mno-int32 > +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 > +-mint32 -mint16 > -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} > > @emph{PowerPC Options} > @@ -31675,31 +31675,35 @@ These options are defined for the PDP-11: > @opindex mfpu > @item -mfpu > Use hardware FPP floating point. This is the default. (FIS floating > -point on the PDP-11/40 is not supported.) Implies -m45. > +point on the PDP-11/40 is not supported.) Implies @option{-m45}. > > @opindex msoft-float > @item -msoft-float > Do not use hardware floating point. > > @opindex mac0 > -@item -mac0 > -Return floating-point results in ac0 (fr0 in Unix assembler syntax). > - > @opindex mno-ac0 > -@item -mno-ac0 > -Return floating-point results in memory. This is the default. > +@item -mac0 > +@itemx -mno-ac0 > +With @option{-mac0}, return floating-point results in ac0 > +(fr0 in Unix assembler syntax). The default, @option{-mno-ac0}, is > +to return floating-point results in memory. > > @opindex m40 > +@opindex mno-40 > @item -m40 > -Generate code for a PDP-11/40. Implies -msoft-float -mno-split. > +Generate code for a PDP-11/40. > +Implies @option{-msoft-float} @option{-mno-split}. > > @opindex m45 > +@opindex mno-45 > @item -m45 > Generate code for a PDP-11/45. This is the default. > > @opindex m10 > @item -m10 > -Generate code for a PDP-11/10. Implies -msoft-float -mno-split. > +Generate code for a PDP-11/10. > +Implies @option{-msoft-float} @option{-mno-split}. > > @opindex mint16 > @opindex mno-int32 > @@ -31714,8 +31718,9 @@ Use 16-bit @code{int}. This is the default. > Use 32-bit @code{int}. > > @opindex msplit > +@opindex mno-split > @item -msplit > -Target has split instruction and data space. Implies -m45. > +Target has split instruction and data space. Implies @option{-m45}. > > @opindex munix-asm > @item -munix-asm > @@ -31730,6 +31735,7 @@ Use DEC assembler syntax. > Use GNU assembler syntax. This is the default. > > @opindex mlra > +@opindex mno-lra > @item -mlra > Use the new LRA register allocator. By default, the old ``reload'' > allocator is used. > -- > 2.39.5 >
On 12/7/25 13:18, Paul Koning wrote: > The pdp-11 changes look mostly ok but I have two questions. > 1. Why did you remove -munix-asm, mdec-asm and -mgnu-asm along with -mlro from the gccoptlist at the top? My patch doesn't do that. :-) > 2. -m40 and -m45 aren't supposed to have negative forms. I guess I'm missing RejectNegative in the option definition. I can make that change, as long as you think it qualifies as "obvious" enough that I don't need to build/regression test GCC for this target. -Sandra
> On Dec 7, 2025, at 4:36 PM, Sandra Loosemore <sloosemore@baylibre.com> wrote: > > On 12/7/25 13:18, Paul Koning wrote: >> The pdp-11 changes look mostly ok but I have two questions. >> 1. Why did you remove -munix-asm, mdec-asm and -mgnu-asm along with -mlro from the gccoptlist at the top? > > My patch doesn't do that. :-) Maybe I misread the diff, but it says: @emph{PDP-11 Options} (@ref{PDP-11 Options}) -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 --mint32 -mno-int16 -mint16 -mno-int32 +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 +-mint32 -mint16 -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} which looks like the last line is going away. Or does that content appear through some other magic? > >> 2. -m40 and -m45 aren't supposed to have negative forms. I guess I'm missing RejectNegative in the option definition. > > I can make that change, as long as you think it qualifies as "obvious" enough that I don't need to build/regression test GCC for this target. Yes, I'm comfortable with that. paul
On Mon, 8 Dec 2025, Paul Koning wrote: > >> 1. Why did you remove -munix-asm, mdec-asm and -mgnu-asm along with > >> -mlro from the gccoptlist at the top? > > > > My patch doesn't do that. :-) > > Maybe I misread the diff, but it says: > > @emph{PDP-11 Options} (@ref{PDP-11 Options}) > -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 > --mint32 -mno-int16 -mint16 -mno-int32 > +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 > +-mint32 -mint16 > -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} > > which looks like the last line is going away. Or does that content > appear through some other magic? Something has eaten leading spaces on your side making the actual leading `-' character look as if it was line removal. The patch surely shows no change to the final line of PDP-11 options here: @@ -1292,8 +1292,8 @@ Objective-C and Objective-C++ Dialects}. -mcmodel=@var{code-model}} @emph{PDP-11 Options} (@ref{PDP-11 Options}) -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 --mint32 -mno-int16 -mint16 -mno-int32 +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 +-mint32 -mint16 -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} @emph{PowerPC Options} -- so at the very least it's reached the mailing list server intact. Maciej
> On Dec 8, 2025, at 7:49 PM, Maciej W. Rozycki <macro@orcam.me.uk> wrote: > > On Mon, 8 Dec 2025, Paul Koning wrote: > >>>> 1. Why did you remove -munix-asm, mdec-asm and -mgnu-asm along with >>>> -mlro from the gccoptlist at the top? >>> >>> My patch doesn't do that. :-) >> >> Maybe I misread the diff, but it says: >> >> @emph{PDP-11 Options} (@ref{PDP-11 Options}) >> -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 >> --mint32 -mno-int16 -mint16 -mno-int32 >> +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 >> +-mint32 -mint16 >> -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} >> >> which looks like the last line is going away. Or does that content >> appear through some other magic? > > Something has eaten leading spaces on your side making the actual leading > `-' character look as if it was line removal. The patch surely shows no > change to the final line of PDP-11 options here: ... You're quite correct. I did not know Mac Mail had that bug. I can see the message was delivered correctly when I examine it in "raw source" mode. Sorry for the false alarm. paul
On 12/8/25 17:33, Paul Koning wrote: > > >> On Dec 7, 2025, at 4:36 PM, Sandra Loosemore <sloosemore@baylibre.com> wrote: >> >> On 12/7/25 13:18, Paul Koning wrote: >>> The pdp-11 changes look mostly ok but I have two questions. >>> 1. Why did you remove -munix-asm, mdec-asm and -mgnu-asm along with -mlro from the gccoptlist at the top? >> >> My patch doesn't do that. :-) > > Maybe I misread the diff, but it says: > > @emph{PDP-11 Options} (@ref{PDP-11 Options}) > -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 > --mint32 -mno-int16 -mint16 -mno-int32 > +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 > +-mint32 -mint16 > -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} > > which looks like the last line is going away. Or does that content appear through some other magic? I think your mailer must be dropping the initial space on that line. If I were deleting it, it would start "--m" instead of "-m". Also, it would leave the braces unbalanced and the documentation would fail to build. :-P You might look at the mail in the archive, which is properly formatted. https://gcc.gnu.org/pipermail/gcc-patches/2025-December/703050.html >>> 2. -m40 and -m45 aren't supposed to have negative forms. I guess I'm missing RejectNegative in the option definition. >> >> I can make that change, as long as you think it qualifies as "obvious" enough that I don't need to build/regression test GCC for this target. > > Yes, I'm comfortable with that. OK, I'll take care of it. -Sandra
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index f403d20bc0b..413259f2fe3 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -1292,8 +1292,8 @@ Objective-C and Objective-C++ Dialects}. -mcmodel=@var{code-model}} @emph{PDP-11 Options} (@ref{PDP-11 Options}) -@gccoptlist{-mfpu -msoft-float -mac0 -mno-ac0 -m40 -m45 -m10 --mint32 -mno-int16 -mint16 -mno-int32 +@gccoptlist{-mfpu -msoft-float -mac0 -m40 -m45 -m10 +-mint32 -mint16 -msplit -munix-asm -mdec-asm -mgnu-asm -mlra} @emph{PowerPC Options} @@ -31675,31 +31675,35 @@ These options are defined for the PDP-11: @opindex mfpu @item -mfpu Use hardware FPP floating point. This is the default. (FIS floating -point on the PDP-11/40 is not supported.) Implies -m45. +point on the PDP-11/40 is not supported.) Implies @option{-m45}. @opindex msoft-float @item -msoft-float Do not use hardware floating point. @opindex mac0 -@item -mac0 -Return floating-point results in ac0 (fr0 in Unix assembler syntax). - @opindex mno-ac0 -@item -mno-ac0 -Return floating-point results in memory. This is the default. +@item -mac0 +@itemx -mno-ac0 +With @option{-mac0}, return floating-point results in ac0 +(fr0 in Unix assembler syntax). The default, @option{-mno-ac0}, is +to return floating-point results in memory. @opindex m40 +@opindex mno-40 @item -m40 -Generate code for a PDP-11/40. Implies -msoft-float -mno-split. +Generate code for a PDP-11/40. +Implies @option{-msoft-float} @option{-mno-split}. @opindex m45 +@opindex mno-45 @item -m45 Generate code for a PDP-11/45. This is the default. @opindex m10 @item -m10 -Generate code for a PDP-11/10. Implies -msoft-float -mno-split. +Generate code for a PDP-11/10. +Implies @option{-msoft-float} @option{-mno-split}. @opindex mint16 @opindex mno-int32 @@ -31714,8 +31718,9 @@ Use 16-bit @code{int}. This is the default. Use 32-bit @code{int}. @opindex msplit +@opindex mno-split @item -msplit -Target has split instruction and data space. Implies -m45. +Target has split instruction and data space. Implies @option{-m45}. @opindex munix-asm @item -munix-asm @@ -31730,6 +31735,7 @@ Use DEC assembler syntax. Use GNU assembler syntax. This is the default. @opindex mlra +@opindex mno-lra @item -mlra Use the new LRA register allocator. By default, the old ``reload'' allocator is used.