From patchwork Tue Sep 16 11:52:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2" X-Patchwork-Id: 120351 X-Patchwork-Delegate: rdapp.gcc@gmail.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 51DDF385B83E for ; Tue, 16 Sep 2025 12:00:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51DDF385B83E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=k2hd9nGE X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by sourceware.org (Postfix) with ESMTPS id 6CB943858C2A for ; Tue, 16 Sep 2025 11:53:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CB943858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CB943858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758023633; cv=none; b=cgczOB1nAqCJLEihqxA+bN4UxsW1Iqg26MGInDwbJdhwVOCXGITCVz1hmk2JqAlImAgBXAzPcxCdpdFo+Qphw+WEPjh9E1b7sKieoZBCvg3xrci2PNPHctNvkqn/auiFYnRhIbyDc4AhD21CCatA0ZPrhSEMS96v2KOrvbQ3+EQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758023633; c=relaxed/simple; bh=yGT3lcPf8QfmjY3WMAzCBzX17SVxeGqo+AhRTSVLUpA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GBP/PhK5nljn72c9d5a8uSxqm5udY9g2PyR8//Uphu1npZFDAoPot6g2volsTwAmqCFvAW4Hsa6+x2k4MrqXUQD1HjbTZhwveUdgAkQ0IPvWcP8EaTFeSgSY8euSvRNY8po4/sLY5tjisprA3zY76MmO+/XtuaJqmqZL+TzkvgE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CB943858C2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758023634; x=1789559634; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yGT3lcPf8QfmjY3WMAzCBzX17SVxeGqo+AhRTSVLUpA=; b=k2hd9nGEYRLHqer0w4++FPHyst7HM4VIDCSE3oL2smXtQeiAogEbFuVm mxZAR1RGE35JEQs2oixADPDmKCd6kdRf3EXnxFEodeov2K9DaRyRF51fc toxHqtIyolJ+nGuybkiH+GBc6Fuc3AsxziiJBdJNEJQSJlG3jaamFgmU5 OypqkDQjleymT3UNLYe+PifS8Iu+0KWHTZzOW5XGFw/t9q5WBbBPX7Gba nt+7PDIcnO1xoiSnpfAUD3caxBKOvKiLDnmipu/UFmlSrbQkaPEJO9kJB 3p8pX979mWrw2AMaVaPBIDGYY1XVDvlhLhr/rJhhSNTNs67dwQ1AtqUnG g==; X-CSE-ConnectionGUID: Q21wLTijQhaakeJvDsDLmA== X-CSE-MsgGUID: cYZvBwd/QVO68ZJSjJZ5dQ== X-IronPort-AV: E=McAfee;i="6800,10657,11554"; a="71667392" X-IronPort-AV: E=Sophos;i="6.18,269,1751266800"; d="scan'208";a="71667392" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2025 04:53:53 -0700 X-CSE-ConnectionGUID: jReqfnuxR5yN8we3ldVpGw== X-CSE-MsgGUID: wez8Kf3gSr2M2FTm57tajw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,269,1751266800"; d="scan'208";a="179303079" Received: from panli.sh.intel.com ([10.239.159.63]) by fmviesa005.fm.intel.com with ESMTP; 16 Sep 2025 04:53:50 -0700 From: pan2.li@intel.com To: gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, ken.chen@intel.com, hongtao.liu@intel.com, Pan Li Subject: [PATCH v2 1/4] RISC-V: Combine vec_duplicate + vwaddu.vv to vwaddu.vx on GR2VR cost Date: Tue, 16 Sep 2025 19:52:38 +0800 Message-ID: <20250916115428.1176402-2-pan2.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250916115428.1176402-1-pan2.li@intel.com> References: <20250916115428.1176402-1-pan2.li@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org From: Pan Li This patch would like to combine the vec_duplicate + vwaddu.vv to the vwaddu.vx. From example as below code. The related pattern will depend on the cost of vec_duplicate from GR2VR. Then the late-combine will take action if the cost of GR2VR is zero, and reject the combination if the GR2VR cost is greater than zero. Assume we have example code like below, GR2VR cost is 0. Before this patch: 11 beq a3,zero,.L8 12 vsetvli a5,zero,e32,m1,ta,ma 13 vmv.v.x v2,a2 ... 16 .L3: 17 vsetvli a5,a3,e32,m1,ta,ma ... 22 vwaddu.vv v1,v2,v3 ... 25 bne a3,zero,.L3 After this patch: 11 beq a3,zero,.L8 ... 14 .L3: 15 vsetvli a5,a3,e32,m1,ta,ma ... 20 vwaddu.vx v1,a2,v3 ... 23 bne a3,zero,.L3 The pattern of this patch only works on DImode, aka below pattern. v1:RVVM1DImode = (zero_extend:RVVM1DImode v2:RVVM1SImode) + (vec_dup:RVVM1DImode (zero_extend:DImode x2:SImode)); Unfortunately, for uint16_t to uint32_t or uint8_t to uint16_t, we loss this extend op after expand. For uint16_t => uint32_t we have: (set (reg:SI 149) (subreg/s/v:SI (reg/v:DI 146 [ rs1 ]) 0)) For uint32_t => uint64_t we have: (set (reg:DI 148 [ _6 ]) (zero_extend:DI (subreg/s/u:SI (reg/v:DI 146 [ rs1 ]) 0))) We can see there is no zero_extend for uint16_t to uint32_t, and we cannot hit the pattern above. So the combine will try below pattern for uint16_t to uint32_t. v1:RVVM1SImode = (zero_extend:RVVM1SImode v2:RVVM1HImode) + (vec_dup:RVVM1SImode (subreg:SIMode (:DImode x2:SImode))) But it cannot match the vwaddu sematics, thus we need another handing for the vwaddu.vv for uint16_t to uint32_t, as well as the uint8_t to uint16_t. gcc/ChangeLog: * config/riscv/autovec-opt.md (*widen_first__vx_): Add helper bridge pattern for vwaddu.vx combine. (*widen___vx_): Add new pattern to match vwaddu.vx combine. * config/riscv/iterators.md: Add code attr to get extend CODE. * config/riscv/vector-iterators.md: Add Dmode iterator for widen. Signed-off-by: Pan Li --- gcc/config/riscv/autovec-opt.md | 42 ++++++++++++++++++++++++++++ gcc/config/riscv/iterators.md | 3 ++ gcc/config/riscv/vector-iterators.md | 16 +++++++++++ 3 files changed, 61 insertions(+) diff --git a/gcc/config/riscv/autovec-opt.md b/gcc/config/riscv/autovec-opt.md index 315cd1d2ad5..a5eb49cc81e 100644 --- a/gcc/config/riscv/autovec-opt.md +++ b/gcc/config/riscv/autovec-opt.md @@ -1868,6 +1868,48 @@ (define_insn_and_split "*mul_minus_vx_" } [(set_attr "type" "vimuladd")]) +(define_insn_and_split "*widen_first__vx_" + [(set (match_operand:VWEXTI_D 0 "register_operand") + (vec_duplicate:VWEXTI_D + (any_extend: + (match_operand: 1 "register_operand"))))] + "TARGET_VECTOR && TARGET_64BIT && can_create_pseudo_p ()" + "#" + "&& 1" + [(const_int 0)] + { + rtx extend_scalar = gen_reg_rtx (mode); + emit_insn (gen_2 (extend_scalar, + operands[1])); + + insn_code icode = code_for_pred_broadcast (mode); + rtx vec_dup_ops[] = {operands[0], extend_scalar}; + riscv_vector::emit_vlmax_insn (icode, riscv_vector::UNARY_OP, vec_dup_ops); + + DONE; + }) + +(define_insn_and_split "*widen___vx_" + [(set (match_operand:VWEXTI_D 0 "register_operand") + (any_widen_binop:VWEXTI_D + (any_extend:VWEXTI_D + (match_operand: 1 "register_operand")) + (vec_duplicate:VWEXTI_D + (any_extend: + (match_operand: 2 "register_operand")))))] + "TARGET_VECTOR && TARGET_64BIT && can_create_pseudo_p ()" + "#" + "&& 1" + [(const_int 0)] + { + insn_code icode = code_for_pred_dual_widen_scalar (, + , + mode); + riscv_vector::emit_vlmax_insn (icode, riscv_vector::BINARY_OP, operands); + + DONE; + } + [(set_attr "type" "viwalu")]) ;; ============================================================================= ;; Combine vec_duplicate + op.vv to op.vf diff --git a/gcc/config/riscv/iterators.md b/gcc/config/riscv/iterators.md index cd8fd7a2b25..35de17f76cd 100644 --- a/gcc/config/riscv/iterators.md +++ b/gcc/config/riscv/iterators.md @@ -207,6 +207,9 @@ (define_mode_attr slot12_offset [(SI "-52") (DI "-104")]) ;; This code iterator allows signed and unsigned widening multiplications ;; to use the same template. (define_code_iterator any_extend [sign_extend zero_extend]) +(define_code_attr extend_name [ + (sign_extend "extend") (zero_extend "zero_extend") +]) ;; These code iterators allow unsigned and signed extraction to be generated ;; from the same template. diff --git a/gcc/config/riscv/vector-iterators.md b/gcc/config/riscv/vector-iterators.md index ed7e9c3a951..45af65642cd 100644 --- a/gcc/config/riscv/vector-iterators.md +++ b/gcc/config/riscv/vector-iterators.md @@ -943,6 +943,22 @@ (define_mode_iterator V_FRACT [ (RVVMF2SF "TARGET_VECTOR_ELEN_FP_32 && TARGET_VECTOR_ELEN_64") ]) +(define_mode_iterator VWEXTI_D [ + (RVVM8DI "TARGET_VECTOR_ELEN_64") (RVVM4DI "TARGET_VECTOR_ELEN_64") + (RVVM2DI "TARGET_VECTOR_ELEN_64") (RVVM1DI "TARGET_VECTOR_ELEN_64") + + (V1DI "riscv_vector::vls_mode_valid_p (V1DImode) && TARGET_VECTOR_ELEN_64") + (V2DI "riscv_vector::vls_mode_valid_p (V2DImode) && TARGET_VECTOR_ELEN_64") + (V4DI "riscv_vector::vls_mode_valid_p (V4DImode) && TARGET_VECTOR_ELEN_64") + (V8DI "riscv_vector::vls_mode_valid_p (V8DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 64") + (V16DI "riscv_vector::vls_mode_valid_p (V16DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 128") + (V32DI "riscv_vector::vls_mode_valid_p (V32DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 256") + (V64DI "riscv_vector::vls_mode_valid_p (V64DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 512") + (V128DI "riscv_vector::vls_mode_valid_p (V128DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 1024") + (V256DI "riscv_vector::vls_mode_valid_p (V256DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 2048") + (V512DI "riscv_vector::vls_mode_valid_p (V512DImode) && TARGET_VECTOR_ELEN_64 && TARGET_MIN_VLEN >= 4096") +]) + (define_mode_iterator VWEXTI [ RVVM8HI RVVM4HI RVVM2HI RVVM1HI RVVMF2HI (RVVMF4HI "TARGET_VECTOR_ELEN_64")