From patchwork Thu Sep 11 09:18:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 120056 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 866403858419 for ; Thu, 11 Sep 2025 09:49:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 866403858419 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=fkkoHolP X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 6912E3858436 for ; Thu, 11 Sep 2025 09:19:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6912E3858436 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6912E3858436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757582378; cv=none; b=JeoHicy8omCuckPGYFQIpFbnBasMw81BjLr2vJhkQVirPr8RRgknN4fv0Japn97bTgUkrtLBFheERIKt7t1Cy5VS3YUWEPinoMGJexMcL7+1sS3tec6BE7VuQXKIc6ZLY170fswZ3yZsfGqtexBG1s/t+EPNzonxtCby00wLIFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757582378; c=relaxed/simple; bh=iQqBg7KF/n23Zcpd2sq6LopHDyXkgCSpOpNkEqz3ukg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kV9DpcAazqFGGBscb2riJiGfkFZMY15rsR2kKMr1Nvs8LmdoBb+N0b/sbcOWLBH4E7/uw3WVycJjCgBUbMt8CLeMkU6NhPHelZyTHDRS0XqP0PwjoA5sFSbCnUXqqjDyqlrPihXZVSm+Ji9PmMTLLaBhAHOHYBh0NwcwgI8XHkU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6912E3858436 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3e751508f21so348971f8f.0 for ; Thu, 11 Sep 2025 02:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1757582377; x=1758187177; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w/HegwyxrHba9p4S8cejR2IGmjAaNyMkwqUEhyEw494=; b=fkkoHolPvr1Sa76GDAqEuW+xuqDwjzsKiUh5kGFsEaJhIY0n3BKCc831WtFeODwyKp 60vc/KEwhaArECkf+eFYqONH1gN0Ky8yD/ANhZZc7D5+HZu9a/MDpqUo/gQfiQxo4YtW k1fW/XpNY+rHnlSQ677UQTSRmEyyWKyNtHYIxhU+3gOxhZ2mCGqt5q4l5pPbOaR4a+ee ndv9Tp/QW7bjz1fbhHZhifUwYwKVAHKJ0zMhfn465NtNvp2H38K6YjHOmI3OfiJaOz0e nEhRR9MaudqCUbrnTAeS2QN8oi4v0gK5S49+Pn/1BhFRm7jqbz3p7QFV5h6hX9N+4TDe 40vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757582377; x=1758187177; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w/HegwyxrHba9p4S8cejR2IGmjAaNyMkwqUEhyEw494=; b=fP1lDjooC/WxNSibHnMb0a4/MhqcbLXndi8lEB0Uj9kbGIY+oQFJG+VzKeq87URTBC oAaU3ga0QxvOlUMQY+K92XiK7k/yHkECXBuitS+FdESRRNE99KWun1KkPNaov4yYkZZb ofuTQuWsHPa38SAziwqUyZXhNPfmpIuBnRJWR0OUPUsncdm2zwyVht9X5JEEAZy9gYYM rtfnUpkAcFxiG83EFJkWzMSQTr17/1S1Vqst3drbWDFaW/sbOxXUWMYttgsTMoUQfkxC 8PqwK1TvB11sDQCZsqBnLPzfXw2H9NeWOxRlh3teiqLx+gMt8OYKQ+WP/oo2F+x4MhBN duFA== X-Gm-Message-State: AOJu0YzggDcy/eIR0cWo/9gGAaaPAYRLrbEP3m+bWWjVBdEn6KQtnmK+ t+swAq4qstG18Mo48Zx/9J7sqv/pS6UyQWkK1VsRNp2+JaUn6iKwg72W2Ozt+Wf0/vNjSLpxgSN eTGw= X-Gm-Gg: ASbGncvf7Za6KmV45izd9JqP6JFW+//Fnbf7hZtNtlqNi+JH72uW3/sgugmEi7SMgs+ yZGDEd2QIPQSkoQP8mlNvYVk3HiGLkf7AQL3+ELyPRFwrHcqD9508KZwsM2aH0LsyKLq5Fb8uy2 P7PymA7k4g/GzYQ3U0enonRZ9ycPMl9rQqmjk3fzDP5XrVJNq5DXZGWsYSrw8HNLRfOV+eHHut+ juDRMVjxNiXNOzbhbWBjwaw54ITj9Pvt3+an0qKq3RsVIHj+MLBsdWPWTusFNj8Qtb2R1UbHdxk d4NGK1Q2o7YDh5KUO4dLRyZRzztisIZ6eaGOY/bmbKPqMlON/e1OVrns7211Lt2wsqagqZyrSkY HfXF3c86CssEDNDPBRWkDvtURvn/JeXXuBSHXFTRSyV+Yi0QVnuBTzlvRsrCx9Ua5cD8HMQlKGL 8+lzpuAs+phAGwSyTbx/xR3Envy4F1KhYwdL25ZDKlZSy4N/w3 X-Google-Smtp-Source: AGHT+IEpDtW6xjt5hIjf6I5W7gDsq1l9YPZcKxXgWY5+1JQ2ejELKKU+hvB2QokDjzTIlorjK2pidQ== X-Received: by 2002:a05:6000:290e:b0:3e7:516d:9a7c with SMTP id ffacd0b85a97d-3e7516d9d7dmr8220598f8f.39.1757582377073; Thu, 11 Sep 2025 02:19:37 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd27dsm1649971f8f.41.2025.09.11.02.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:19:36 -0700 (PDT) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Eric Botcazou Subject: [COMMITTED 27/31] ada: Fix crash on reference to aliased object of packed array type with -g Date: Thu, 11 Sep 2025 11:18:59 +0200 Message-ID: <20250911091904.1505690-27-poulhies@adacore.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250911091904.1505690-1-poulhies@adacore.com> References: <20250911091904.1505690-1-poulhies@adacore.com> MIME-Version: 1.0 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org From: Eric Botcazou This happens when the object is declared in another compilation unit. gcc/ada/ChangeLog: * gcc-interface/misc.cc (gnat_get_array_descr_info): In the record type case, bail out if the original array type cannot be retrieved. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/gcc-interface/misc.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/ada/gcc-interface/misc.cc b/gcc/ada/gcc-interface/misc.cc index 7711f8b0f82a..a79b87e3bdb2 100644 --- a/gcc/ada/gcc-interface/misc.cc +++ b/gcc/ada/gcc-interface/misc.cc @@ -837,6 +837,8 @@ gnat_get_array_descr_info (const_tree const_type, if (TYPE_IMPL_PACKED_ARRAY_P (array_type) && TYPE_ORIGINAL_PACKED_ARRAY (array_type)) array_type = TYPE_ORIGINAL_PACKED_ARRAY (array_type); + if (TREE_CODE (array_type) != ARRAY_TYPE) + return false; /* Shift back the address to get the address of the template. */ tree shift_amount