LoongArch: Change {dg-do-what-default} save and restore logical

Message ID 20250416022957.2740730-1-lixing@loongson.cn
State Committed
Commit dd982198656d914a4958bf86356a4c996c728b9d
Headers
Series LoongArch: Change {dg-do-what-default} save and restore logical |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed

Commit Message

Xing Li April 16, 2025, 2:29 a.m. UTC
  The set of {dg-do-what-default} to 'run' may lead some test hang
during make check.

gcc/testsuite
     *gcc.target/loongarch/vector/loongarch-vector.exp: Change
			{dg-do-what-default} save and restore logical
---
 .../gcc.target/loongarch/vector/loongarch-vector.exp        | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
  

Comments

Lulu Cheng April 18, 2025, 2:18 a.m. UTC | #1
在 2025/4/16 上午10:29, Xing Li 写道:
> The set of {dg-do-what-default} to 'run' may lead some test hang
> during make check.
>
> gcc/testsuite
>       *gcc.target/loongarch/vector/loongarch-vector.exp: Change
> 			{dg-do-what-default} save and restore logical

Hi,

There is a problem with the format of this changelog. You can regenerate 
it using the following command.

Otherwise LGTM.

# ./contrib/gcc-git-customization.sh

# git gcc-commit-mklog


Thanks!

> ---
>   .../gcc.target/loongarch/vector/loongarch-vector.exp        | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp b/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
> index f56d2f11bb3..9df3f290857 100644
> --- a/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
> +++ b/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
> @@ -35,7 +35,7 @@ dg-init
>   
>   # If the target hardware supports LSX, the default action is "run", otherwise
>   # just "compile".
> -global dg-do-what-default
> +set saved-dg-do-what-default ${dg-do-what-default}
>   if {[check_effective_target_loongarch_sx_hw]} then {
>     set dg-do-what-default run
>   } else {
> @@ -45,6 +45,7 @@ if {[check_effective_target_loongarch_sx_hw]} then {
>   #Main loop.
>   dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/lsx/*.\[cS\]]] \
>   	" -mlsx" $DEFAULT_CFLAGS
> +set dg-do-what-default ${saved-dg-do-what-default}
>   
>   dg-finish
>   
> @@ -52,7 +53,7 @@ dg-init
>   # If the target hardware supports LASX, the default action is "run", otherwise
>   # just "compile".
>   
> -global dg-do-what-default
> +set saved-dg-do-what-default ${dg-do-what-default}
>   if {[check_effective_target_loongarch_asx_hw]} then {
>     set dg-do-what-default run
>   } else {
> @@ -61,5 +62,6 @@ if {[check_effective_target_loongarch_asx_hw]} then {
>   
>   dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/lasx/*.\[cS\]]] \
>   	" -mlasx" $DEFAULT_CFLAGS
> +set dg-do-what-default ${saved-dg-do-what-default}
>   # All done.
>   dg-finish
  
Lulu Cheng April 18, 2025, 6:59 a.m. UTC | #2
The changelog format has been modified and pushed to r16-13 and r15-9556.

在 2025/4/16 上午10:29, Xing Li 写道:
> The set of {dg-do-what-default} to 'run' may lead some test hang
> during make check.
>
> gcc/testsuite
>       *gcc.target/loongarch/vector/loongarch-vector.exp: Change
> 			{dg-do-what-default} save and restore logical
> ---
>   .../gcc.target/loongarch/vector/loongarch-vector.exp        | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp b/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
> index f56d2f11bb3..9df3f290857 100644
> --- a/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
> +++ b/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
> @@ -35,7 +35,7 @@ dg-init
>   
>   # If the target hardware supports LSX, the default action is "run", otherwise
>   # just "compile".
> -global dg-do-what-default
> +set saved-dg-do-what-default ${dg-do-what-default}
>   if {[check_effective_target_loongarch_sx_hw]} then {
>     set dg-do-what-default run
>   } else {
> @@ -45,6 +45,7 @@ if {[check_effective_target_loongarch_sx_hw]} then {
>   #Main loop.
>   dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/lsx/*.\[cS\]]] \
>   	" -mlsx" $DEFAULT_CFLAGS
> +set dg-do-what-default ${saved-dg-do-what-default}
>   
>   dg-finish
>   
> @@ -52,7 +53,7 @@ dg-init
>   # If the target hardware supports LASX, the default action is "run", otherwise
>   # just "compile".
>   
> -global dg-do-what-default
> +set saved-dg-do-what-default ${dg-do-what-default}
>   if {[check_effective_target_loongarch_asx_hw]} then {
>     set dg-do-what-default run
>   } else {
> @@ -61,5 +62,6 @@ if {[check_effective_target_loongarch_asx_hw]} then {
>   
>   dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/lasx/*.\[cS\]]] \
>   	" -mlasx" $DEFAULT_CFLAGS
> +set dg-do-what-default ${saved-dg-do-what-default}
>   # All done.
>   dg-finish
  

Patch

diff --git a/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp b/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
index f56d2f11bb3..9df3f290857 100644
--- a/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
+++ b/gcc/testsuite/gcc.target/loongarch/vector/loongarch-vector.exp
@@ -35,7 +35,7 @@  dg-init
 
 # If the target hardware supports LSX, the default action is "run", otherwise
 # just "compile".
-global dg-do-what-default
+set saved-dg-do-what-default ${dg-do-what-default}
 if {[check_effective_target_loongarch_sx_hw]} then {
   set dg-do-what-default run
 } else {
@@ -45,6 +45,7 @@  if {[check_effective_target_loongarch_sx_hw]} then {
 #Main loop.
 dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/lsx/*.\[cS\]]] \
 	" -mlsx" $DEFAULT_CFLAGS
+set dg-do-what-default ${saved-dg-do-what-default}
 
 dg-finish
 
@@ -52,7 +53,7 @@  dg-init
 # If the target hardware supports LASX, the default action is "run", otherwise
 # just "compile".
 
-global dg-do-what-default
+set saved-dg-do-what-default ${dg-do-what-default}
 if {[check_effective_target_loongarch_asx_hw]} then {
   set dg-do-what-default run
 } else {
@@ -61,5 +62,6 @@  if {[check_effective_target_loongarch_asx_hw]} then {
 
 dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/lasx/*.\[cS\]]] \
 	" -mlasx" $DEFAULT_CFLAGS
+set dg-do-what-default ${saved-dg-do-what-default}
 # All done.
 dg-finish