Message ID | 20250414163138.506753-18-arthur.cohen@embecosm.com |
---|---|
State | Committed |
Commit | 9ed95c06977068cce86b5d35aee905533c757d57 |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 377813857C7B for <patchwork@sourceware.org>; Mon, 14 Apr 2025 17:04:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 377813857C7B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=ZCJvYRN7 X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id F41433857BAF for <gcc-patches@gcc.gnu.org>; Mon, 14 Apr 2025 16:31:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F41433857BAF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F41433857BAF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::434 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744648308; cv=none; b=iFpb/TLLPT1MINlIPDjHn5AgO9xr6oXZnR9h7FVM1bYleF9w5QlGULfgyJlc55XMG8jHYjsMFOL9M1p0E7SA4aGowRdIGeNseLUaMaFlFuDm8pN/XckDBp2n5VbRDG5kXaA1XOdvDRSNeW8b2v2AZvTqbu07l3yPLu3kCrPUvno= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744648308; c=relaxed/simple; bh=jaXVgXGdMl3gdS3uH8kwhoavqyiH5f15b1Juw6iB3IQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CriaJPpFq/f/cAT0DmwlkT1/gAk+HE/e9EO1XZKOES7BQac4uZepqtJgtxftWvbDRfcxWSxs4dD9alTq3f3TZKP+eWjLt6KG6X4xMY+f3V/wREcQ8V8Ji19nHMmIUE/377m7NA367XmyOPCf+AgENolLfcaO1hlt6pCs9Vg+71s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F41433857BAF Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3912d2c89ecso4272761f8f.2 for <gcc-patches@gcc.gnu.org>; Mon, 14 Apr 2025 09:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1744648306; x=1745253106; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ugYXdjXwJhK/aE5kaOQ/XIRXPAgTj6EuLgVnnN0cPU=; b=ZCJvYRN72X6+gSXHIc5plgVCPj9eQBjXc/8gSyiHnKkm8z/GFbn5ogZGFINrgBtpse 89EM+qhVXpVD6PdJLB9+xEhAR8LkqceHf7qiUKUWuzMAgLSrwU9k31hNEVqJy1/Ar50h SQtaDx88VxusWQX5lrppWl8cF0LSNgpdSAHMGOtZsjLak5FsFNXh1nDiq2tgOwJoX/I8 QPZu2++9ToJM9iA0w1UaQFGvxrvTJbsvmwoJr8tDj8nnTK2JOHlSSIuwDfCWWkIrom1w II08+fJzYZ2ZQ5dYMMs4LpvlkrYVVvcDvw4Fkq08gREpuuwC0DsnhaF9ati4olLBY/U3 dxPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744648306; x=1745253106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6ugYXdjXwJhK/aE5kaOQ/XIRXPAgTj6EuLgVnnN0cPU=; b=RqguZ7z3+asSIwn9x9ogNZV+ajoDKGlCx5xH/fRctPlZQnojkN7WtN4YPQK48XqcVE G7n17wo54nyZ4sYCLj0N5yQX+gb3K5CHUJah1uJA5RYd9gQWv9OqGPLIEa73wyNwwlPv Y9j8qrZUBmRqqFddtspud+bjRzo6CWSkl7RBTs/c6WxIxbYicQXqq3EgCMs7q8JSut2P PzuDh3TFGUwp+Tt4JWBG5xLyranJlYc7VLsFynwFJy0p6rBSiAeqze9xu0i9rmiMvap8 AKXxzGeFg1XE5ap6mVE/xokv79FwkUVh550pZS80r1jvVHr9QADnQ0YgZswxZK8Ob/Nl BR6Q== X-Gm-Message-State: AOJu0YyzST8LCHeAXg0LP0m3zq2gWNk24j6PXjuSSDGpfeOQ4vsj2MvO IFzYN8kac21ftkZ4QNfOJAgOm8rNjEm7ygTIELkEEGCLNfTl/mRFfMGGkYD2e/F3LLV6iMl4k7o neg== X-Gm-Gg: ASbGncuWOiUB02O+nLMTUJvsNhZC8h1zJDwwV8Tczu7I3FwyftcvJWZkQnNdcwEii+s /Xg+YE8AhuXp4jrTMXYXwZnargcP7Fiyd7h1zV5ij2iaqiKlRepc5tIo5rHeVM9LVI4vlXSeU4L yRIcL48R6VG5BTEJCChANwid0ywtgOJ8y/aSDrilBiIcI7Z2vdV/qi7rMMV1KZ5XHn8d4xJowfe qlmAGvpSsuK/sgIUXuplpBsyCaZVpss5tR7zLtLE6wxcxzHt4saw2n76P54D1qvqQPibxFFCjCj MD+pwGkIk42voFr7mIaC0tMKL0L4ILtG4PMNwTFYNUsQYcxZxQ== X-Google-Smtp-Source: AGHT+IGEB2aowFwSao6m1aywZbqD9qKNgwFAH2zJFHPlWuvvAJn5kKH4kRHEpPtn85OgLAxDEIIwzw== X-Received: by 2002:a5d:6d82:0:b0:39c:141a:6c67 with SMTP id ffacd0b85a97d-39eaaed2101mr11601162f8f.45.1744648306372; Mon, 14 Apr 2025 09:31:46 -0700 (PDT) Received: from platypus.lan ([2a04:cec2:23:71c0:c543:1fff:77d1:f317]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39ed15caa5asm6399335f8f.20.2025.04.14.09.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Apr 2025 09:31:45 -0700 (PDT) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Arthur Cohen <arthur.cohen@embecosm.com> Subject: [COMMITTED 17/19] gccrs: nr2.0: Only insert derive macros if they exist Date: Mon, 14 Apr 2025 18:31:37 +0200 Message-ID: <20250414163138.506753-18-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250414163138.506753-2-arthur.cohen@embecosm.com> References: <20250414163138.506753-2-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
[COMMITTED,01/19] rust: Use FLOAT_TYPE_P instead of manual checking
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_simplebootstrap_build--master-arm-bootstrap | fail | Patch failed to apply |
Commit Message
Arthur Cohen
April 14, 2025, 4:31 p.m. UTC
From: Arthur Cohen <arthur.cohen@embecosm.com>
This causes an assertion failure when compiling core with nr2.0, but should
probably be improved. I'm not sure how this code enables built-in derive
macros to be resolved so this is a temporary fix.
gcc/rust/ChangeLog:
* resolve/rust-early-name-resolver-2.0.cc (Early::visit_attributes): Remove assertion.
---
gcc/rust/resolve/rust-early-name-resolver-2.0.cc | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gcc/rust/resolve/rust-early-name-resolver-2.0.cc b/gcc/rust/resolve/rust-early-name-resolver-2.0.cc index afaca1f71f0..36456e10ff2 100644 --- a/gcc/rust/resolve/rust-early-name-resolver-2.0.cc +++ b/gcc/rust/resolve/rust-early-name-resolver-2.0.cc @@ -325,10 +325,9 @@ Early::visit_attributes (std::vector<AST::Attribute> &attrs) auto pm_def = mappings.lookup_derive_proc_macro_def ( definition->get_node_id ()); - rust_assert (pm_def.has_value ()); - - mappings.insert_derive_proc_macro_invocation (trait, - pm_def.value ()); + if (pm_def.has_value ()) + mappings.insert_derive_proc_macro_invocation (trait, + pm_def.value ()); } } else if (Analysis::BuiltinAttributeMappings::get ()