diff mbox series

[COMMITTED,13/19] gccrs: Fix const checking of enum discriminants

Message ID 20250414163138.506753-14-arthur.cohen@embecosm.com
State New
Headers
Series [COMMITTED,01/19] rust: Use FLOAT_TYPE_P instead of manual checking |

Commit Message

Arthur Cohen April 14, 2025, 4:31 p.m. UTC 
  From: Owen Avery <powerboat9.gamer@gmail.com>

gcc/rust/ChangeLog:

	* checks/errors/rust-const-checker.cc
	(ConstChecker::visit): Visit the enum items of enums.
	* resolve/rust-ast-resolve-item.cc
	(ResolveItem::visit): Resolve enum discriminants during nr1.0.

gcc/testsuite/ChangeLog:

	* rust/compile/enum_discriminant2.rs: New test.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
---
 gcc/rust/checks/errors/rust-const-checker.cc     | 3 +++
 gcc/rust/resolve/rust-ast-resolve-item.cc        | 2 ++
 gcc/testsuite/rust/compile/enum_discriminant2.rs | 9 +++++++++
 3 files changed, 14 insertions(+)
 create mode 100644 gcc/testsuite/rust/compile/enum_discriminant2.rs
diff mbox series

Patch

diff --git a/gcc/rust/checks/errors/rust-const-checker.cc b/gcc/rust/checks/errors/rust-const-checker.cc
index 4904322b938..4c2257a2455 100644
--- a/gcc/rust/checks/errors/rust-const-checker.cc
+++ b/gcc/rust/checks/errors/rust-const-checker.cc
@@ -646,6 +646,9 @@  ConstChecker::visit (Enum &enum_item)
 {
   check_default_const_generics (enum_item.get_generic_params (),
 				ConstGenericCtx::Enum);
+
+  for (auto &item : enum_item.get_variants ())
+    item->accept_vis (*this);
 }
 
 void
diff --git a/gcc/rust/resolve/rust-ast-resolve-item.cc b/gcc/rust/resolve/rust-ast-resolve-item.cc
index d584961354f..30f6d430b86 100644
--- a/gcc/rust/resolve/rust-ast-resolve-item.cc
+++ b/gcc/rust/resolve/rust-ast-resolve-item.cc
@@ -356,6 +356,8 @@  ResolveItem::visit (AST::EnumItemDiscriminant &item)
   auto cpath = canonical_prefix.append (decl);
 
   mappings.insert_canonical_path (item.get_node_id (), cpath);
+
+  ResolveExpr::go (item.get_expr (), path, cpath);
 }
 
 void
diff --git a/gcc/testsuite/rust/compile/enum_discriminant2.rs b/gcc/testsuite/rust/compile/enum_discriminant2.rs
new file mode 100644
index 00000000000..351dfbb6f85
--- /dev/null
+++ b/gcc/testsuite/rust/compile/enum_discriminant2.rs
@@ -0,0 +1,9 @@ 
+fn test() -> isize {
+    1
+}
+
+enum Foo {
+    Bar = test() // { dg-error "only functions marked as .const." }
+}
+
+fn main() {}