From patchwork Wed Feb 12 04:38:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 106351 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 163183858C2B for ; Wed, 12 Feb 2025 04:39:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 163183858C2B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=MuTEH1hT X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id AA2703858C60 for ; Wed, 12 Feb 2025 04:38:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA2703858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA2703858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739335102; cv=none; b=UzWKmNj9xRQiNbLDTv5Hp/dCIPwFkONe8opMOujb4AIp5oHlQlKS7sAeP4WF+rodOVMhqmffik9T9BBNr/wAfoNx+BDsrmuElbXGNCBnxNgHx4tVOEutUuUgD/R31O1MuUuxcE+VifuyZzwqI3kk7DfX9H2CokzEDogwfEMDgF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739335102; c=relaxed/simple; bh=vvzre6I4kdpL9XO5C7HQg0QlJp1rdM/rhtX8JCKMQTc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TGBVbDKY+omOcl5rDkEZdvXilyHQMNk5RGq5DGnQIvlzMFCAxOqELQGXQWuNEeGR57xY1AwsxwmPWVhEGEXdVnn7eT7Xo7/oSnz+9BvvjwhPAWxir9kE/v3OU1ern2Y7DFXwk8uac60FzHX0+TlD6zO7cc0hQRNjEeYNWlpuTVY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA2703858C60 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51BI8ms5004359 for ; Wed, 12 Feb 2025 04:38:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=125qeBQZcawy1i/CDth8oU GM3xr3jKEd+8kttq2y8YA=; b=MuTEH1hTOTYR6TwDysPECwP3lWuuwsz0lh19Qg DbBIWFaDssJplFSbU+cBgmfVPoouAH8wjH8Xanz3280QSFjkJ3l2JflONUnCeDYc CbZodggmystduoujD2OAneadu0nT8fG1dpbBGp/0LWOQwrfGCOm5uXMDFCMfPsEG XjdpbW5d0n0/sNhvH9ZVJhBCkak+tY+c8LEjqt4wiRqDiIDHOtoQJSG0VAGUzogw MFw7iuDE7QyT/KwJ8XRKF7z76lzDPRGVuXD34GoTQTD2HYbXmlErpNxgo7E9UQb1 zZXdFiLAcQ1LIjk2I/jY+Prhm285IJA+9EpeAEolxomMkJOg== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44p0gv1wcb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Feb 2025 04:38:22 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 51C4cL4w003063 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Feb 2025 04:38:21 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 11 Feb 2025 20:38:20 -0800 From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH] ifcvt: Don't speculation move inline-asm [PR102150] Date: Tue, 11 Feb 2025 20:38:06 -0800 Message-ID: <20250212043806.208724-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: KlYfvIf9cuJsE6NM7gdlvARyZ0bARLXm X-Proofpoint-GUID: KlYfvIf9cuJsE6NM7gdlvARyZ0bARLXm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-12_01,2025-02-11_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=806 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502120034 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org So unlike loop invariant motion, moving an inline-asm out of an if is not always profitable and the cost estimate for the instruction inside inline-asm is unknown. This is a regression from GCC 4.6 which didn't speculatively move inline-asm as far as I can tell. Bootstrapped and tested on x86_64-linux-gnu. PR rtl-optimization/102150 gcc/ChangeLog: * ifcvt.cc (cheap_bb_rtx_cost_p): Return false if the insn has an inline-asm in it. Signed-off-by: Andrew Pinski --- gcc/ifcvt.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gcc/ifcvt.cc b/gcc/ifcvt.cc index cb5597bc171..707937ba2f0 100644 --- a/gcc/ifcvt.cc +++ b/gcc/ifcvt.cc @@ -166,6 +166,12 @@ cheap_bb_rtx_cost_p (const_basic_block bb, { if (NONJUMP_INSN_P (insn)) { + /* Inline-asm's cost is not very estimatable. + It could be a costly instruction but the + estimate would be the same as a non costly + instruction. */ + if (asm_noperands (PATTERN (insn)) >= 0) + return false; int cost = insn_cost (insn, speed) * REG_BR_PROB_BASE; if (cost == 0) return false;