testsuite: Exclude test in pr109393.c from ilp32 targets [PR116845]

Message ID 20250204113502.1965416-1-konstantinos.eleftheriou@vrull.eu
State New
Headers
Series testsuite: Exclude test in pr109393.c from ilp32 targets [PR116845] |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 fail Patch failed to apply

Commit Message

Konstantinos Eleftheriou Feb. 4, 2025, 11:35 a.m. UTC
  From: kelefth <konstantinos.eleftheriou@vrull.eu>

The match.pd canonicalization that this testcase checks for,
is not applied on ilp32 targets.

This prevents the test from running on ilp32 targets.

	PR116845

gcc/testsuite/ChangeLog:

	* gcc.dg/pr109393.c: Exclude ilp32 targets.
---
 gcc/testsuite/gcc.dg/pr109393.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Richard Biener Feb. 4, 2025, 11:44 a.m. UTC | #1
On Tue, Feb 4, 2025 at 12:36 PM Konstantinos Eleftheriou
<konstantinos.eleftheriou@vrull.eu> wrote:
>
> From: kelefth <konstantinos.eleftheriou@vrull.eu>
>
> The match.pd canonicalization that this testcase checks for,
> is not applied on ilp32 targets.
>
> This prevents the test from running on ilp32 targets.
>
>         PR116845
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.dg/pr109393.c: Exclude ilp32 targets.
> ---
>  gcc/testsuite/gcc.dg/pr109393.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/pr109393.c b/gcc/testsuite/gcc.dg/pr109393.c
> index b2dd5a0b645..e0c42873c1b 100644
> --- a/gcc/testsuite/gcc.dg/pr109393.c
> +++ b/gcc/testsuite/gcc.dg/pr109393.c
> @@ -20,4 +20,5 @@ int bar(int *a, int j)
>    return (&a[j + 1] - 2) == &a[k];
>  }
>
> -/* { dg-final { scan-tree-dump-times "return 1;" 3 "optimized" } } */
> +/* The pattern is not applied on ilp32 targets (PR116845).  */
> +/* { dg-final { scan-tree-dump-times "return 1;" 3 "optimized" { target { ! ilp32 } } } } */

can you instead xfail for ilp32?

OK with that change.

> --
> 2.47.0
>
  
Philipp Tomsich Feb. 4, 2025, 1:23 p.m. UTC | #2
Applied to master with the requested change (to XFAIL for ilp32).

Thanks,
Philipp.

On Tue, 4 Feb 2025 at 12:45, Richard Biener <richard.guenther@gmail.com>
wrote:

> On Tue, Feb 4, 2025 at 12:36 PM Konstantinos Eleftheriou
> <konstantinos.eleftheriou@vrull.eu> wrote:
> >
> > From: kelefth <konstantinos.eleftheriou@vrull.eu>
> >
> > The match.pd canonicalization that this testcase checks for,
> > is not applied on ilp32 targets.
> >
> > This prevents the test from running on ilp32 targets.
> >
> >         PR116845
> >
> > gcc/testsuite/ChangeLog:
> >
> >         * gcc.dg/pr109393.c: Exclude ilp32 targets.
> > ---
> >  gcc/testsuite/gcc.dg/pr109393.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/gcc.dg/pr109393.c
> b/gcc/testsuite/gcc.dg/pr109393.c
> > index b2dd5a0b645..e0c42873c1b 100644
> > --- a/gcc/testsuite/gcc.dg/pr109393.c
> > +++ b/gcc/testsuite/gcc.dg/pr109393.c
> > @@ -20,4 +20,5 @@ int bar(int *a, int j)
> >    return (&a[j + 1] - 2) == &a[k];
> >  }
> >
> > -/* { dg-final { scan-tree-dump-times "return 1;" 3 "optimized" } } */
> > +/* The pattern is not applied on ilp32 targets (PR116845).  */
> > +/* { dg-final { scan-tree-dump-times "return 1;" 3 "optimized" { target
> { ! ilp32 } } } } */
>
> can you instead xfail for ilp32?
>
> OK with that change.
>
> > --
> > 2.47.0
> >
>
  

Patch

diff --git a/gcc/testsuite/gcc.dg/pr109393.c b/gcc/testsuite/gcc.dg/pr109393.c
index b2dd5a0b645..e0c42873c1b 100644
--- a/gcc/testsuite/gcc.dg/pr109393.c
+++ b/gcc/testsuite/gcc.dg/pr109393.c
@@ -20,4 +20,5 @@  int bar(int *a, int j)
   return (&a[j + 1] - 2) == &a[k];
 }
 
-/* { dg-final { scan-tree-dump-times "return 1;" 3 "optimized" } } */
+/* The pattern is not applied on ilp32 targets (PR116845).  */
+/* { dg-final { scan-tree-dump-times "return 1;" 3 "optimized" { target { ! ilp32 } } } } */