Message ID | 20250131171232.1018281-41-aleksandar.rakic@htecgroup.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3F48A3857704 for <patchwork@sourceware.org>; Fri, 31 Jan 2025 18:18:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F48A3857704 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=htecgroup.com header.i=@htecgroup.com header.a=rsa-sha256 header.s=selector1 header.b=vIyd51z/ X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20702.outbound.protection.outlook.com [IPv6:2a01:111:f403:260d::702]) by sourceware.org (Postfix) with ESMTPS id F120F3858C3A for <gcc-patches@gcc.gnu.org>; Fri, 31 Jan 2025 17:14:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F120F3858C3A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=htecgroup.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=htecgroup.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F120F3858C3A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:260d::702 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738343692; cv=pass; b=TD9H4PUwN3NxYgenVe6un4/jMd2LqqkRgdQcVPoTABB7qud6ALpHMbLaytokaQQMhRKgiDqeoBPxFC+d2UrHPrwXXoz0JCjNOGeUWpxFzUua3+lVo5T56DuA9a9RtDeE+KVhiBL9J06aBNW5MRBaUIpVaRQFCwmpJTCXlnvhlC4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738343692; c=relaxed/simple; bh=5qvcBr0UHCljMGAgkA/K7naHPenYDLpr4z6Q7IwtVB0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xS3HJ52F884MRv+rCGTEpa51f5NpRj+SNr7NDqAeFy9PffcAyC/GdEJmLKkb75g7tLByU1r0yBQ3kBKDq61GEGWCnXGbhnnkcqQ1jnP8ux3UGzDXkwkz4XZ6WFHQnw5ENNZ0lrkx6SfZKNp21c4bqptp+glxVzzK+RZwitZrDh0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F120F3858C3A ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gh5Sh1DqgLBlfMUOWsba3EOFM9U0TSJrY+nqmhYdIJxgMjdgKT/ihhlnFcPBepRPTczfIigG1eiYS0Etw1Fbu1kEjgjjxWY7D0TJlvPW4Uvg8bW4dPnmF6EAJGm/hsuPDTcvVY6YLmFs+3Huwx5vv2M4afy4CYr5g7wY8A9x3fPkVpabhS1uXDUeGVd4vm6O6nu84laiQiVRxeDieS2Qm9PaP/aQIDlZxWIDSeggU1IzBtHOgIoMe1y+uuPEwbX7rshzTPOtHKoGw8S+oKH2FwX3WfG/lf0I8VpcQr/O0i2C5Ei6pla2pFyy1ctbfd2LKcw8B0nZWhSQTg0A78lw6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QvYK81Rq0tJaOBwx/m0gt/O0Wa+8QRHdHVBd+wJ+xG0=; b=a4ASQd2vuEtYCTH6H/SG8Dn3TEm/++/ccf4z/qk0BBGPYVItCkEAfFWj1ls7MvXxpR7K34vF8HiFrIRi+4hq0/aXY6T7vU1bKBJ5hqSpAt8q6gWGzw4Ss1IPfw+GX5iz3+TLbHKQla8e6hL4nIMivMCu/o3NfaeosFseCwPYEFbBqJQdM+hgnz6V0tENXm5HAWHXwzbMFaYcax4jl0Z/DU5wBhynBDgr4JUFpxL+GFJYSfmwBtGrEZqpEl+oi8TnUMRVATQR8SZkaWzcd7+11i2/ZXHT0kGeaBRlJBzBIN9Z3b3aYf29QcFN290BdhXJhQo5hKYEdsC6SI3G+z8QDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=htecgroup.com; dmarc=pass action=none header.from=htecgroup.com; dkim=pass header.d=htecgroup.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=htecgroup.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QvYK81Rq0tJaOBwx/m0gt/O0Wa+8QRHdHVBd+wJ+xG0=; b=vIyd51z//13kJ1G7rSFxyvKsUIq8+KS+ubFe3bHYqlWJZTm1RYPej+O9019ois6aFnNSfg0UFMxA1Z4gTCBzZ9mzJ74rZGKfVD00xwBw+Mh2egHMbYouXvr1VERjNomDIUsHbf4Xt0U21U5U4TauqO2ALrFtCH4g4Qz8ExtfT1slIAfgS79FK+/yv33/Ca9QQ//ITUyMECV/emTUmBNN4v2hhEpNiT4EzuAsO5Nc3ptNfK7hEwjhXL42tgQdqmBHyFUx0mphqycJ5N0wCWYPT5kSh0E8dOUxj1IDRTPJj90HVH5BPv4BSeEwEVGDSp6X66Ko4CICObKakAbqyoFYzQ== Received: from PA4PR09MB4864.eurprd09.prod.outlook.com (2603:10a6:102:ed::17) by AS2PR09MB6367.eurprd09.prod.outlook.com (2603:10a6:20b:59d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.21; Fri, 31 Jan 2025 17:14:07 +0000 Received: from PA4PR09MB4864.eurprd09.prod.outlook.com ([fe80::a02b:9d5c:eca5:e024]) by PA4PR09MB4864.eurprd09.prod.outlook.com ([fe80::a02b:9d5c:eca5:e024%6]) with mapi id 15.20.8398.020; Fri, 31 Jan 2025 17:14:07 +0000 From: Aleksandar Rakic <aleksandar.rakic@htecgroup.com> To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> CC: Djordje Todorovic <Djordje.Todorovic@htecgroup.com>, "cfu@mips.com" <cfu@mips.com>, Matthew Fortune <matthew.fortune@imgtec.com>, Faraz Shahbazker <fshahbazker@wavecomp.com>, Aleksandar Rakic <aleksandar.rakic@htecgroup.com> Subject: [PATCH 39/61] Frame barrier fix Thread-Topic: [PATCH 39/61] Frame barrier fix Thread-Index: AQHbdAN4SM7NU4WDz0657h0+5wq/qQ== Date: Fri, 31 Jan 2025 17:13:39 +0000 Message-ID: <20250131171232.1018281-41-aleksandar.rakic@htecgroup.com> References: <20250131171232.1018281-1-aleksandar.rakic@htecgroup.com> In-Reply-To: <20250131171232.1018281-1-aleksandar.rakic@htecgroup.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=htecgroup.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR09MB4864:EE_|AS2PR09MB6367:EE_ x-ms-office365-filtering-correlation-id: fd2b2eeb-c06b-43b2-e9a1-08dd421aabfa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?0MqVWzHymn2t8qb51oCI4cGXfh?= =?iso-8859-1?q?ypA7e8vPMTkH7iLBZeJxmeF9wyC5HO4W7/6qEEeyzDYlp95A6s+Tx69UG11P?= =?iso-8859-1?q?xGyGaqgElXvZfXUPsBYUUk/SE0dv4wo2PskRnipkJQOW7sylXG+sd3CZ5rO6?= =?iso-8859-1?q?YKc1Q+WPdpdRuNyV7x9hqYOVhIYMeXWNUODMPZ9uPNWx1+hz0vl4JqDVdoFC?= =?iso-8859-1?q?xdJ3xYvF3KJHrdmJKMK5Oc/ZaFysRVkyttXDv9+EjCcdZVNHzfVydPLzhOUE?= =?iso-8859-1?q?M2yYWI2lrzANdWse19GpExrGoan0UZzGfsEilgFrrydzKzPb3B0SCvPV6wwx?= =?iso-8859-1?q?4nO2vMRTtGjMj/REHhDnyqqgcFIAWAqlmy8YXtKqcWM2g93RU7el/P7Hhj1v?= =?iso-8859-1?q?NDXd44be5sjwYClc5871/MXNU3uUzVCflXs7BEwSVvigOqZa4ifQPTeB0NCI?= =?iso-8859-1?q?DXi6BYN2VBFn06u1MOrfiix2+iR36IKEDAxiHB0PcLvdsWHaQshdWXSKGkN9?= =?iso-8859-1?q?iichDGVc54HF0uQlZD5XnIxPxnw4zJDLr1BIACY+q5UExRCRSHXAgEZikYdg?= =?iso-8859-1?q?DIIi7pHFbi8ORG6uLA02AupIsQGnGlr+Nc9/s+MWvpo6tX9Vu4xflhuTL/3Z?= =?iso-8859-1?q?prQ3Mx8ecwknP1CIhu36BvpX1ttj8Moyr+6u3fvAmRhfZMEllY4LxCyWZdQF?= =?iso-8859-1?q?/THgOKp5zsxXCafDSXf1X/RohYJ4pdsI6pJDdCkuqAQVQe9wrNoDlHxybxxA?= =?iso-8859-1?q?Nun14q61I/Kbkv4YSjE+JtADAGawwTkLQD3wl0XTC14uZ6kuQumVBftWC2Zj?= =?iso-8859-1?q?VLyUdOYhYoXXJTDFMBfCVOcVN1///VkAlGN081XQ1KTQqoBliWP54v1HlgXk?= =?iso-8859-1?q?vOdWzmY84xtvySXjXl0TRvmoyYe3Yk4c+EM40T7pF/2MTw9nvHqCGBdAaVAL?= =?iso-8859-1?q?DN11SerHG8OkIQTWpYx7yU8vfhr3oaQtBTJG26RnkZVK+wIhYFG67kY2daT2?= =?iso-8859-1?q?l7AjrjBhkBuBsNy3ECS+CZ+2A+yS3xBjb9PfPK5yapN/GpjS/lmI5VF5RwHB?= =?iso-8859-1?q?+beYdiaCFsLiLPdBlSYS3XgIQwscMbnbo77QmUlau86eviHX9ieLtkC1Fyqe?= =?iso-8859-1?q?86fdzXfbWtzYT5IYezvru5WlugtyJtrEmk8843XdMu6FJWyzE7hnk1tJBKWT?= =?iso-8859-1?q?meltjdVJzUf6tGBXKTHfa5A7CJG5JB4xZxTAZMtxhy4ahBdkl8MAx9l0Kq6g?= =?iso-8859-1?q?lGF5k+2W4F6/lf5zMihDefwzasmtyHNJlDKdGYnAqgedkPdtKoxmb7gq4nls?= =?iso-8859-1?q?8lrJ+iXCwZDxuVscrMgXVDGf4sjQIGDUErqMDDOfpQUff6rQBWenxOK+9ET3?= =?iso-8859-1?q?Iigv5VaeeSfW550P8b7C9jMkeR0V9X/KYJk2yFdOoaIr624ICdJrWvOuZAIN?= =?iso-8859-1?q?9EQ6QvWjzwLfZGkuPiuxpK/NpElVBlXYrEoKPbASMkRjZ+PhV/k4Vp6mKrX0?= =?iso-8859-1?q?/UppIj?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR09MB4864.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?j/rTI1KKpnsiGcG4DwU21Wp?= =?iso-8859-1?q?MD2sdpX1K7dS888hfbv3OTH0GQpMGBI2/8paUq7+803u8Vewo0vCVgGbIewt?= =?iso-8859-1?q?fd8gbm6QqaNXuro7m8SqjNuMoDsDHHiul3JhQb6gmtrEjZuDnSR7Hmf3FhYG?= =?iso-8859-1?q?JIql6KwL7Yu8AJL8Q+ouTYjITvSM9oNs10cNbcwZMdnOgXjlojnGJeWa8Aie?= =?iso-8859-1?q?dvbVS0b0ZA7212zslUHbGBqApf2MIUkBzg9LoFiQ387sWIW6Bepr7fuxR08q?= =?iso-8859-1?q?f3JxqCnvLCAsP+3cUEJl3+3i45JlTI3dEHWURZGE95/EzaFAlTEVH79gtPjw?= =?iso-8859-1?q?CAkj3Sk7YBnFoiWE2uprXBNA/VAxAh987NSE1wflJnd2Kx8k5zNPQLRAUsl8?= =?iso-8859-1?q?hSYAB7/nebPadp5YcEOgW0JAYKowQah9sj2EX/Xv90tAlmhl4/LYPy159Gr8?= =?iso-8859-1?q?DJldp93kommYoW1dAhY9A9RqrvWp12XOVb9/a0nxQGzWwpLMxjyG9wxcGF5T?= =?iso-8859-1?q?u43NmyuGhyXL0UoKR736eOGA+BbSzU4FzT8jwBCty/4pjCQtrMfuJsYyE45U?= =?iso-8859-1?q?V0eMO5Qc5lofuLa3IkueecXGFwrwETF3+o0eMInm6liqcGN2RxSzUbfjAZHg?= =?iso-8859-1?q?ys9dy1GV/5TeXktaw+/RbHgM1A5Dqfx6P+2L50QU7sG3oF62qmJKB6JNfef4?= =?iso-8859-1?q?c6XdAcnubU/SlkZxh7bGvdXJfczcs+HTtcTvKX1eAodE2uf7+3JcZVP8cHuu?= =?iso-8859-1?q?YKUMXxD8Xz2eGS1wKN38th85ujM8GFHmUsTn7daGhfZ71rg2SNdJvhsgaNIn?= =?iso-8859-1?q?i8Y1ehinqKGTCmfaNujBnZH4rgqUMxri7kv5lgk/vcH8P/3o5+pPip3LMEck?= =?iso-8859-1?q?iI/D2AfN1oj9DcYzvSSt/FN3NC2BZTGGv5BpdmDbYSf3R/fL/PK5eL0uFrjK?= =?iso-8859-1?q?+lJCxsHWn2FV2kJz1lFBFIbh5JICFryYyqIf0zh6FqllStoRE3xYJGf5sIGn?= =?iso-8859-1?q?0+2NsuPrBvZAMSvuTrJgUAwQnLNx3tcV451kH3o4IDpZxpzaDY4JNc5yxS/7?= =?iso-8859-1?q?fbvFEA95HHmo1wq1CSoPjhUIEFHlYNBmbO+rikf3GjRWKAEyHptmE1M1459P?= =?iso-8859-1?q?qiGM1KMbzW+EoQRxQvui7455ys2DlcJ8adneFfI79opLBd5EWqr1/XrZgye8?= =?iso-8859-1?q?tt/k2APFoXmQhVsRPqpTmSZw/AdsDkqASFl9rlLNSCzTU1e0metJCMh5dD2G?= =?iso-8859-1?q?2JWiheRHDDhtNzoLEStbePeN0ybMJ+Izy4KE2zJ+WV40AKiVR/2isXctwnef?= =?iso-8859-1?q?jbOS0695GIolB+lAn4EwgVWjL9Ke89NS+41UFdCbFEBWxPww4092aSfPWg45?= =?iso-8859-1?q?9tbTVK9qZmtC9J8o87bftRsuWQE7WT87gVJWHbJjN4ZvFbES+nibPopdvrfF?= =?iso-8859-1?q?3rtAdQUG7RAgsK9i3u5+7XiLJW65HvGyDLt8/5IOtzO/Odjx+vDjo+K10Ez0?= =?iso-8859-1?q?0Zog0KH4UWrpj+LNCA2ADAi2VQR7C11bMP7PwmVGq17c89bD1jpU9cSH/IUf?= =?iso-8859-1?q?Cot0G+Rw4TOawdp8ODmIFl85dobi/Rw0ccORRq+4wPV23OjNC4vDd+SBTIVK?= =?iso-8859-1?q?cGpCLi9mPA80lDJPlumMMMTpP3/tD8XHVif/xs4ClcC58U+2+GYB3vwMga1E?= =?iso-8859-1?q?=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: htecgroup.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR09MB4864.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd2b2eeb-c06b-43b2-e9a1-08dd421aabfa X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2025 17:13:39.4910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9f85665b-7efd-4776-9dfe-b6bfda2565ee X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m4i/J8IklovbQ71RlfZkMkfuNe1iqqS6yGhx0l94Df7bJhDo3iygLepX32HLML90s9FvF4482IKSMTgoindaFUSEtrMtE9Ac5zXeC6bGDJg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR09MB6367 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
Improve Mips target
|
|
Commit Message
Aleksandar Rakic
Jan. 31, 2025, 5:13 p.m. UTC
From: Matthew Fortune <matthew.fortune@imgtec.com> Ensure the frame barrier prevents reordering of stack pointer changes. It is possible for a load/store accessing the stack via a copy of the stack pointer to be moved across the epilogue meaning that it accesses stack that is no longer allocated. This leads to a situation where the code is unsafe in the event of an interrupt where the same stack is used for interrupt handling. gcc/ * config/mips/mips.cc (mips_frame_barrier): Upgrade to a full blockage. Cherry-picked 0c240da6f6032bd19348b97148d25c05ba2e8356 from https://github.com/MIPS/gcc Signed-off-by: Matthew Fortune <matthew.fortune@imgtec.com> Signed-off-by: Faraz Shahbazker <fshahbazker@wavecomp.com> Signed-off-by: Aleksandar Rakic <aleksandar.rakic@htecgroup.com> --- gcc/config/mips/mips.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/mips/mips.cc b/gcc/config/mips/mips.cc index dcb4b9f9f99..57a858aca39 100644 --- a/gcc/config/mips/mips.cc +++ b/gcc/config/mips/mips.cc @@ -13626,7 +13626,7 @@ mips_output_function_epilogue (FILE *) static void mips_frame_barrier (void) { - emit_clobber (gen_frame_mem (BLKmode, stack_pointer_rtx)); + emit_insn (gen_blockage ()); }