From patchwork Mon Jan 13 10:53:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 104669 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D86A385782C for ; Mon, 13 Jan 2025 10:56:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D86A385782C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=a8tgTfsY X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id B12C53858D21 for ; Mon, 13 Jan 2025 10:54:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B12C53858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B12C53858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736765646; cv=none; b=C+nX/96gYVe+/EcqZIwXulRpFJBGAMa6D8txKgzBqP277jo9tNCfK+1dZoHD9v8ZLgJSio3FYObk/is/lS0btRTu/MFSxU5PutXdwAcrOiOqRbi8qz7fkdnB9I87MqeVpOHZqsfxq9EqZDOO/VLLExGLoJOAlLhXWL5Jefzv6ZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736765646; c=relaxed/simple; bh=FkV7WBwTbt1WuiXFIUa08IImkUHZX6bQBPSL3mP9qZs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xt975EychiAM08g8x33HAjzeNIzOflrFswABMxV9Qk7eYHuTkXvlQepp5ntAew5/5mFg4bZqxVjPhHDkXkoe56aO4ImTt0JTQ4hxPzReaSwKl+A8r1AUwOiiatO+aWgG/ENDL76AYVqvYYMgt8b/ypeWSyoYPABGsYSmeTpSnc8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B12C53858D21 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4361f664af5so47415905e9.1 for ; Mon, 13 Jan 2025 02:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1736765644; x=1737370444; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VCUJ31KFVPFWIANAhYJyblrsaNjEVtNmGyqp0KFEFWY=; b=a8tgTfsYUd9+C3FhFJKtg2D9QXvGoAJOK+4UX5A6ot7iOEPgtX9DvVHVk1cXSDYrVU Y+i7xk4LCBcH5dZBIeDBiXqrX6IsQmWyK9XuCg1ygM0t/fMHc+dzbg8dLnY81p+qS1O4 DdLSiiMFFE38sDcffY9jItrmic8VQBAkDXx4rQqdr94YNl4Bu3Yz/aP39jYRqwPwE360 xP3hCyhqRHfkpZS0VDMoC9IUOp/0ksFoeuEgmNrmEyl4XMrNFSVEjoIQ1uQTYmaG/Vqs hm4URPaheZ9xKyymZkk6vBMLC7BLUdHFe84P5HvGUW8SyCRM2dczagnPant/O4oUoC5X D8Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736765644; x=1737370444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VCUJ31KFVPFWIANAhYJyblrsaNjEVtNmGyqp0KFEFWY=; b=gtmvFfikk2gIxU+u09JN8h/eGnQY2mqXxlrCEkN1Yh1mUCS9G8vCZ8HLc+Uyesyi1q kTvcMhSVDRLxb5idE8LbFsWvakGmZHenFqM9rSw39GZO8Klre77kaWIFJhHkTzUvFRw1 GCJiYPhMkaO9q/hGhlbfwEHKsdqWCf/qfblzPv9bRH+r/is1n8ODR9PCJTna41VIwVdz Z8DnpwE3qqVGte0ptPRr8JUsKnKgdbwGMLrFONOgL0Vm8rubztpcfXIv71RBilppr1Jy soDl+MZ75960EbIgs0c9d2AdZS0dhSrmHdvcO5b+wRQNCNdF4wLAmdoXsg9w0eMu7Ogf vc9w== X-Gm-Message-State: AOJu0Yz4vxo4p1Uf2QRibxnWrS9qH0lC34M045of8dlQU169dv63LSiw WGxObX8VnNTSRv30MFPnE252EUkKrLjPkI+X6JIzoaSRqf/jLL+11F55OTFqgaOvpb7rnamXKWc = X-Gm-Gg: ASbGnctSLGOz2ScgvxhSVyr6nh2Q9HCsM5jTOzklHqSiBH7qy2+WZ2hStC+ov3NXob/ RWcjxQrk8y/ieFk+emcNQEzlN43/fLZtRzxEsvqi91Fighoadb/Uw+Z46Q5EqI/R1FI4LO9Pzim m2TEPwWfy98s7LlLirj4z/nnLwbNzxaXIsj8N1m58VfLunzteMHIrbACVaYP/2CCcvKbMBiGAPi HVaWnDqTjZx207I42EsnZcrmcu+xYQSmNJoM9wOPgF01ZU1iUQ5vZPvO/easGCXS/WBviLAHy3c zZP4O6YjWw6kVaF/jNycHztJfE047D4DHQZY/XbY5g7or2jmyMcxAYSEW1djC2tHJSlUBLM3 X-Google-Smtp-Source: AGHT+IGz1gyCGFw5VSoxL4NTjS2c5fNjMwAdG/yuzMZx+ZxSOq/qt1EZkMPR4gEqpTomKWEeAAL8mg== X-Received: by 2002:a5d:5f82:0:b0:385:e1a8:e28e with SMTP id ffacd0b85a97d-38a872faed5mr18590972f8f.10.1736765644300; Mon, 13 Jan 2025 02:54:04 -0800 (PST) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e3834fbsm11709138f8f.26.2025.01.13.02.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 02:54:03 -0800 (PST) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Eric Botcazou Subject: [COMMITTED 02/14] ada: Add more commentary to System.Val_Real.Large_Powfive Date: Mon, 13 Jan 2025 11:53:35 +0100 Message-ID: <20250113105349.928779-2-poulhies@adacore.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250113105349.928779-1-poulhies@adacore.com> References: <20250113105349.928779-1-poulhies@adacore.com> MIME-Version: 1.0 X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org From: Eric Botcazou gcc/ada/ChangeLog: * libgnat/s-valrea.adb (Large_Powfive) [2 parameters]: Add a couple of additional comments. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/libgnat/s-valrea.adb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gcc/ada/libgnat/s-valrea.adb b/gcc/ada/libgnat/s-valrea.adb index ed22366840f..aff694dd721 100644 --- a/gcc/ada/libgnat/s-valrea.adb +++ b/gcc/ada/libgnat/s-valrea.adb @@ -396,6 +396,9 @@ package body System.Val_Real is begin pragma Assert (Exp > Maxexp); + -- This routine supports any type but it is not necessary to invoke it + -- for large types because the above one is sufficient for them. + pragma Warnings (Off, "-gnatw.a"); pragma Assert (not Is_Large_Type); pragma Warnings (On, "-gnatw.a"); @@ -407,6 +410,8 @@ package body System.Val_Real is -- its final value does not overflow but, if it's too large, then do not -- bother doing it since overflow is just fine. The scaling factor is -3 -- for every power of 5 above the maximum, in other words division by 8. + -- Note that Maxpow is an upper bound of the span of exponents for which + -- scaling is needed, but it's OK to apply it even if it is not needed. if Exp - Maxexp <= Maxpow then S := 3 * (Exp - Maxexp);