From patchwork Sat Jan 11 07:33:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 104570 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B8983857BB3 for ; Sat, 11 Jan 2025 07:36:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B8983857BB3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dgu2/yoF X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 36677385828B for ; Sat, 11 Jan 2025 07:34:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36677385828B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36677385828B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736580867; cv=none; b=trdjA5GBB2wQmCR0mD6GPkNiyhbghe+LEjmNQWh+G7NbdGq0EUHzO1ITRJIikRDu8iCw9GaotV8nZN/I0tFPvXt6hf+di+97QqsWfdYgq07iMpGKRYgsp23O247KfVvGRJv35LKW/tnNKHF6gYj5D3oWz73yWzq0Qpz+sx7wDzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736580867; c=relaxed/simple; bh=uF6Gs4orpYGN3ITarAwowYhBC2Nt/0tvyPwRwXObaIY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wRHCxjh8mlToCNdGbhjPYKCnHKOpiDKHJRwk0/jT8JaSyGV6C8z5nBT3KVlOY02YBwOFXJw0YhctTVosfTXVrkSrDleuODWPWMq5GJklMIgRRdE6UsNkFsgYZY7tjo4TYNNDc1MT6tYAVEpvTw+u6i0euGVPl9yieADqOI6FLTc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36677385828B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736580867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j825aGqD0Iz6fTIr8/dCw/LjT0bAXtWWYcI59/IY4aE=; b=Dgu2/yoFtaSt2O9ivcNYPLeM8dMLhNDHfxHLWoGOH4xZRojOtyrS43zGdm+cJKql4Iw/Wo dS7Mztp/NHJ6LrXgjaQuFmdErvCqhWvNTNlzSYTptqef0+uzxt/fhPBSmNGgPwc5zzVy9r uqEVM7qEiu2We40/PZkHsq7kJc6g3SI= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-i0wmyuZtMeGK0r2jSGSkZg-1; Sat, 11 Jan 2025 02:34:18 -0500 X-MC-Unique: i0wmyuZtMeGK0r2jSGSkZg-1 X-Mimecast-MFC-AGG-ID: i0wmyuZtMeGK0r2jSGSkZg Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6d8f51b49e5so51338816d6.1 for ; Fri, 10 Jan 2025 23:34:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736580857; x=1737185657; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j825aGqD0Iz6fTIr8/dCw/LjT0bAXtWWYcI59/IY4aE=; b=KC/+xiOcZpJonMRE48W6KStJW/EW2sSyXI1uUFuaw6ArmSIjBBK4dI5zkhbfcyrjUj epwBEa3OzL5MYmeU10ItYs03XOQcU6BCR3njdQPvFegrR2Jm8uieXU0c3E3ZAWtsCX5F pH/6bjwbQQ7mxueBOND/9CczZqQuZN/9Ul0OJrzXMlpA0FmUXBRXY6PHJYyB+T3e86gr BZh7ind8jCwGJyDM4kx6xb23EQVFrVRws1/CZsVxaE5p9wBmXGVb1T/e4FZ1T32OW6vf XAnZslg8Lk4nln+uzCUjzFVFHaimaLh9zDZ4VJoV71evRl8TzXSbNnpr4jgG8fW/fPKc 2yLQ== X-Gm-Message-State: AOJu0YxJBsGLowNkHGVOya3rRes9MBkVREtrbiHffBhipdh71hsfKeYy 03dq4SpkIfXeOeKIh7DyjEddSgIcZno+LuGIvfPYK7mMIEg/2OUPVXCpBimZWMhm3WDjyUeNmpe Bu1q27leiFpHqWGAgNXh3Q0vhdJ4JO4LtvKB/wwiZyoMtrzfvzc4m4QU2AgAmxu+Pt8rTb5+tys PBHHHJrkAW6y9w0xS1ioudnLK4KgNkGBkdhtC0Bg== X-Gm-Gg: ASbGncs62wyt9fGdlXhHO48S5qMLQl5GNYv7osmDxiYebpdDgN/XDp5gTnxYRBXADDm 2n9regfkWYj7PYT49ljsM6sW3APpoAvsByYo3DEA8Wng8wnBAWiL71P+epEyvjk3TBkMMvEbQWU rKyOo2jkYsjeeTraZTRKZBC3pLsWRstiqaQdKYHxPEp85doUYihrlS8kvE7gndbySIGEcfltLQQ hPPqbFynl893qfj8tPbIB7BJ0MvsnYkwRl4d7MycfaRjNb6wFTQmgPdx9cWhLmCsNVxJEAuVXqJ EbLgLXG96bQeJUAwlG9lkdCswNIK15L5aBlTYcw/MaJv3iD2TZVvvafYgMa8PJFjwTn9kzEqDSy rrqBRVztprA== X-Received: by 2002:ad4:5ca1:0:b0:6d8:9b7b:14c9 with SMTP id 6a1803df08f44-6df9b1b5254mr160258916d6.8.1736580856957; Fri, 10 Jan 2025 23:34:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGZXzvhihdldkbcjJiH9W5V9uwq5tAvpEBBCRyuwo4ZJ9VO+k6xjiQLkp60AmoJNfEiHO07g== X-Received: by 2002:ad4:5ca1:0:b0:6d8:9b7b:14c9 with SMTP id 6a1803df08f44-6df9b1b5254mr160258706d6.8.1736580856537; Fri, 10 Jan 2025 23:34:16 -0800 (PST) Received: from jason-thinkpadp1gen4i.rmtusma.csb (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dfad88e2eesm17562076d6.33.2025.01.10.23.34.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 23:34:15 -0800 (PST) From: Jason Merrill To: gcc-patches@gcc.gnu.org Subject: [pushed 1/2] c++: modules and class attributes Date: Sat, 11 Jan 2025 02:33:44 -0500 Message-ID: <20250111073412.190565-1-jason@redhat.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e10SSrgO0ubb7PipNhu8C90wTZ9Jxe4Il_RDxiGN-8M_1736580858 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- std/time/traits/is_clock.cc was getting a warning about applying the deprecated attribute to a variant of auto_ptr, which was wrong because it's on the primary type. This turned out to be because we were ignoring the attributes on the definition of auto_ptr because the forward declaration in unique_ptr.h has no attributes. We need to merge attributes as usual in a redeclaration. gcc/cp/ChangeLog: * module.cc (trees_in::decl_value): Merge attributes. gcc/testsuite/ChangeLog: * g++.dg/modules/attrib-1_a.C: New test. * g++.dg/modules/attrib-1_b.C: New test. --- gcc/cp/module.cc | 4 ++++ gcc/testsuite/g++.dg/modules/attrib-1_a.C | 13 +++++++++++++ gcc/testsuite/g++.dg/modules/attrib-1_b.C | 10 ++++++++++ 3 files changed, 27 insertions(+) create mode 100644 gcc/testsuite/g++.dg/modules/attrib-1_a.C create mode 100644 gcc/testsuite/g++.dg/modules/attrib-1_b.C base-commit: f30423ea8c2152dcee91056e75a4f3736cce6a6e diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc index 4fbe522264b..321d4164a6a 100644 --- a/gcc/cp/module.cc +++ b/gcc/cp/module.cc @@ -8637,6 +8637,10 @@ trees_in::decl_value () TYPE_STUB_DECL (type) = stub_decl ? stub_decl : inner; if (stub_decl) TREE_TYPE (stub_decl) = type; + + /* Handle separate declarations with different attributes. */ + tree &eattr = TYPE_ATTRIBUTES (TREE_TYPE (existing)); + eattr = merge_attributes (eattr, TYPE_ATTRIBUTES (type)); } if (inner_tag) diff --git a/gcc/testsuite/g++.dg/modules/attrib-1_a.C b/gcc/testsuite/g++.dg/modules/attrib-1_a.C new file mode 100644 index 00000000000..d5f89d0c068 --- /dev/null +++ b/gcc/testsuite/g++.dg/modules/attrib-1_a.C @@ -0,0 +1,13 @@ +// { dg-additional-options "-fmodules -Wno-global-module" } +// { dg-module-cmi M } + +module; + +template struct A { + void f() const { } +} __attribute__ ((deprecated ("y tho"))); + +export module M; + +export template +A a; // { dg-warning "deprecated" } diff --git a/gcc/testsuite/g++.dg/modules/attrib-1_b.C b/gcc/testsuite/g++.dg/modules/attrib-1_b.C new file mode 100644 index 00000000000..48ac751b03d --- /dev/null +++ b/gcc/testsuite/g++.dg/modules/attrib-1_b.C @@ -0,0 +1,10 @@ +// { dg-additional-options -fmodules } + +template struct A; + +import M; + +int main() +{ + a.f(); +}