diff mbox series

[pushed,1/2] c++: modules and class attributes

Message ID 20250111073412.190565-1-jason@redhat.com
State New
Headers
Series [pushed,1/2] c++: modules and class attributes |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gcc_build--master-arm fail Patch failed to apply

Commit Message

Jason Merrill Jan. 11, 2025, 7:33 a.m. UTC 
  Tested x86_64-pc-linux-gnu, applying to trunk.

-- 8< --

std/time/traits/is_clock.cc was getting a warning about applying the
deprecated attribute to a variant of auto_ptr, which was wrong because it's
on the primary type.  This turned out to be because we were ignoring the
attributes on the definition of auto_ptr because the forward declaration in
unique_ptr.h has no attributes.  We need to merge attributes as usual in a
redeclaration.

gcc/cp/ChangeLog:

	* module.cc (trees_in::decl_value): Merge attributes.

gcc/testsuite/ChangeLog:

	* g++.dg/modules/attrib-1_a.C: New test.
	* g++.dg/modules/attrib-1_b.C: New test.
---
 gcc/cp/module.cc                          |  4 ++++
 gcc/testsuite/g++.dg/modules/attrib-1_a.C | 13 +++++++++++++
 gcc/testsuite/g++.dg/modules/attrib-1_b.C | 10 ++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 gcc/testsuite/g++.dg/modules/attrib-1_a.C
 create mode 100644 gcc/testsuite/g++.dg/modules/attrib-1_b.C


base-commit: f30423ea8c2152dcee91056e75a4f3736cce6a6e
diff mbox series

Patch

diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc
index 4fbe522264b..321d4164a6a 100644
--- a/gcc/cp/module.cc
+++ b/gcc/cp/module.cc
@@ -8637,6 +8637,10 @@  trees_in::decl_value ()
 	  TYPE_STUB_DECL (type) = stub_decl ? stub_decl : inner;
 	  if (stub_decl)
 	    TREE_TYPE (stub_decl) = type;
+
+	  /* Handle separate declarations with different attributes.  */
+	  tree &eattr = TYPE_ATTRIBUTES (TREE_TYPE (existing));
+	  eattr = merge_attributes (eattr, TYPE_ATTRIBUTES (type));
 	}
 
       if (inner_tag)
diff --git a/gcc/testsuite/g++.dg/modules/attrib-1_a.C b/gcc/testsuite/g++.dg/modules/attrib-1_a.C
new file mode 100644
index 00000000000..d5f89d0c068
--- /dev/null
+++ b/gcc/testsuite/g++.dg/modules/attrib-1_a.C
@@ -0,0 +1,13 @@ 
+// { dg-additional-options "-fmodules -Wno-global-module" }
+// { dg-module-cmi M }
+
+module;
+
+template <class T> struct A {
+  void f() const { }
+} __attribute__ ((deprecated ("y tho")));
+
+export module M;
+
+export template <class T>
+A<T> a;				// { dg-warning "deprecated" }
diff --git a/gcc/testsuite/g++.dg/modules/attrib-1_b.C b/gcc/testsuite/g++.dg/modules/attrib-1_b.C
new file mode 100644
index 00000000000..48ac751b03d
--- /dev/null
+++ b/gcc/testsuite/g++.dg/modules/attrib-1_b.C
@@ -0,0 +1,10 @@ 
+// { dg-additional-options -fmodules }
+
+template <class T> struct A;
+
+import M;
+
+int main()
+{
+  a<int>.f();
+}