From patchwork Fri Jan 10 15:29:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 104483 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC6CD3858427 for ; Fri, 10 Jan 2025 15:29:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC6CD3858427 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YI6j8xLP; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VE7CWXgB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YI6j8xLP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VE7CWXgB X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id CB0143858C48 for ; Fri, 10 Jan 2025 15:29:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB0143858C48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB0143858C48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736522941; cv=none; b=TbCj4dzP12ImMUlPrpUpdAdTevpWepBxJZPMcPaQOMhgRN2yja31tVzu2GD6fP7wHXqRpRqETXgqXrUJI3B/WcTh9NbX91oC90ER3USUr1QdFESRvldQsyHhpXff0trn6m6j+/Vycw0DyOfPdbHS/VPlVG5AUvwDOZt8SqcEXLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736522941; c=relaxed/simple; bh=BCbgxI0iewmkYuKW8ZV+7mL/fj4cSBPRX/Uwl7YSYXY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=lr37SrkD6TOVeIGPMq/iAGg5CUpOuunkWAcrj0hf86BWeg01lYN4kRLbrPvRJfM1wPfrEMrO9n27DK0s6f/GxRI/UdVrlk0/cFsczH3T1j+JYZlTwIbrk/tjM1+bU0M1oBeodu7GsSrMGaSz7ut7NdSqP/ozD7KcKmwurZdYlsM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB0143858C48 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A03031F396 for ; Fri, 10 Jan 2025 15:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736522940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=OKZUgOOiMGJC6wHnl/wZZWkIfaZx8pzoFckuuxN7tQU=; b=YI6j8xLPyccp/hOLSKrelWX+RL43DUdsg0eVbWpTuHyyRuuX7FUxq2QIz8r/fWci7kSltc nWsc+XVGgh9LYzbNV7s1GGDWYbbRT3kHX3o7s3duDahJFYX6HNKfh+fzBJumpNRDx9I1/v zNPMZbr1ZA2Fo2EJGvbIJWtwxe56q+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736522940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=OKZUgOOiMGJC6wHnl/wZZWkIfaZx8pzoFckuuxN7tQU=; b=VE7CWXgB/LaSA29HhFdyuP9N2UX+a3TIUv2RzqekJ8hpFoQVcc6UpeHvP/9lHnVJfuogZN cUa44zOVtTDu7zAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YI6j8xLP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VE7CWXgB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736522940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=OKZUgOOiMGJC6wHnl/wZZWkIfaZx8pzoFckuuxN7tQU=; b=YI6j8xLPyccp/hOLSKrelWX+RL43DUdsg0eVbWpTuHyyRuuX7FUxq2QIz8r/fWci7kSltc nWsc+XVGgh9LYzbNV7s1GGDWYbbRT3kHX3o7s3duDahJFYX6HNKfh+fzBJumpNRDx9I1/v zNPMZbr1ZA2Fo2EJGvbIJWtwxe56q+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736522940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=OKZUgOOiMGJC6wHnl/wZZWkIfaZx8pzoFckuuxN7tQU=; b=VE7CWXgB/LaSA29HhFdyuP9N2UX+a3TIUv2RzqekJ8hpFoQVcc6UpeHvP/9lHnVJfuogZN cUa44zOVtTDu7zAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 83A5213763 for ; Fri, 10 Jan 2025 15:29:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XFn/Hbw8gWeWCAAAD6G6ig (envelope-from ) for ; Fri, 10 Jan 2025 15:29:00 +0000 Date: Fri, 10 Jan 2025 16:29:00 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] More memory leak fixes MIME-Version: 1.0 Message-Id: <20250110152900.83A5213763@imap1.dmz-prg2.suse.org> X-Rspamd-Queue-Id: A03031F396 X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org The following were found compiling SPEC CPU 2017 with valgrind. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. * tree-vect-slp.cc (vect_analyze_slp): Release saved_stmts vector. (vect_build_slp_tree_2): Release new_oprnds_info when not used. --- gcc/tree-vect-slp.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 337506419d9..8188f6b07c5 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -2678,6 +2678,8 @@ out: nops = 1; has_two_operators_perm = true; } + else + vect_free_oprnd_info (new_oprnds_info); } auto_vec children; @@ -4951,8 +4953,8 @@ vect_analyze_slp (vec_info *vinfo, unsigned max_tree_size, max_tree_size, &limit, bst_map, NULL, force_single_lane); } - saved_stmts.release (); } + saved_stmts.release (); } /* Make sure to vectorize only-live stmts, usually inductions. */