From patchwork Tue Jan 7 12:53:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 104260 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B8D33858405 for ; Tue, 7 Jan 2025 13:28:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B8D33858405 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Av4EQ/Sn X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id DC188385843B for ; Tue, 7 Jan 2025 12:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC188385843B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC188385843B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736254470; cv=none; b=kRfBKfdFWSvkyGy6a9RUfQOCLSNd49IbVtYZfxJQEnrQBDvcoaJwC3ZOc3slt9tmw5bfyBY+5ujg+yJlxk90uK60DZD6PXFo2v/LHpLP7+mAFZqp9moMEN3kqfJnt5OS5KbAHtBKJAFMfJlaSX4rWJlse82HQ9pbhcMK47nBM9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736254470; c=relaxed/simple; bh=wepg3GYFURUOUW3RoZp0M2JJU+hO0dTnZ8UoXe0MI8A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JeQM18ZBXdL41xVxMe+DP+Fe10MXBM29QNx6LYz7+wxlYbgA2mhPTRxdnWT75MbO7d2GECxwhuQD65k+DcFazTlKR6OXJh68BcCx2Dfuv0xrStrPdnhcLB6j0WEDoBN1jvuAhfmb1edvoEZCSUM8dIi2Vj+hXqtd7YPEwPhSfqc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC188385843B Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3862d161947so7369465f8f.3 for ; Tue, 07 Jan 2025 04:54:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1736254468; x=1736859268; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nGu3DrxpC1JYzZWVotYzBzvxdD/9Y6xGEU+qDRgGDvU=; b=Av4EQ/Sn6xUyVywTRITnVDYnN+BZ3rvoO+5kb9nCoFWFCtS824vrGvblTp/Bvi7V9n wKHdNcgr1nZBkl12cPLpNfycOSMFYY5s7Bxhdpc3f4Y0H6c0GNNTokaAl2eB2Od61Ftd 88iePIydC+D3kun3oKyjo49Q5U9K+8S4pDJRPWukAExYq742yjuQ7uEaAfoQxhRbnsr6 NIsMfaj41CZ8HPyZeXOlLRjBZqbTLpEh1MM/lyZWihCb4aHHVOo04qmHzoKz9FrfeObP rwqShFKKp2XY9DNYkkay3v1qkRRqqqPPyj6Y+n/21kp+F5JlkNLM3bbWPNzJ4Zi+Kg6r t5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736254468; x=1736859268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nGu3DrxpC1JYzZWVotYzBzvxdD/9Y6xGEU+qDRgGDvU=; b=v/Zv/6joqYQKT62ejnLBwcAZAPoOk4XgUYVm4dav9cpuI5GsD9Dt+p+cFWWxpNFeH4 EttWs2GDw4g33sRbSr/8q8q8L7PIY8Nh56yomjThPlj9RrqBkcxFgKJm4zNvfANIIezf HO7Th23okT0n9uawG8gXlkiJcMBij6QENJZW6DvTW6n+OWbxgiu85ZZHaDBzBiApn1N5 v0Y+jnugLGI2mdLp7xBPYp8tBuyPanNp3s5daKd4/sB6qXHQ2Fe+cnen6ZiVtduxCM+R CDvSiCBVuaXeMf+AKI5HGhQq0RWmXFpv+TkVJh5WLkrFuyq7eda+j44Mj1qeA6v/el0n OIzw== X-Gm-Message-State: AOJu0Yz7+Hj6FRwszzb9qaTrTHBczTRxCAei8EDjiMi3u6nDAjFkSAAn ZgWVlXbTxHdK66vC4AVswVi6vU5xIQG/PhBhou8XZHxFXbJS6+Hp+U6V5BIzcI6PA26kVWhT9wY = X-Gm-Gg: ASbGnct/WF5bABrb7e1pp14N888X28NIt6UbRIbaOjXzizb+GXeAtDEW6kterz5KyVL OEMNduNjXEhBNskR1coWuY2cYc2IR1T/mrDXU1uSK3dMGzw9W3p4e2ynIfTg4hghZnAVBG8zPyD qXeogKaCetU742NRB4tHp1iKz2zVpcFFahlqEa7gIqnyj22c0SLT/3WwBtgfP0mtWfYx2o0qHBo kCjRuX6kf+pR3t4RyFnKAKWZqT/enJU28gAm4uAYNK9fKAMnpvW+KIZjNH9vPtdsbDgKviC6vGX 4G5HCOtzbpvMxszg3r7JYDnBvWk+B3Y5X0K4nnC52TMTT3rBQnl+L+JvTOA8bH/WshKe/Ytu X-Google-Smtp-Source: AGHT+IHhhjsqgRM+CfpzLDIIcR94FNvO4qgWRM+DHeLW6eFZSZ1NO7UN8m3iBjR73TKFoQahJnLHFA== X-Received: by 2002:a5d:598d:0:b0:385:e013:39ef with SMTP id ffacd0b85a97d-38a221e30aemr46219619f8f.6.1736254468493; Tue, 07 Jan 2025 04:54:28 -0800 (PST) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656af6c42sm631014805e9.9.2025.01.07.04.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 04:54:28 -0800 (PST) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED 27/31] ada: Remove unused AST flag Address_Warning_Posted Date: Tue, 7 Jan 2025 13:53:45 +0100 Message-ID: <20250107125350.619654-27-poulhies@adacore.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250107125350.619654-1-poulhies@adacore.com> References: <20250107125350.619654-1-poulhies@adacore.com> MIME-Version: 1.0 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org From: Piotr Trojanek Flag Address_Warning_Posted was only read and never written, so it can be safely removed. gcc/ada/ChangeLog: * gen_il-fields.ads (Opt_Field_Enum): Remove flag. * gen_il-gen-gen_nodes.adb (N_Attribute_Definition_Clause): Remove field. * sem_ch13.adb (Validate_Address_Clauses): Remove read of the flag. * sinfo.ads (Address_Warning_Posted): Remove flag description. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/gen_il-fields.ads | 1 - gcc/ada/gen_il-gen-gen_nodes.adb | 1 - gcc/ada/sem_ch13.adb | 6 ++---- gcc/ada/sinfo.ads | 6 ------ 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/gcc/ada/gen_il-fields.ads b/gcc/ada/gen_il-fields.ads index fe2da80c548..789fb76875d 100644 --- a/gcc/ada/gen_il-fields.ads +++ b/gcc/ada/gen_il-fields.ads @@ -65,7 +65,6 @@ package Gen_IL.Fields is Activation_Chain_Entity, Acts_As_Spec, Actual_Designated_Subtype, - Address_Warning_Posted, Aggregate_Bounds_Or_Ancestor_Type, Aliased_Present, All_Others, diff --git a/gcc/ada/gen_il-gen-gen_nodes.adb b/gcc/ada/gen_il-gen-gen_nodes.adb index c3a97e6e16e..b361aeeca1d 100644 --- a/gcc/ada/gen_il-gen-gen_nodes.adb +++ b/gcc/ada/gen_il-gen-gen_nodes.adb @@ -98,7 +98,6 @@ begin -- Gen_IL.Gen.Gen_Nodes (Sy (Name, Node_Id, Default_Empty), Sy (Chars, Name_Id, Default_No_Name), Sy (Expression, Node_Id, Default_Empty), - Sm (Address_Warning_Posted, Flag), Sm (Check_Address_Alignment, Flag), Sm (Entity_Or_Associated_Node, Node_Id), -- just Entity Sm (From_Aspect_Specification, Flag), diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb index 2beb6b95daf..00489722921 100644 --- a/gcc/ada/sem_ch13.adb +++ b/gcc/ada/sem_ch13.adb @@ -18055,11 +18055,9 @@ package body Sem_Ch13 is X_Offs : Uint; begin - -- Skip processing of this entry if warning already posted, or if - -- alignments are not set. + -- Skip processing of this entry if alignments are not set - if not Address_Warning_Posted (ACCR.N) - and then Known_Alignment (ACCR.X) + if Known_Alignment (ACCR.X) and then Known_Alignment (ACCR.Y) then Expr := Original_Node (Expression (ACCR.N)); diff --git a/gcc/ada/sinfo.ads b/gcc/ada/sinfo.ads index e9b2f0f3c5c..94bbb2f974e 100644 --- a/gcc/ada/sinfo.ads +++ b/gcc/ada/sinfo.ads @@ -788,11 +788,6 @@ package Sinfo is -- created for the expansion of an allocator with a subtype_indication -- and the designated subtype is an unconstrained composite type. - -- Address_Warning_Posted - -- Present in N_Attribute_Definition nodes. Set to indicate that we have - -- posted a warning for the address clause regarding size or alignment - -- issues. Used to inhibit multiple redundant messages. - -- Aggregate_Bounds -- Present in array N_Aggregate nodes. If the bounds of the aggregate are -- known at compile time, this field points to an N_Range node with those @@ -7549,7 +7544,6 @@ package Sinfo is -- Check_Address_Alignment -- From_Aspect_Specification -- Is_Delayed_Aspect - -- Address_Warning_Posted -- Note: if From_Aspect_Specification is set, then Sloc points to the -- aspect name, and Entity is resolved already to reference the entity