Message ID | 20250107125350.619654-23-poulhies@adacore.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4CF903858283 for <patchwork@sourceware.org>; Tue, 7 Jan 2025 13:39:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CF903858283 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=WLFEtBDT X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 1DA73385B519 for <gcc-patches@gcc.gnu.org>; Tue, 7 Jan 2025 12:54:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DA73385B519 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DA73385B519 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736254467; cv=none; b=db9bTPt8FjC0Yfs5GKLHEmtVv0xIyNiWuMZFJfmH/sxScCpHG2ysueDPrp5zXaMjYQe+LCnpOu5Z227VzHtbKp6wpLsj9pk4JDcGqx2JM2Ji6vyXc6YFGN0btsI0BBVXy4y02/MNy8Ale/SBUPuXpcTONjAnL0MrHkfBTUYWnSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736254467; c=relaxed/simple; bh=YonPLnNecUC/kA1HKmy5otiDAi8MydiDK3gQcBERfzQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=t8BqAtyiln9DAjkggLulupD4XGi2CTBxD48VRz+SU5xMz/Ux6nznziJ0rOaXWM+dx+iML+I2tStOugbII+UT40On/bJEi8zSEXbgWVhAyRrKL+Vde6p2Wt3KSPSKR29Iv5riMhPDMC99kVqzSMjJ0mv33UJtjxGI/qM7we6jp6E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DA73385B519 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43618283dedso153858015e9.3 for <gcc-patches@gcc.gnu.org>; Tue, 07 Jan 2025 04:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1736254466; x=1736859266; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XnVR7Tq++2pbnPOX1lrk15Zmwg/PpVDlNEMC1WFAz+o=; b=WLFEtBDTnrvrtHmXjOrySwlperHAEmfEjNBRe2ZcjtmBDrqFNXBz5YzlVJoNkwmRWa zJH1TzM0ljHpepshbK4Fi//nal9rMLeCjm12ePyzglxixeor0Z+cZ8Bt5yRGC/ZZWYxV gOltg6At4nx9hjV248LP/uFl4wR2bZvi9IAhzPJe2w5Xijb7jM1X4KHc8MyzzZgIhX0z oUeJ7v/frGL0apanCm50q0kAWjupJaKL5RneApLfXonOhEqD1HIkqRmNrPvHbEqEvZrf yePG/ZWJEwVWoEFZvtDcQIOMeDFCwFwzKrKlLcH0PrZNon4jC3N+DsistlGE5DPGqWkI BZRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736254466; x=1736859266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XnVR7Tq++2pbnPOX1lrk15Zmwg/PpVDlNEMC1WFAz+o=; b=tr+qJ0bm+57MjAtgFVZOwvaqnK3iGQqC+W/dg3iWuldPcEDPaM3EaJBDwBmHDHGoqk DvyZqA9m09WXCkNYv6Fgfl9c3z/FmnsKfWFxwIjgmGAPBfU3VRDRvQsVVhqZHE5zyfRn u5le6gmCHnIiptkKNUE3TndXGLGRPN8vzrBTlHbMLPwgbRrzbvdobbiunkc8WpS3rwZM mxcMgkNpcqsFYBe7LOB9z0QcZYIzDFoUXbvBCoJKAyIdJwJ9ug5JNt6K+fLFg8bcvOF/ yZt+N/na0w+/egcKipwA/RFbKF35n4MCI30hJD2+HNYsVjUmDYwMz1p8iyJdQFXu7dyZ TGeQ== X-Gm-Message-State: AOJu0YzrqGo1tFZLhswDHaKBksy4MF1UkrZqBHpW0k8bcbzdpLrr/wb0 jwYu+GSEmKXUNJ5yVRUKGNRvAdww9C0/dLOZp5LTzX8VntBBhJqdAmbGNhfAsn4xSa0v5L6ePpo = X-Gm-Gg: ASbGncs8Mg1y+jn2c8svRyPirT+NaUUM95wmTr2hMcOLJGFCGz63WuAZm7hOImr1Xc1 D7NvNlIl+XQbGQhHonSThZVlpxZTh2TEBCzoD3Ku0zjRYzykAKY3rNiqzd25SyFCifxlMvA6kAJ 4ecXfIMJnKKQucnHKiNfR61eDxG5tt2G5v5Jza8IhaDcmiAbxjFblf3RHtCDqIR/ENnG3CBJLQd 4q29ZqebPxZbhjK5d3yOiNdvW+B+oxtR/A4WHBn5TbeCuqeDarRUU0eSrQZGbyZ1edGcPwb71No POQVBt5sAq/+WzX8R+Y45RXuXICsLpU3/Z/eCbkQxZUmqiSQyjIdFJf2Jkvn39+HATU/Nh6a X-Google-Smtp-Source: AGHT+IGfdJWNKbvEI4aqOONYNv//gzFcR89+oKndhbZgvFFURcNQ0HxB/oPiVXoZ/EYghHjXxW8f6w== X-Received: by 2002:a05:600c:4511:b0:431:44f6:566f with SMTP id 5b1f17b1804b1-43668642d71mr517130995e9.13.1736254465736; Tue, 07 Jan 2025 04:54:25 -0800 (PST) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656af6c42sm631014805e9.9.2025.01.07.04.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 04:54:25 -0800 (PST) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= <poulhies@adacore.com> To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek <trojanek@adacore.com> Subject: [COMMITTED 23/31] ada: Improve protection against wrong use from GDB Date: Tue, 7 Jan 2025 13:53:41 +0100 Message-ID: <20250107125350.619654-23-poulhies@adacore.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250107125350.619654-1-poulhies@adacore.com> References: <20250107125350.619654-1-poulhies@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
[COMMITTED,01/31] ada: Restrict previous change made to expansion of allocators
|
|
Commit Message
Marc Poulhiès
Jan. 7, 2025, 12:53 p.m. UTC
From: Piotr Trojanek <trojanek@adacore.com>
A code cleanup in routine intended to be used from DGB, suggested by running
GNATcheck rule Boolean_Negations. However, this code can be tuned to protect
against more illegal uses.
gcc/ada/ChangeLog:
* exp_disp.adb (Write_DT): Add guards that prevent crashes on illegal
node numbers.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/exp_disp.adb | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gcc/ada/exp_disp.adb b/gcc/ada/exp_disp.adb index f45c32356a9..6d0f2c87017 100644 --- a/gcc/ada/exp_disp.adb +++ b/gcc/ada/exp_disp.adb @@ -8674,9 +8674,10 @@ package body Exp_Disp is begin -- Protect this procedure against wrong usage. Required because it will - -- be used directly from GDB + -- be used directly from GDB. - if not (Typ <= Last_Node_Id) + if Typ not in First_Node_Id .. Last_Node_Id + or else Nkind (Typ) not in N_Entity or else not Is_Tagged_Type (Typ) then Write_Str ("wrong usage: Write_DT must be used with tagged types");