From patchwork Wed Dec 4 04:49:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 102350 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 145053858C60 for ; Wed, 4 Dec 2024 05:16:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 145053858C60 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=EEGz4thq X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id E25463858CDA for ; Wed, 4 Dec 2024 05:08:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E25463858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E25463858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::833 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733288895; cv=none; b=XZlKEJfbcmvOhS+3lTveZ6QDxO9Q4UJ6pXM1zNRTOgohTlaQYI0JGAORVHTt6kTMhYt2v/tci7fkPOlQzHdhhUCNvyB70cnyk3SEJ/yQK4MBv4pjzvA9LIyEPJeg2lvSicmChcNwlEcKOWKr819iIsTYpvKU8Ap3hduK6/j8+oU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733288895; c=relaxed/simple; bh=BtI0jYeAv3glVaFlZUFBbSQlaXXJC+gCvxTjLJ/lO7Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DLV0DHdtWIu/VBACzJ/fGqI8CxUbE4qbCH0NB2gLNHpYrZ/LVnpD9RzOOZnEEd3SyEpA136hKSz+zbQ4hjlyyCh/VP/9W7BatmomTA8mD1kP1JVjYPPYMw0SPFg9Z3W9PWeZ5M8EKE4WD+VbqcJLyPE9jAveTGA8sfEC2Hf+dNc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E25463858CDA Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4668486dec2so46625191cf.3 for ; Tue, 03 Dec 2024 21:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733288894; x=1733893694; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OVXxM3iHd4CA8fTo5B5TQsY0LjDBzx5cBkcXRsR2wd8=; b=EEGz4thqpeJZLR6iew8pdjlbOC5gS7izUVBCIt0gATwZEqdMiEbs1yHUfZSJmDBBiw riivO+u3mEzkn70p5oGqZiGItV36rii8mwEJmAw8cHEk2iL42IEknn5pvcO9Qg/vi5lH gO48uwrSG+eC/q5kqCyI3nGX1JqKQJq0h83k308r2jpJnJTPFrlcHHyqSnxwlgjowYPg qdU4RA32yGJjK4J9/Frw5c7nzSWgvSR4NAE1EVqzJZ36bfU+gjq6vjPmYhwdbO1Qk+MN d4i4Im1wAjd59d+huXf3y3HiblqLSWUvQiSNHVJSW4cRuNeMLt+9IchibbOp/juFlxSE 1dkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733288894; x=1733893694; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OVXxM3iHd4CA8fTo5B5TQsY0LjDBzx5cBkcXRsR2wd8=; b=iIyy+9+HABFfhgzpQ9E6VoF8T0V6Y4MO2UZ0iNzmUL+K/qYBKtXGL+TaUfQuf0iPYD 1ElX+oWTQZYz4dInvJb4D99E5s4MwFRflcqOQWkSZpETt+320Ry441++3iP1spiqUEPM Q5wwUX5ges83KAsy7G1gEr0I005L6UNTzKqEUj+llWagHARSVy9/gPXF5F5n+ksGqmrD Tnu0IF9zZVL0t83hjCD66PeGpn9sBij71oUYeNBMm5/2vxmk6Ij2wip7ArZmDQv+zVkB GVWjbOFX2gSojnw+KB/SDPCLcNLAFw/2r7uHz1QRTqw4o2PWqoGxCEAg6Q+G+sBhNYaR d4Pg== X-Gm-Message-State: AOJu0YyMmOnwqo7BIrH8exlMN3V5lYMZRfPIcsKLDOsBRe4n3Hgci5dQ J2Pbnm0SbNCKDK9scCc5QNQ7KhlnVv+Q5n9k1iOatbXVIepvrzEF X-Gm-Gg: ASbGncvmXY/Fi2FSZbb8y2x1EG5YaUfKdGJRjX0P2SvQO0+Su5b4WjY5WDUASVdD0br 8zopXOwdC349TsYP786C1Hv7Wd2h+rRbUd5YntYHhuyrIlw/FHpmzahcO6qEALIqS6weW2ugeY0 dvme8vrA8GxMKm8edjfCnpqVxeJdRoEbVRKmZ7+uS5KQBxgtniHLQ1A/7W+ffMH5HthrfB6jcdJ M8lpBb8UUZPlIMUZW5TlfSWIo9PXxXSDP80DThrhBu5SyjSX5T44zbP4Eq54DxrnsomZ6T99T9k sT+DnMynmkOHkLCDcKasNgIiPqt4aP4DLCTiQw== X-Google-Smtp-Source: AGHT+IHiowvNOCCA+dgA81fbt4AKrN8/KtRvOF/z5kvPqGJrawdDsKHXN5XAtsHOgWA12VTTwmuwFw== X-Received: by 2002:ac8:7f0f:0:b0:466:ac58:df71 with SMTP id d75a77b69052e-4670c072e5dmr70418161cf.7.1733288893870; Tue, 03 Dec 2024 21:08:13 -0800 (PST) Received: from gnu-tgl-3.localdomain ([172.58.160.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-466c42319aasm69692751cf.72.2024.12.03.21.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 21:08:13 -0800 (PST) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id BF0BBC06D9; Wed, 04 Dec 2024 12:49:51 +0800 (CST) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: richard.guenther@gmail.com, jeffreyalaw@gmail.com, jakub@redhat.com, richard.sandiford@arm.com, matz@suse.de Subject: [PATCH v5 4/7] i386: Adjust apx-ndd.c for frontend promotion removal Date: Wed, 4 Dec 2024 12:49:48 +0800 Message-ID: <20241204044951.509713-5-hjl.tools@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241204044951.509713-1-hjl.tools@gmail.com> References: <20241204044951.509713-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Since the C frontend no longer promotes integer argument smaller than int, the apx-ndd.c codgen is slightly different: apx-ndd.s (original) 2024-11-10 06:07:09.894876973 +0800 apx-ndd.s (updated) 2024-11-10 06:06:59.371860565 +0800 @@ -17,7 +17,7 @@ foo_add_char: foo1_add_char: .LFB1: .cfi_startproc - leal (%rsi,%rdi), %eax + leal (%rdi,%rsi), %eax ret .cfi_endproc .LFE1: @@ -50,7 +50,7 @@ foo_add_short: foo1_add_short: .LFB4: .cfi_startproc - leal (%rsi,%rdi), %eax + leal (%rdi,%rsi), %eax ret .cfi_endproc .LFE4: @@ -413,7 +413,7 @@ foo_and_char: foo1_and_char: .LFB37: .cfi_startproc - andl %edi, %esi, %eax + andl %esi, %edi, %eax ret .cfi_endproc .LFE37: @@ -435,7 +435,7 @@ foo_and_short: foo1_and_short: .LFB39: .cfi_startproc - andl %edi, %esi, %eax + andl %esi, %edi, %eax ret .cfi_endproc .LFE39: @@ -501,7 +501,7 @@ foo_or_char: foo1_or_char: .LFB45: .cfi_startproc - orl %edi, %esi, %eax + orl %esi, %edi, %eax ret .cfi_endproc .LFE45: @@ -523,7 +523,7 @@ foo_or_short: foo1_or_short: .LFB47: .cfi_startproc - orl %edi, %esi, %eax + orl %esi, %edi, %eax ret .cfi_endproc .LFE47: @@ -589,7 +589,7 @@ foo_xor_char: foo1_xor_char: .LFB53: .cfi_startproc - xorl %edi, %esi, %eax + xorl %esi, %edi, %eax ret .cfi_endproc .LFE53: @@ -611,7 +611,7 @@ foo_xor_short: foo1_xor_short: .LFB55: .cfi_startproc - xorl %edi, %esi, %eax + xorl %esi, %edi, %eax ret .cfi_endproc .LFE55: @@ -1018,7 +1018,7 @@ foo4_rol_uint64_t: foo1_imul_short: .LFB92: .cfi_startproc - imull %edi, %esi, %eax + imull %esi, %edi, %eax ret .cfi_endproc .LFE92: Adjust the assembler scans. PR middle-end/14907 * gcc.target/i386/apx-ndd.c: Adjusted. Signed-off-by: H.J. Lu --- gcc/testsuite/gcc.target/i386/apx-ndd.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/gcc.target/i386/apx-ndd.c b/gcc/testsuite/gcc.target/i386/apx-ndd.c index ce77630a47c..2b2f4fc4b0f 100644 --- a/gcc/testsuite/gcc.target/i386/apx-ndd.c +++ b/gcc/testsuite/gcc.target/i386/apx-ndd.c @@ -188,16 +188,13 @@ FOO2 (int64_t, imul, *) /* { dg-final { scan-assembler-times "not(?:l|w|q)\[^\n\r]%(?:|r|e)di, %(?:|r|e)ax" 4 } } */ /* { dg-final { scan-assembler-times "andb\[^\n\r]*1, \\(%(?:r|e)di\\), %al" 1 } } */ /* { dg-final { scan-assembler-times "and(?:l|w|q)\[^\n\r]*1, \\(%(?:r|e)di\\), %(?:|r|e)ax" 3 } } */ -/* { dg-final { scan-assembler-times "and(?:l|w|q)\[^\n\r]%(?:|r|e)di, %(?:|r|e)si, %(?:|r|e)ax" 2 } } */ -/* { dg-final { scan-assembler-times "and(?:l|w|q)\[^\n\r]%(?:|r|e)si, %(?:|r|e)di, %(?:|r|e)ax" 2 } } */ +/* { dg-final { scan-assembler-times "and(?:l|w|q)\[^\n\r]%(?:|r|e)si, %(?:|r|e)di, %(?:|r|e)ax" 4 } } */ /* { dg-final { scan-assembler-times "orb\[^\n\r]*1, \\(%(?:r|e)di\\), %al" 2} } */ /* { dg-final { scan-assembler-times "or(?:l|w|q)\[^\n\r]*1, \\(%(?:r|e)di\\), %(?:|r|e)ax" 6 } } */ -/* { dg-final { scan-assembler-times "or(?:l|w|q)\[^\n\r]%(?:|r|e)di, %(?:|r|e)si, %(?:|r|e)ax" 4 } } */ -/* { dg-final { scan-assembler-times "or(?:l|w|q)\[^\n\r]%(?:|r|e)si, %(?:|r|e)di, %(?:|r|e)ax" 4 } } */ +/* { dg-final { scan-assembler-times "or(?:l|w|q)\[^\n\r]%(?:|r|e)si, %(?:|r|e)di, %(?:|r|e)ax" 8 } } */ /* { dg-final { scan-assembler-times "xorb\[^\n\r]*1, \\(%(?:r|e)di\\), %al" 1 } } */ /* { dg-final { scan-assembler-times "xor(?:l|w|q)\[^\n\r]*1, \\(%(?:r|e)di\\), %(?:|r|e)ax" 3 } } */ -/* { dg-final { scan-assembler-times "xor(?:l|w|q)\[^\n\r]%(?:|r|e)di, %(?:|r|e)si, %(?:|r|e)ax" 2 } } */ -/* { dg-final { scan-assembler-times "xor(?:l|w|q)\[^\n\r]%(?:|r|e)si, %(?:|r|e)di, %(?:|r|e)ax" 2 } } */ +/* { dg-final { scan-assembler-times "xor(?:l|w|q)\[^\n\r]%(?:|r|e)si, %(?:|r|e)di, %(?:|r|e)ax" 4 } } */ /* { dg-final { scan-assembler-times "sal(?:b|l|w|q)\[^\n\r]*1, \\(%(?:r|e)di\\), %(?:|r|e)a(?:x|l)" 4 } } */ /* { dg-final { scan-assembler-times "sal(?:l|w|q)\[^\n\r]*7, %(?:|r|e)di, %(?:|r|e)ax" 4 } } */ /* { dg-final { scan-assembler-times "sar(?:b|l|w|q)\[^\n\r]*1, \\(%(?:r|e)di\\), %(?:|r|e)a(?:x|l)" 4 } } */