Message ID | 20241129091628.1200006-1-quic_apinski@quicinc.com |
---|---|
State | Committed |
Commit | 48b72743b0e29871171593fe34856da62d954750 |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A6283858CD1 for <patchwork@sourceware.org>; Fri, 29 Nov 2024 09:19:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A6283858CD1 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=OS1aOF+7 X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id 8D29E3858CDB; Fri, 29 Nov 2024 09:16:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D29E3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D29E3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732871814; cv=none; b=vaMMK1L9/QmKugUfSYV2n9tqVkTvuCjK12ERiphp+s5Mgr8J+BqDSNs5gS3l9sHshQomS0qbtIuXK7DUBckpePOUxd88KoGPSH3HkLQ3U4RuDxrGsYuKMTuxAczW+Bcro5Dubdh1GZl2yq7Vq/xih2024vLiYMgi0bFWErkOv1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732871814; c=relaxed/simple; bh=jmAzZC6qAhj9rAGu1TFSf08p67/ouV/6y+YMJQPrtRA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wxdBifPItq6hA4P5AkJkQQh/C14mv9ifFWHwhVFX+8VRhrSVRJX4SxrvH3kxhwWp3+Hh42N/5Wj/Sx5CC3WuFOaezvNFComnGbJWFC6FfP3aXUAavzlSKzhNEkj41fF1XQ5RMQi6RRHvgmrxfwdAtFCr5FIf7f3syVXHWb6ruok= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D29E3858CDB Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AT0Dbi0022049; Fri, 29 Nov 2024 09:16:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=YxN5vK6l9F/3gN+qbaTm66 Hc7gYkWqVzHB+lq8wto6M=; b=OS1aOF+7aThRAhmnrOROp7b9i3cFEVDoTXHPIN IclsrrZVu5mMjgTSTM61pOl2nwjkdJR4We6kzyBe01y+5URirvBBghrsYbbcdErx T1qWGXfiKteftOc/M/cp9FiPqeB6PXFQi0LK7UZyJyxewRroNWyjiub1xhqSZSlj 8cTlCzF94Mjt6lHGL0rMWff5BzXtRADhBPsURv8tyRVjSpOf1hnX4SlCFxyZSbCE XoNbeItwRLBqwR3sNxL9PZo7yRloYDMgGmJHgtTHJiSOEJQkF2LWaZRmAkcOZO55 cYVvl6EvVsNyNnMQ9SMnx/KOiYBuIIZkOSzJC0ZsnuEKpD5w== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4366xw52f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Nov 2024 09:16:53 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AT9Gqj1023208 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Nov 2024 09:16:52 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 29 Nov 2024 01:16:52 -0800 From: Andrew Pinski <quic_apinski@quicinc.com> To: <gcc-patches@gcc.gnu.org>, <fortran@gcc.gnu.org> CC: Andrew Pinski <quic_apinski@quicinc.com> Subject: [PUSHED] fortran: Add default to switch in gfc_trans_transfer [PR117843] Date: Fri, 29 Nov 2024 01:16:28 -0800 Message-ID: <20241129091628.1200006-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: dF8tvF2gzyQkvkdpsfbp2m6QI88THpuo X-Proofpoint-ORIG-GUID: dF8tvF2gzyQkvkdpsfbp2m6QI88THpuo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1011 mlxlogscore=853 phishscore=0 adultscore=0 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2411290075 X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
[PUSHED] fortran: Add default to switch in gfc_trans_transfer [PR117843]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_gcc_build--master-arm | fail | Patch failed to apply |
Commit Message
Andrew Pinski
Nov. 29, 2024, 9:16 a.m. UTC
This fixes a bootstrap failure due to a warning on enum values not being
handled. In this case, it is just checking two values and the rest should
are not handled so adding a default case fixes the issue.
Pushed as obvious.
PR fortran/117843
gcc/fortran/ChangeLog:
* trans-io.cc (gfc_trans_transfer): Add default case.
Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
---
gcc/fortran/trans-io.cc | 2 ++
1 file changed, 2 insertions(+)
Comments
Thanks, Andrew, for fixing this! I did not get any reports from the pre-commit testers; I only saw the fallout later. And sorry for breaking bootstrap! Harald Am 29.11.24 um 10:16 schrieb Andrew Pinski: > This fixes a bootstrap failure due to a warning on enum values not being > handled. In this case, it is just checking two values and the rest should > are not handled so adding a default case fixes the issue. > > Pushed as obvious. > > PR fortran/117843 > gcc/fortran/ChangeLog: > > * trans-io.cc (gfc_trans_transfer): Add default case. > > Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> > --- > gcc/fortran/trans-io.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/fortran/trans-io.cc b/gcc/fortran/trans-io.cc > index 906dd7c6eb6..9b0b8cfdff9 100644 > --- a/gcc/fortran/trans-io.cc > +++ b/gcc/fortran/trans-io.cc > @@ -2664,6 +2664,8 @@ gfc_trans_transfer (gfc_code * code) > case EXPR_FUNCTION: > case EXPR_OP: > goto scalarize; > + default: > + break; > } > } > }
diff --git a/gcc/fortran/trans-io.cc b/gcc/fortran/trans-io.cc index 906dd7c6eb6..9b0b8cfdff9 100644 --- a/gcc/fortran/trans-io.cc +++ b/gcc/fortran/trans-io.cc @@ -2664,6 +2664,8 @@ gfc_trans_transfer (gfc_code * code) case EXPR_FUNCTION: case EXPR_OP: goto scalarize; + default: + break; } } }