diff mbox series

testsuite: arm: Use effective-target for nomve_fp_1 test

Message ID 20241031183007.3072536-1-torbjorn.svensson@foss.st.com
State Committed
Commit e8886406fac50f80a521a4100a80517e50e1c388
Delegated to: Christophe Lyon
Headers
Series testsuite: arm: Use effective-target for nomve_fp_1 test |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Torbjorn SVENSSON Oct. 31, 2024, 6:30 p.m. UTC 
  Ok for trunk and releases/gcc-14?

--

Test uses MVE, so add effective-target arm_fp requirement.

gcc/testsuite/ChangeLog:

	* g++.target/arm/mve/general-c++/nomve_fp_1.c: Use
	effective-target arm_fp.

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
 gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Christophe Lyon Nov. 7, 2024, 10:40 a.m. UTC | #1 
Hi Torbjörn,

On Thu, 31 Oct 2024 at 19:34, Torbjörn SVENSSON
<torbjorn.svensson@foss.st.com> wrote:
>
> Ok for trunk and releases/gcc-14?
>
> --
>
> Test uses MVE, so add effective-target arm_fp requirement.
>
> gcc/testsuite/ChangeLog:
>
>         * g++.target/arm/mve/general-c++/nomve_fp_1.c: Use
>         effective-target arm_fp.
>
I see I made a similar change to the corresponding "C" test:
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624404.html

Is your patch fixing the same issue?

Thanks,

Christophe

> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
>  gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
> index e0692ceb8c8..a2069d353cf 100644
> --- a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
> +++ b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
> @@ -1,9 +1,11 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target arm_fp_ok } */
>  /* { dg-require-effective-target arm_v8_1m_mve_ok } */
>  /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
>     which could imply mve+fp depending on the user settings. We want to make
>     sure the '+fp' extension is not enabled.  */
>  /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
> +/* { dg-add-options arm_fp } */
>
>  #include <arm_mve.h>
>
> --
> 2.25.1
>
Torbjorn SVENSSON Nov. 7, 2024, 5:32 p.m. UTC | #2 
On 2024-11-07 11:40, Christophe Lyon wrote:
> Hi Torbjörn,
> 
> On Thu, 31 Oct 2024 at 19:34, Torbjörn SVENSSON
> <torbjorn.svensson@foss.st.com> wrote:
>>
>> Ok for trunk and releases/gcc-14?
>>
>> --
>>
>> Test uses MVE, so add effective-target arm_fp requirement.
>>
>> gcc/testsuite/ChangeLog:
>>
>>          * g++.target/arm/mve/general-c++/nomve_fp_1.c: Use
>>          effective-target arm_fp.
>>
> I see I made a similar change to the corresponding "C" test:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624404.html
> 
> Is your patch fixing the same issue?

Yes, it looks like it's the same issue (and resolution).

Kind regards,
Torbjörn

> 
> Thanks,
> 
> Christophe
> 
>> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
>> ---
>>   gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
>> index e0692ceb8c8..a2069d353cf 100644
>> --- a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
>> +++ b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
>> @@ -1,9 +1,11 @@
>>   /* { dg-do compile } */
>> +/* { dg-require-effective-target arm_fp_ok } */
>>   /* { dg-require-effective-target arm_v8_1m_mve_ok } */
>>   /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
>>      which could imply mve+fp depending on the user settings. We want to make
>>      sure the '+fp' extension is not enabled.  */
>>   /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
>> +/* { dg-add-options arm_fp } */
>>
>>   #include <arm_mve.h>
>>
>> --
>> 2.25.1
>>
Christophe Lyon Nov. 7, 2024, 10:19 p.m. UTC | #3 
On Thu, 7 Nov 2024 at 18:33, Torbjorn SVENSSON
<torbjorn.svensson@foss.st.com> wrote:
>
>
>
> On 2024-11-07 11:40, Christophe Lyon wrote:
> > Hi Torbjörn,
> >
> > On Thu, 31 Oct 2024 at 19:34, Torbjörn SVENSSON
> > <torbjorn.svensson@foss.st.com> wrote:
> >>
> >> Ok for trunk and releases/gcc-14?
> >>
> >> --
> >>
> >> Test uses MVE, so add effective-target arm_fp requirement.
> >>
> >> gcc/testsuite/ChangeLog:
> >>
> >>          * g++.target/arm/mve/general-c++/nomve_fp_1.c: Use
> >>          effective-target arm_fp.
> >>
> > I see I made a similar change to the corresponding "C" test:
> > https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624404.html
> >
> > Is your patch fixing the same issue?
>
> Yes, it looks like it's the same issue (and resolution).
>
Thanks for confirming. The patch is OK.

Thanks,

Christophe

> Kind regards,
> Torbjörn
>
> >
> > Thanks,
> >
> > Christophe
> >
> >> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> >> ---
> >>   gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
> >> index e0692ceb8c8..a2069d353cf 100644
> >> --- a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
> >> +++ b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
> >> @@ -1,9 +1,11 @@
> >>   /* { dg-do compile } */
> >> +/* { dg-require-effective-target arm_fp_ok } */
> >>   /* { dg-require-effective-target arm_v8_1m_mve_ok } */
> >>   /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
> >>      which could imply mve+fp depending on the user settings. We want to make
> >>      sure the '+fp' extension is not enabled.  */
> >>   /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
> >> +/* { dg-add-options arm_fp } */
> >>
> >>   #include <arm_mve.h>
> >>
> >> --
> >> 2.25.1
> >>
>
Torbjorn SVENSSON Nov. 8, 2024, 9 a.m. UTC | #4 
On 2024-11-07 23:19, Christophe Lyon wrote:
> On Thu, 7 Nov 2024 at 18:33, Torbjorn SVENSSON
> <torbjorn.svensson@foss.st.com> wrote:
>>
>>
>>
>> On 2024-11-07 11:40, Christophe Lyon wrote:
>>> Hi Torbjörn,
>>>
>>> On Thu, 31 Oct 2024 at 19:34, Torbjörn SVENSSON
>>> <torbjorn.svensson@foss.st.com> wrote:
>>>>
>>>> Ok for trunk and releases/gcc-14?
>>>>
>>>> --
>>>>
>>>> Test uses MVE, so add effective-target arm_fp requirement.
>>>>
>>>> gcc/testsuite/ChangeLog:
>>>>
>>>>           * g++.target/arm/mve/general-c++/nomve_fp_1.c: Use
>>>>           effective-target arm_fp.
>>>>
>>> I see I made a similar change to the corresponding "C" test:
>>> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624404.html
>>>
>>> Is your patch fixing the same issue?
>>
>> Yes, it looks like it's the same issue (and resolution).
>>
> Thanks for confirming. The patch is OK.

Pushed as r15-5035-ge8886406fac and r14.2.0-372-gef771933842.

Kind regards,
Torbjörn

> 
> Thanks,
> 
> Christophe
> 
>> Kind regards,
>> Torbjörn
>>
>>>
>>> Thanks,
>>>
>>> Christophe
>>>
>>>> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
>>>> ---
>>>>    gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
>>>> index e0692ceb8c8..a2069d353cf 100644
>>>> --- a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
>>>> +++ b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
>>>> @@ -1,9 +1,11 @@
>>>>    /* { dg-do compile } */
>>>> +/* { dg-require-effective-target arm_fp_ok } */
>>>>    /* { dg-require-effective-target arm_v8_1m_mve_ok } */
>>>>    /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
>>>>       which could imply mve+fp depending on the user settings. We want to make
>>>>       sure the '+fp' extension is not enabled.  */
>>>>    /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
>>>> +/* { dg-add-options arm_fp } */
>>>>
>>>>    #include <arm_mve.h>
>>>>
>>>> --
>>>> 2.25.1
>>>>
>>
diff mbox series

Patch

diff --git a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
index e0692ceb8c8..a2069d353cf 100644
--- a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
+++ b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
@@ -1,9 +1,11 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target arm_fp_ok } */
 /* { dg-require-effective-target arm_v8_1m_mve_ok } */
 /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
    which could imply mve+fp depending on the user settings. We want to make
    sure the '+fp' extension is not enabled.  */
 /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
+/* { dg-add-options arm_fp } */
 
 #include <arm_mve.h>