diff mbox series

testsuite: arm: Force hard ABI for pr51534.c test

Message ID 20241031182417.3072005-1-torbjorn.svensson@foss.st.com
State Committed
Commit e995866cff2866512cd3af24b6ca27a5782aca1f
Headers
Series testsuite: arm: Force hard ABI for pr51534.c test |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Torbjorn SVENSSON Oct. 31, 2024, 6:24 p.m. UTC 
  Ok for trunk and releases/gcc-14?

--

The test case is written in a way that it should be using hard float
ABI, but the use of -mfloat-abi=hard could be overriden by
dg-add-options arm_neon. Ensure that -mfloat-abi=hard is always after.

gcc/testsuite/ChangeLog:

	* gcc.target/arm/pr51534.c: Ensure -mfloat-abi=hard is used.

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
 gcc/testsuite/gcc.target/arm/pr51534.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Richard Earnshaw (lists) Nov. 4, 2024, 3:51 p.m. UTC | #1 
On 31/10/2024 18:24, Torbjörn SVENSSON wrote:
> Ok for trunk and releases/gcc-14?
> 
> --
> 
> The test case is written in a way that it should be using hard float
> ABI, but the use of -mfloat-abi=hard could be overriden by
> dg-add-options arm_neon. Ensure that -mfloat-abi=hard is always after.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/arm/pr51534.c: Ensure -mfloat-abi=hard is used.
> 
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>

OK

R.
Torbjorn SVENSSON Nov. 4, 2024, 7:28 p.m. UTC | #2 
On 2024-11-04 16:51, Richard Earnshaw (lists) wrote:
> On 31/10/2024 18:24, Torbjörn SVENSSON wrote:
>> Ok for trunk and releases/gcc-14?
>>
>> --
>>
>> The test case is written in a way that it should be using hard float
>> ABI, but the use of -mfloat-abi=hard could be overriden by
>> dg-add-options arm_neon. Ensure that -mfloat-abi=hard is always after.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 	* gcc.target/arm/pr51534.c: Ensure -mfloat-abi=hard is used.
>>
>> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> 
> OK

Pushed as r15-4932-ge995866cff2 and r14.2.0-356-g7cc64ea4961.

Kind regards,
Torbjörn
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/arm/pr51534.c b/gcc/testsuite/gcc.target/arm/pr51534.c
index ba21259bee5..b68ecce2639 100644
--- a/gcc/testsuite/gcc.target/arm/pr51534.c
+++ b/gcc/testsuite/gcc.target/arm/pr51534.c
@@ -3,8 +3,9 @@ 
 
 /* { dg-do assemble { target { arm_hard_ok } } } */
 /* { dg-require-effective-target arm_neon_ok } */
-/* { dg-options "-save-temps -mfloat-abi=hard -O3" } */
+/* { dg-options "-save-temps -O3" } */
 /* { dg-add-options arm_neon } */
+/* { dg-additional-options "-mfloat-abi=hard" } */
 
 #include <arm_neon.h>