libobjc: Fix typos

Message ID 20240920084032.9876-1-algonell@gmail.com
State New
Headers
Series libobjc: Fix typos |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Andrew Kreimer Sept. 20, 2024, 8:40 a.m. UTC
  Fix typos in comments.

Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 libobjc/Makefile.in              | 2 +-
 libobjc/configure                | 2 +-
 libobjc/encoding.c               | 4 ++--
 libobjc/exception.c              | 4 ++--
 libobjc/hash.c                   | 2 +-
 libobjc/init.c                   | 2 +-
 libobjc/objc-private/objc-list.h | 2 +-
 libobjc/sendmsg.c                | 2 +-
 libobjc/thr.c                    | 2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)
  

Comments

Andrew Pinski Sept. 23, 2024, 7:47 p.m. UTC | #1
On Fri, Sep 20, 2024 at 1:41 AM Andrew Kreimer <algonell@gmail.com> wrote:
>
> Fix typos in comments.

OK. Do you have push access or need someone to push it for you?

Thanks,
Andrew

>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
>  libobjc/Makefile.in              | 2 +-
>  libobjc/configure                | 2 +-
>  libobjc/encoding.c               | 4 ++--
>  libobjc/exception.c              | 4 ++--
>  libobjc/hash.c                   | 2 +-
>  libobjc/init.c                   | 2 +-
>  libobjc/objc-private/objc-list.h | 2 +-
>  libobjc/sendmsg.c                | 2 +-
>  libobjc/thr.c                    | 2 +-
>  9 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/libobjc/Makefile.in b/libobjc/Makefile.in
> index 58d0638f72e..3d856eb8d5f 100644
> --- a/libobjc/Makefile.in
> +++ b/libobjc/Makefile.in
> @@ -59,7 +59,7 @@ MULTIDO = true
>  MULTICLEAN = true
>
>  # Not configured per top-level version, since that doesn't get passed
> -# down at configure time, but overrridden by the top-level install
> +# down at configure time, but overridden by the top-level install
>  # target.
>  INSTALL = @INSTALL@
>  INSTALL_PROGRAM = @INSTALL_PROGRAM@
> diff --git a/libobjc/configure b/libobjc/configure
> index 68172549137..5f4c928d2bf 100755
> --- a/libobjc/configure
> +++ b/libobjc/configure
> @@ -13935,7 +13935,7 @@ func_basename ()
>  #             to NONDIR_REPLACEMENT.
>  #             value returned in "$func_dirname_result"
>  #   basename: Compute filename of FILE.
> -#             value retuned in "$func_basename_result"
> +#             value returned in "$func_basename_result"
>  # Implementation must be kept synchronized with func_dirname
>  # and func_basename. For efficiency, we do not delegate to
>  # those functions but instead duplicate the functionality here.
> diff --git a/libobjc/encoding.c b/libobjc/encoding.c
> index 7a2d2abe6d1..f4fc4f452e4 100644
> --- a/libobjc/encoding.c
> +++ b/libobjc/encoding.c
> @@ -151,7 +151,7 @@ static int __attribute__ ((__unused__)) not_target_flags = 0;
>  #  undef TARGET_ALIGN_NATURAL
>  #  define TARGET_ALIGN_NATURAL 1
>  # endif
> -/* On Darwin32, we need to recurse until we find the starting stuct type.  */
> +/* On Darwin32, we need to recurse until we find the starting struct type.  */
>  static int
>  _darwin_rs6000_special_round_type_align (const char *struc, int comp, int spec)
>  {
> @@ -186,7 +186,7 @@ _darwin_rs6000_special_round_type_align (const char *struc, int comp, int spec)
>
>  /*  FIXME: while this file has no business including tm.h, this
>      definitely has no business defining this macro but it
> -    is only way around without really rewritting this file,
> +    is only way around without really rewriting this file,
>      should look after the branch of 3.4 to fix this.   */
>  #define rs6000_special_round_type_align(STRUCT, COMPUTED, SPECIFIED)   \
>    ({ const char *_fields = TYPE_FIELDS (STRUCT);                       \
> diff --git a/libobjc/exception.c b/libobjc/exception.c
> index f051c5f9524..dce576e8559 100644
> --- a/libobjc/exception.c
> +++ b/libobjc/exception.c
> @@ -42,7 +42,7 @@ is_kind_of_exception_matcher (Class catch_class, id exception)
>      return 1;
>
>    /* If exception is nil (eg, @throw nil;), then it can only be
> -     catched by a catch-all (eg, @catch (id object)).  */
> +     caught by a catch-all (eg, @catch (id object)).  */
>    if (exception != nil)
>      {
>        Class c;
> @@ -384,7 +384,7 @@ PERSONALITY_FUNCTION (int version,
>  #endif /* __USING_SJLJ_EXCEPTIONS__  */
>
>    /* If ip is not present in the table, C++ would call terminate.  */
> -  /* ??? As with Java, it's perhaps better to tweek the LSDA to that
> +  /* ??? As with Java, it's perhaps better to tweak the LSDA to that
>       no-action is mapped to no-entry.  */
>    CONTINUE_UNWINDING;
>
> diff --git a/libobjc/hash.c b/libobjc/hash.c
> index e216c8cdf3b..e0ecf30e024 100644
> --- a/libobjc/hash.c
> +++ b/libobjc/hash.c
> @@ -222,7 +222,7 @@ objc_hash_next (cache_ptr cache, node_ptr node)
>        if (node->next)
>         {
>           /* There is a node which follows the last node returned.
> -            Step to that node and retun it.  */
> +            Step to that node and return it.  */
>           return node->next;
>         }
>        else
> diff --git a/libobjc/init.c b/libobjc/init.c
> index 6216546084b..9f8bafb8ee3 100644
> --- a/libobjc/init.c
> +++ b/libobjc/init.c
> @@ -851,7 +851,7 @@ __objc_create_classes_tree (struct objc_module *module)
>
>    /* Now iterate over "claimed" categories too (ie, categories that
>       extend a class that has already been loaded by the runtime), and
> -     insert them in the classes tree hiearchy too.  Otherwise, if you
> +     insert them in the classes tree hierarchy too.  Otherwise, if you
>       add a category, its +load method would not be called if the class
>       is already loaded in the runtime.  It the category is
>       "unclaimed", ie, we haven't loaded the main class yet, postpone
> diff --git a/libobjc/objc-private/objc-list.h b/libobjc/objc-private/objc-list.h
> index 44c5f0d092b..01443aab310 100644
> --- a/libobjc/objc-private/objc-list.h
> +++ b/libobjc/objc-private/objc-list.h
> @@ -62,7 +62,7 @@ list_remove_head (struct objc_list** list)
>      }
>    else
>      {
> -      /* Inly one element in list.  */
> +      /* Only one element in list.  */
>        objc_free (*list);
>        (*list) = 0;
>      }
> diff --git a/libobjc/sendmsg.c b/libobjc/sendmsg.c
> index 65bc250ad90..c8a10cc9c97 100644
> --- a/libobjc/sendmsg.c
> +++ b/libobjc/sendmsg.c
> @@ -1007,7 +1007,7 @@ __objc_install_dtable_for_class (Class cls)
>      return;
>
>    /* We have this function cache the implementation pointers for
> -     _objc_get_prepared_imp but the dispatch table won't be initilized
> +     _objc_get_prepared_imp but the dispatch table won't be initialized
>       until __objc_send_initialize completes.  */
>    __objc_prepare_dtable_for_class (cls);
>
> diff --git a/libobjc/thr.c b/libobjc/thr.c
> index 58c4bc3ab01..aff4c2d99c6 100644
> --- a/libobjc/thr.c
> +++ b/libobjc/thr.c
> @@ -205,7 +205,7 @@ objc_thread_yield (void)
>    __gthread_objc_thread_yield ();
>  }
>
> -/* Terminate the current tread.  Doesn't return.  Actually, if it
> +/* Terminate the current thread.  Doesn't return.  Actually, if it
>     failed returns -1.  */
>  int
>  objc_thread_exit (void)
> --
> 2.39.5
>
  
Andrew Kreimer Sept. 23, 2024, 7:57 p.m. UTC | #2
On Mon, Sep 23, 2024 at 12:47:28PM -0700, Andrew Pinski wrote:
> On Fri, Sep 20, 2024 at 1:41 AM Andrew Kreimer <algonell@gmail.com> wrote:
> >
> > Fix typos in comments.
> 
> OK. Do you have push access or need someone to push it for you?
> 

Hi, I need someone to push to.
  
Andrew Pinski Sept. 23, 2024, 8:59 p.m. UTC | #3
On Mon, Sep 23, 2024 at 12:57 PM Andrew Kreimer <algonell@gmail.com> wrote:
>
> On Mon, Sep 23, 2024 at 12:47:28PM -0700, Andrew Pinski wrote:
> > On Fri, Sep 20, 2024 at 1:41 AM Andrew Kreimer <algonell@gmail.com> wrote:
> > >
> > > Fix typos in comments.
> >
> > OK. Do you have push access or need someone to push it for you?
> >
>
> Hi, I need someone to push to.

Ok, pushed as r15-3813-g0121b852c85db9  except for the configure part
since the top-level libtool.m4 still contains the typo and we should
only be regenerating configure.

ChangeLog entry used:
    libobjc/ChangeLog:

            * Makefile.in: s/overrridden/overridden.
            * encoding.c (_darwin_rs6000_special_round_type_align): Fix typo
            in comment.
            (rs6000_special_round_type_align): Likewise.
            * exception.c (is_kind_of_exception_matcher): Likewise.
            (PERSONALITY_FUNCTION): Likewise.
            * hash.c (objc_hash_next): Likewise.
            * init.c (__objc_create_classes_tree): Likewise.
            * objc-private/objc-list.h (list_remove_head): Likewise.
            * sendmsg.c (__objc_install_dtable_for_class): Likewise.
            * thr.c (objc_thread_yield): Likewise.

Also next time please also add a changelog to commit message as
mentioned on https://gcc.gnu.org/contribute.html .

Thanks,
Andrew Pinski
  
Andrew Kreimer Sept. 23, 2024, 9:56 p.m. UTC | #4
On Mon, Sep 23, 2024 at 01:59:04PM -0700, Andrew Pinski wrote:
> On Mon, Sep 23, 2024 at 12:57 PM Andrew Kreimer <algonell@gmail.com> wrote:
> >
> > On Mon, Sep 23, 2024 at 12:47:28PM -0700, Andrew Pinski wrote:
> > > On Fri, Sep 20, 2024 at 1:41 AM Andrew Kreimer <algonell@gmail.com> wrote:
> > > >
> > > > Fix typos in comments.
> > >
> > > OK. Do you have push access or need someone to push it for you?
> > >
> >
> > Hi, I need someone to push to.
> 
> Ok, pushed as r15-3813-g0121b852c85db9  except for the configure part
> since the top-level libtool.m4 still contains the typo and we should
> only be regenerating configure.
> 

Thank you.

> 
> Also next time please also add a changelog to commit message as
> mentioned on https://gcc.gnu.org/contribute.html .
> 

Noted.
  

Patch

diff --git a/libobjc/Makefile.in b/libobjc/Makefile.in
index 58d0638f72e..3d856eb8d5f 100644
--- a/libobjc/Makefile.in
+++ b/libobjc/Makefile.in
@@ -59,7 +59,7 @@  MULTIDO = true
 MULTICLEAN = true
 
 # Not configured per top-level version, since that doesn't get passed
-# down at configure time, but overrridden by the top-level install
+# down at configure time, but overridden by the top-level install
 # target.
 INSTALL = @INSTALL@
 INSTALL_PROGRAM = @INSTALL_PROGRAM@
diff --git a/libobjc/configure b/libobjc/configure
index 68172549137..5f4c928d2bf 100755
--- a/libobjc/configure
+++ b/libobjc/configure
@@ -13935,7 +13935,7 @@  func_basename ()
 #             to NONDIR_REPLACEMENT.
 #             value returned in "$func_dirname_result"
 #   basename: Compute filename of FILE.
-#             value retuned in "$func_basename_result"
+#             value returned in "$func_basename_result"
 # Implementation must be kept synchronized with func_dirname
 # and func_basename. For efficiency, we do not delegate to
 # those functions but instead duplicate the functionality here.
diff --git a/libobjc/encoding.c b/libobjc/encoding.c
index 7a2d2abe6d1..f4fc4f452e4 100644
--- a/libobjc/encoding.c
+++ b/libobjc/encoding.c
@@ -151,7 +151,7 @@  static int __attribute__ ((__unused__)) not_target_flags = 0;
 #  undef TARGET_ALIGN_NATURAL
 #  define TARGET_ALIGN_NATURAL 1
 # endif
-/* On Darwin32, we need to recurse until we find the starting stuct type.  */
+/* On Darwin32, we need to recurse until we find the starting struct type.  */
 static int 
 _darwin_rs6000_special_round_type_align (const char *struc, int comp, int spec)
 {
@@ -186,7 +186,7 @@  _darwin_rs6000_special_round_type_align (const char *struc, int comp, int spec)
 
 /*  FIXME: while this file has no business including tm.h, this
     definitely has no business defining this macro but it
-    is only way around without really rewritting this file,
+    is only way around without really rewriting this file,
     should look after the branch of 3.4 to fix this.   */
 #define rs6000_special_round_type_align(STRUCT, COMPUTED, SPECIFIED)	\
   ({ const char *_fields = TYPE_FIELDS (STRUCT);			\
diff --git a/libobjc/exception.c b/libobjc/exception.c
index f051c5f9524..dce576e8559 100644
--- a/libobjc/exception.c
+++ b/libobjc/exception.c
@@ -42,7 +42,7 @@  is_kind_of_exception_matcher (Class catch_class, id exception)
     return 1;
 
   /* If exception is nil (eg, @throw nil;), then it can only be
-     catched by a catch-all (eg, @catch (id object)).  */
+     caught by a catch-all (eg, @catch (id object)).  */
   if (exception != nil)
     {
       Class c;
@@ -384,7 +384,7 @@  PERSONALITY_FUNCTION (int version,
 #endif /* __USING_SJLJ_EXCEPTIONS__  */
 
   /* If ip is not present in the table, C++ would call terminate.  */
-  /* ??? As with Java, it's perhaps better to tweek the LSDA to that
+  /* ??? As with Java, it's perhaps better to tweak the LSDA to that
      no-action is mapped to no-entry.  */
   CONTINUE_UNWINDING;
 
diff --git a/libobjc/hash.c b/libobjc/hash.c
index e216c8cdf3b..e0ecf30e024 100644
--- a/libobjc/hash.c
+++ b/libobjc/hash.c
@@ -222,7 +222,7 @@  objc_hash_next (cache_ptr cache, node_ptr node)
       if (node->next)
 	{
 	  /* There is a node which follows the last node returned.
-	     Step to that node and retun it.  */
+	     Step to that node and return it.  */
 	  return node->next;
 	}
       else
diff --git a/libobjc/init.c b/libobjc/init.c
index 6216546084b..9f8bafb8ee3 100644
--- a/libobjc/init.c
+++ b/libobjc/init.c
@@ -851,7 +851,7 @@  __objc_create_classes_tree (struct objc_module *module)
 
   /* Now iterate over "claimed" categories too (ie, categories that
      extend a class that has already been loaded by the runtime), and
-     insert them in the classes tree hiearchy too.  Otherwise, if you
+     insert them in the classes tree hierarchy too.  Otherwise, if you
      add a category, its +load method would not be called if the class
      is already loaded in the runtime.  It the category is
      "unclaimed", ie, we haven't loaded the main class yet, postpone
diff --git a/libobjc/objc-private/objc-list.h b/libobjc/objc-private/objc-list.h
index 44c5f0d092b..01443aab310 100644
--- a/libobjc/objc-private/objc-list.h
+++ b/libobjc/objc-private/objc-list.h
@@ -62,7 +62,7 @@  list_remove_head (struct objc_list** list)
     }
   else
     {
-      /* Inly one element in list.  */
+      /* Only one element in list.  */
       objc_free (*list);
       (*list) = 0;
     }
diff --git a/libobjc/sendmsg.c b/libobjc/sendmsg.c
index 65bc250ad90..c8a10cc9c97 100644
--- a/libobjc/sendmsg.c
+++ b/libobjc/sendmsg.c
@@ -1007,7 +1007,7 @@  __objc_install_dtable_for_class (Class cls)
     return;
 
   /* We have this function cache the implementation pointers for
-     _objc_get_prepared_imp but the dispatch table won't be initilized
+     _objc_get_prepared_imp but the dispatch table won't be initialized
      until __objc_send_initialize completes.  */
   __objc_prepare_dtable_for_class (cls);
 
diff --git a/libobjc/thr.c b/libobjc/thr.c
index 58c4bc3ab01..aff4c2d99c6 100644
--- a/libobjc/thr.c
+++ b/libobjc/thr.c
@@ -205,7 +205,7 @@  objc_thread_yield (void)
   __gthread_objc_thread_yield ();
 }
 
-/* Terminate the current tread.  Doesn't return.  Actually, if it
+/* Terminate the current thread.  Doesn't return.  Actually, if it
    failed returns -1.  */
 int
 objc_thread_exit (void)