From patchwork Thu Aug 1 14:56:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Cohen X-Patchwork-Id: 94997 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BF4C9385EC55 for ; Thu, 1 Aug 2024 15:18:30 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 436AB385EC54 for ; Thu, 1 Aug 2024 14:58:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 436AB385EC54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 436AB385EC54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722524360; cv=none; b=rYU7JfJ9k+ejCPdY5NlZQFOEgrPA5IHqFlCpJKseSdPNsd1IKpiSmY4mi0KkfMt9TsjRZf9d9rq0CakZynSxlbbjTqXnQNKYE8cdv3B4I+2us/ke86uttBgbsgHn9J7rKXta4pqkX4Ewcd9l2GGi558N0rx05nqrPDvO8HD+EYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722524360; c=relaxed/simple; bh=eavbNJQK+eM+81JGBW9eCGYTs7WAWera+N/pt+Wwfik=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kxGogKMTDTsXujF2eRpo6csJiJ4IocBDE5L9ZQjXjEYW98uo8BddZCoSGNjMUwb+XsIlKkjLI79zD/Bk+TDcKImS64ho0eSfTHQXGeGdYfHC01fSJQB0eDBv8iASnwwElYHeRMhFo2XEuJs3dCuURQPOrDmhVzH76VyP0wGBFUc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5a156556fb4so10435663a12.3 for ; Thu, 01 Aug 2024 07:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1722524338; x=1723129138; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=InWXqon2WFfGqGuxf9Fv59kO9B1X4Ee8WY+O734rDyQ=; b=FUWIM5e7wfIgJLMkikbhSJsDX8Jc/NwpqqtwVWAFl9C61eeJLZz2v5Br5XiTFVtncX HsdjXOw2Tc8aX3mBz8BSnJFY02+esK5drwFsh9s6Us8gIQLspiw6yoViPN174+3pfDIC Hj1Dac7+d/mcCIUP4RyZdMC/7Nj3mxirfo6plIEUxnTbwbZi+nIWNl2hm9Mpr/Zj4rHI 6WJ8MdxNo9faCHynhOSTgsk7zhzTcX7tEcn/BMm2+6KVm4jWScWSTIb4/nmH3G8la7ut gZDKJZJ+uGTM0Qvm/5yoCXoB27zSroK/x4LFmvzJPml0fDHAVcTmV74GSCfVe261ApLX VHYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722524338; x=1723129138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=InWXqon2WFfGqGuxf9Fv59kO9B1X4Ee8WY+O734rDyQ=; b=FITZDAIZLPWHurFKzST4Y8/JRw5pTe+CuWXAHooZmxEy8tJhzzklVcx5aP1rt62de0 NbMuPqn82Tnec8sTo+DfChv7ZWCRFyM/QEnyh7DJAYTmtEi30nlwqCdUBsSnk6qcky2V stySwAi6XbzFkkqi293rNbEKhXotiZhsI/hb+SobKO2MoHdo2WMMhQ5w+e8WBU1vFgPp fkhs6G62fJrHSPnmiAtpiv4wjCRCGkMnCSAwDxhz03tiPVUaKS2uit5M1KM51ZtY0kec p12VONJt2ChVSVhWYlHbwPFZkyak6If0vNTVLSb6+7uTYdQefJDrNFhrWEWn4Evwdw6w J7Uw== X-Gm-Message-State: AOJu0YyXa1ltQ+Md6BvllzGrs5vuZH3XUvXP9MWmKc0y835W8WmreDOn kFkv/hSQ+CQg9LNICnoFMModfvINQSKSQyEaXz6fCwBqlKHpTpmMeMqZ5c4Qirkxcs4KrklreZa IK56V X-Google-Smtp-Source: AGHT+IHkw/e3WdSP9GOH6FgFzf6TgVqj/l7msd0wLTVF4jrmLfiwk0GV4TVlpfpr+TeM0g40doj+Cw== X-Received: by 2002:aa7:cc81:0:b0:57d:10db:488e with SMTP id 4fb4d7f45d1cf-5b7f51297f0mr433052a12.30.1722524337743; Thu, 01 Aug 2024 07:58:57 -0700 (PDT) Received: from platypus.lan ([2a04:cec2:9:dc84:3622:6733:ff49:ee91]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac63590592sm10252456a12.25.2024.08.01.07.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 07:58:57 -0700 (PDT) From: Arthur Cohen To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, jjasmine Subject: [PATCH 034/125] gccrs: Add error emitting when we can't resolve id expr Date: Thu, 1 Aug 2024 16:56:30 +0200 Message-ID: <20240801145809.366388-36-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240801145809.366388-2-arthur.cohen@embecosm.com> References: <20240801145809.366388-2-arthur.cohen@embecosm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org From: jjasmine gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Add error emitting --- gcc/rust/resolve/rust-late-name-resolver-2.0.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/rust/resolve/rust-late-name-resolver-2.0.cc b/gcc/rust/resolve/rust-late-name-resolver-2.0.cc index f9731a451a3..8717c51e34a 100644 --- a/gcc/rust/resolve/rust-late-name-resolver-2.0.cc +++ b/gcc/rust/resolve/rust-late-name-resolver-2.0.cc @@ -130,7 +130,10 @@ Late::visit (AST::IdentifierExpr &expr) resolved = label; else if (value) resolved = value; - // TODO: else emit error? + else { + rust_error_at(expr.get_locus (), "could not resolve identifier expression: %qs", expr.get_ident ().as_string ().c_str ()); + return; + } ctx.map_usage (expr.get_node_id (), *resolved);