Message ID | 20240715101629.3571801-1-torbjorn.svensson@foss.st.com |
---|---|
State | Committed |
Commit | 7793f5b4194253acaac0b53d8a1c95d9b5c8f4bb |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 600DB3864C64 for <patchwork@sourceware.org>; Mon, 15 Jul 2024 10:17:49 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id D950D385840D for <gcc-patches@gcc.gnu.org>; Mon, 15 Jul 2024 10:17:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D950D385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D950D385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721038632; cv=none; b=fDKT1t8FvNhxTaLbnjx1+ZjeU3VUOZ71RL4sye4m9Sa9CA/j6WVpK2gNh9Elh2UoBC4P2k3+gE7ccigToEgCWSgVuDC/pOoKyA/jRvMigMWqgG9ZwYU7uTrb9I7iebxExgEsOkLRQ5Ejg9F9s79rAFFACMhmMcobSowzrDkNb9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721038632; c=relaxed/simple; bh=tj3NEHB3SGLT9ZR1oBajuqrstN4lbq4QjV/44oug6c8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VDYSCu3P11PCvknQrEBJ7JFr4i79GYaBQs505ZdHAqvOEZ97N0WrmbgwrBTdBRwlYUPlZLc2uMFeArtq7BMjRdYxy4VWI7khE0Or5jMz6RsHBQsJOusbwsk5LULp1YqwECRR59kQ81zbo0haGomUycZR/KG7DDB2YERwB2vg/BY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46F7v37p028411; Mon, 15 Jul 2024 12:17:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=selector1; bh=6Nu3n3XVjZ3iPkg3O6F9p2 d1hXDtP/jwR30Hkbkgdhc=; b=ClI7BGJhkrxQ47XdFFxAfir0ONoIONGKAuU3I5 dKdvf/GU2yBH1mQpCI4UEK9gATLjlG/h+xk2sdJ0e2bIpw+GUEbWInWQRr63KfS/ 8e2dit0lHSNmBPcq2VloGPK5bUP7+tLJgcEQwvvtuQzRw+D+Wl7aDiPITp83AepU 89ELfLGFRa+jfpZjXK9LsaMwk/oa9Kr/bdLdj0Qds5OigcLXo/jvWOBQ1ZZdHtEE 86TBcvFgFU07DefHAQdboltQAP5w3YfR+yTx7h+Ixxgc1KJ4rInxxJIhuWcROv9T nADZqn3xyt51g8Svu8JhQgfor52VfN9Wt5q+BLXkLZ0j8qCQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 40c351c84c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Jul 2024 12:17:05 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id F086A4002D; Mon, 15 Jul 2024 12:16:59 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B5CAF2165FF; Mon, 15 Jul 2024 12:16:46 +0200 (CEST) Received: from jkgcxl0004.jkg.st.com (10.74.22.255) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Mon, 15 Jul 2024 12:16:46 +0200 From: =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= <torbjorn.svensson@foss.st.com> To: <gcc-patches@gcc.gnu.org> CC: <yvan.roux@foss.st.com>, <richard.earnshaw@arm.com>, <rguenther@suse.de>, =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= <torbjorn.svensson@foss.st.com> Subject: [PATCH] testsuite: Disable finate math only for test [PR115826] Date: Mon, 15 Jul 2024 12:16:29 +0200 Message-ID: <20240715101629.3571801-1-torbjorn.svensson@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.22.255] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-15_06,2024-07-11_01,2024-05-17_01 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
testsuite: Disable finate math only for test [PR115826]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | success | Build passed |
linaro-tcwg-bot/tcwg_gcc_build--master-arm | success | Build passed |
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 | success | Test passed |
linaro-tcwg-bot/tcwg_gcc_check--master-arm | success | Test passed |
Commit Message
Torbjorn SVENSSON
July 15, 2024, 10:16 a.m. UTC
As the test case requires +-Inf and NaN to work and -ffast-math is added
by default for arm-none-eabi, re-enable non-finite math.
gcc/testsuite/ChangeLog:
PR testsuite/115826
* gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only.
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On Mon, 15 Jul 2024, Torbjörn SVENSSON wrote: > As the test case requires +-Inf and NaN to work and -ffast-math is added > by default for arm-none-eabi, re-enable non-finite math. Isn't /* { dg-add-options ieee } */ the canonical way to handle CPU/testsuite defaults? > gcc/testsuite/ChangeLog: > > PR testsuite/115826 > * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > index dba95a81973..3e619a3fa5a 100644 > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > @@ -4,6 +4,9 @@ > /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ > /* { dg-require-effective-target vect_float } */ > > +/* This test requires +-Inf and NaN, so disable finite-math-only */ > +/* { dg-additional-options "-fno-finite-math-only" } */ > + > #include "tsvc.h" > > real_t s1281(struct args_t * func_args) >
Gentle ping :) As mentioned in the ticket, I would like to target this to trunk and releases/gcc-14. Kind regards, Torbjörn On 2024-07-15 12:16, Torbjörn SVENSSON wrote: > As the test case requires +-Inf and NaN to work and -ffast-math is added > by default for arm-none-eabi, re-enable non-finite math. > > gcc/testsuite/ChangeLog: > > PR testsuite/115826 > * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > index dba95a81973..3e619a3fa5a 100644 > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > @@ -4,6 +4,9 @@ > /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ > /* { dg-require-effective-target vect_float } */ > > +/* This test requires +-Inf and NaN, so disable finite-math-only */ > +/* { dg-additional-options "-fno-finite-math-only" } */ > + > #include "tsvc.h" > > real_t s1281(struct args_t * func_args)
On Tue, 23 Jul 2024, Torbjorn SVENSSON wrote: > Gentle ping :) > > As mentioned in the ticket, I would like to target this to trunk and > releases/gcc-14. OK. Richard. > Kind regards, > Torbjörn > > On 2024-07-15 12:16, Torbjörn SVENSSON wrote: > > As the test case requires +-Inf and NaN to work and -ffast-math is added > > by default for arm-none-eabi, re-enable non-finite math. > > > > gcc/testsuite/ChangeLog: > > > > PR testsuite/115826 > > * gcc.dg/vect/tsvc/vect-tsvc-s1281.c: Use -fno-finite-math-only. > > > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > > --- > > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > index dba95a81973..3e619a3fa5a 100644 > > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c > > @@ -4,6 +4,9 @@ > > /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ > > /* { dg-require-effective-target vect_float } */ > > > > +/* This test requires +-Inf and NaN, so disable finite-math-only */ > > +/* { dg-additional-options "-fno-finite-math-only" } */ > > + > > #include "tsvc.h" > > > > real_t s1281(struct args_t * func_args) > >
On 2024-07-23 09:59, Richard Biener wrote: > On Tue, 23 Jul 2024, Torbjorn SVENSSON wrote: > >> Gentle ping :) >> >> As mentioned in the ticket, I would like to target this to trunk and >> releases/gcc-14. > > OK. > > Richard. > Pushed as releases/gcc-14.1.0-331-ga544898f6dd and basepoints/gcc-15-2224-g7793f5b4194. Kind regards, Torbjörn
diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c index dba95a81973..3e619a3fa5a 100644 --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s1281.c @@ -4,6 +4,9 @@ /* { dg-additional-options "--param vect-epilogues-nomask=0" } */ /* { dg-require-effective-target vect_float } */ +/* This test requires +-Inf and NaN, so disable finite-math-only */ +/* { dg-additional-options "-fno-finite-math-only" } */ + #include "tsvc.h" real_t s1281(struct args_t * func_args)