From patchwork Fri Apr 26 13:50:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 89035 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B12C5384AB56 for ; Fri, 26 Apr 2024 13:50:57 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 82CF93858C42 for ; Fri, 26 Apr 2024 13:50:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82CF93858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82CF93858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714139433; cv=none; b=bmRY8V6vpkoLam+evwWkrKpzbX7S8Vy5e2iwE6pChfM4bF8+cq35i5f0R4Qo7rMdl2MNNCuANpVFEX10tNYtDMEGaGQDaydPV0zgxfCK+eFjavMIIrxlZrUG2fezuPlu1BHFD54lcweYSPgjim94WRzhRh2Y5mroBPoFuT/Jwa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714139433; c=relaxed/simple; bh=53z69A80C0x8aeC066AJaymcdg3nSJDELESWp+VEyqE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=dlwO6XMaucd+7fq0JrQA5RD5CCoqNSmJnro2Ju7VKkcadqzbu2soE16vgTkX5Jkv4+y/VgYPyIJsc+1eNzLQdi1m2Y2f0YNU8eqKAFAY0dolKysxoxSq5Rrn3RMVJfnEe+32xrHS8bHH2U506lYHNCPQzQiShfkhodXbLljnfeY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 14E4322033 for ; Fri, 26 Apr 2024 13:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714139430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=6nrHw8sv4PwxNjomJrKfYgoAosBOMKVu0lIsI1hcb/U=; b=yJts4rhsO8mKkngdFBe6FkqV5eQUohw1tnFWHw0s+1z1vhqRqpsJBtHzIGes+IW7LGuTcE U9dYF1wpWeqJk1Uq2ZQDSu5qLS4SCwjV+oyW52ppJ6N6nX6PCJ6gXlRcaRiI5Yfgfa8N7k XDcurW+NvEF3iwEdGutb8EG4dmZVjDI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714139430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=6nrHw8sv4PwxNjomJrKfYgoAosBOMKVu0lIsI1hcb/U=; b=+x8fkRcm9MZx40djsy1uLtaRWtRemCldkO4fFKGrmVjhkq9pNHXhDULJnaChxHKVkFAJy8 x6OZno9GTBQ/xjAw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714139430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=6nrHw8sv4PwxNjomJrKfYgoAosBOMKVu0lIsI1hcb/U=; b=yJts4rhsO8mKkngdFBe6FkqV5eQUohw1tnFWHw0s+1z1vhqRqpsJBtHzIGes+IW7LGuTcE U9dYF1wpWeqJk1Uq2ZQDSu5qLS4SCwjV+oyW52ppJ6N6nX6PCJ6gXlRcaRiI5Yfgfa8N7k XDcurW+NvEF3iwEdGutb8EG4dmZVjDI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714139430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=6nrHw8sv4PwxNjomJrKfYgoAosBOMKVu0lIsI1hcb/U=; b=+x8fkRcm9MZx40djsy1uLtaRWtRemCldkO4fFKGrmVjhkq9pNHXhDULJnaChxHKVkFAJy8 x6OZno9GTBQ/xjAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 020A5136DB for ; Fri, 26 Apr 2024 13:50:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id McU2OyWxK2ajZwAAD6G6ig (envelope-from ) for ; Fri, 26 Apr 2024 13:50:29 +0000 Date: Fri, 26 Apr 2024 15:50:21 +0200 (CEST) From: Richard Biener X-X-Sender: rguenther@rguenther-XPS-13-9380 To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/114734 - wrong code with expand_call_mem_ref User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Message-Id: <20240426135030.020A5136DB@imap1.dmz-prg2.suse.org> X-Spam-Level: X-Spamd-Result: default: False [-2.83 / 50.00]; BAYES_HAM(-1.53)[91.93%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Spam-Score: -2.83 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org When expand_call_mem_ref looks at the definition of the address argument to eventually expand a &TARGET_MEM_REF argument together with a masked load it fails to honor constraints imposed by SSA coalescing decisions. The following fixes this. Boostrap and regtest running on x86_64-unknown-linux-gnu. PR middle-end/114734 * internal-fn.cc (expand_call_mem_ref): Use get_gimple_for_ssa_name to get at the def stmt of the address argument to honor SSA coalescing constraints. --- gcc/internal-fn.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gcc/internal-fn.cc b/gcc/internal-fn.cc index 2c764441cde..0a7053c2286 100644 --- a/gcc/internal-fn.cc +++ b/gcc/internal-fn.cc @@ -53,6 +53,8 @@ along with GCC; see the file COPYING3. If not see #include "rtl-iter.h" #include "gimple-range.h" #include "fold-const-call.h" +#include "tree-ssa-live.h" +#include "tree-outof-ssa.h" /* For lang_hooks.types.type_for_mode. */ #include "langhooks.h" @@ -2964,8 +2966,8 @@ expand_call_mem_ref (tree type, gcall *stmt, int index) tree tmp = addr; if (TREE_CODE (tmp) == SSA_NAME) { - gimple *def = SSA_NAME_DEF_STMT (tmp); - if (gimple_assign_single_p (def)) + gimple *def = get_gimple_for_ssa_name (tmp); + if (def && gimple_assign_single_p (def)) tmp = gimple_assign_rhs1 (def); }