[1/2] Remove unecessary and broken MC/DC compile test

Message ID 20240405195831.2728853-2-j@lambda.is
State Committed
Commit 888bf719728e9ab1da22900d39956e0d80889e30
Headers
Series Condition coverage fixes |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Testing passed

Commit Message

Jørgen Kvalsvik April 5, 2024, 7:58 p.m. UTC
  The __sigsetjmp test was added as a regression test, which an early
iteration of the MC/DC support caused an internal compiler error,
triggered by a code path which did not make it through to the final
revision.  Since this test really only worked on linux and does not
serve a purpose any more it can be removed.

gcc/testsuite/ChangeLog:

	* gcc.misc-tests/gcov-19.c: Remove test.
---
 gcc/testsuite/gcc.misc-tests/gcov-19.c | 11 -----------
 1 file changed, 11 deletions(-)
  

Comments

Rainer Orth April 15, 2024, 8:56 a.m. UTC | #1
Hi Jørgen,

> The __sigsetjmp test was added as a regression test, which an early
> iteration of the MC/DC support caused an internal compiler error,
> triggered by a code path which did not make it through to the final
> revision.  Since this test really only worked on linux and does not
> serve a purpose any more it can be removed.
>
> gcc/testsuite/ChangeLog:
>
> 	* gcc.misc-tests/gcov-19.c: Remove test.

just a nit (and too late since it's already checked in): the ChangeLog
entry should specify *which test* was removed.  As is, it reads like the
whole file has been removed.  Something like

 	* gcc.misc-tests/gcov-19.c (__sigsetjmp, mcdc021c): Remove.

	Rainer
  

Patch

diff --git a/gcc/testsuite/gcc.misc-tests/gcov-19.c b/gcc/testsuite/gcc.misc-tests/gcov-19.c
index 17f1fb4e923..b83a38531ba 100644
--- a/gcc/testsuite/gcc.misc-tests/gcov-19.c
+++ b/gcc/testsuite/gcc.misc-tests/gcov-19.c
@@ -869,17 +869,6 @@  dest:
     goto * 0;
 }
 
-int __sigsetjmp ();
-
-/* This should compile, but not called. */
-void
-mcdc021c ()
-{
-  while (x) /* conditions(0/2) true(0) false(0)*/
-	    /* conditions(end) */
-     __sigsetjmp ();
-}
-
 /* If edges are not properly contracted the a && id (b) will be interpreted as
    two independent expressions. */
 void