From patchwork Tue Apr 2 11:28:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 87927 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46E453858C55 for ; Tue, 2 Apr 2024 11:29:26 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id F26863858404 for ; Tue, 2 Apr 2024 11:28:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F26863858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F26863858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712057330; cv=none; b=osZB55rbnp2FYVffo5Va5QhyvKvefgbwp26tcD9JppAV1zZgt90Of42O8OBzKoc2jb7nGUOyGvQk7E5sRvz0F4RVgJ8xTb8KWF8UTGVjlJFIRbopIOI0+bZKDR/5IQ63ivlsrFmRemqjUwNj1Pl2TNGdCEVw7oQGV5Oh71aEsD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712057330; c=relaxed/simple; bh=sdGP3hguVXSTc1Npi+Bqu+zN7/W+uckSLoGN6NFGaSg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=sozrtxxkd2fA49NhPuE/gwk5d6m5SbMuDHMdus69cZnwr2RRsCbct+wKIW7sRi8zBmSsLKjkVa/ra27qHDfu8iSYJGG2bH8n4KdZcHKPJLC8590JgeATjFk9JfQyA/Od5utyjcMxpXtBbOmh/AA+t1mUuAGquHr+899i/05Qy0E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2d718ee7344so49554651fa.2 for ; Tue, 02 Apr 2024 04:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712057325; x=1712662125; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=00NHJXywqZI7nn6ImI41CPWjdeHnvqPunDrjK1BmjTM=; b=m7OmP6xtcX4gsKufaXNqlRrCzR/bkO/cl4tbCAXtgGPICFk7YB/GnscsPeiIMbF9ZY go5XTGaajebpNI0/Ph0fnCtS4bhHDRyc9l/1Fs3K/YBwNF/nkn8vav/+uHeZqSZjdiG0 dYW5n+lBoZhapjtQ+MSgJP9bC7305TE6YzKBhBhOzgisRFln/f3HkZxHIBoUxy1voFr0 ifLVemaLOA0nhtfiHE9KY+HOcq0nvWWV//gwZuFEUDCNIPxOIeURGxyfKdCgvWkiKVMD wAULDODzxbtIhSMe8zkgMiH2YExH+zo8j88yZAtfOYYj+vewkfPuvx9fNamlhqXuG+lr RUKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712057325; x=1712662125; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=00NHJXywqZI7nn6ImI41CPWjdeHnvqPunDrjK1BmjTM=; b=VjU3RJZ2xwpw7d4NNpwJHe7mOby25UEEbEDDuQm5c11aw4m0lowKpmDAF1VjCIO5nS N+p5P02GR7alKtRBQ/F7/a5Q1rdkaTWZVC5T9+s26FFqYOKHT0dL8PcxiIKwmGy9Wzdy XqY7IK1KSutXFoXsdI7B9DoCjpNZCeRDXCG458H3smGH/ccTIRzVKvlk2hVGzvq1M4VB ibXoPh9PnjkiY+EyEkgnVI0tuw2UIBQwhqEli8IfCeeXS5pPv/5xaq2fVgZ+ep+ENvKy HZBeR8165SxU+cqAaUBuLX3+YuLkQbF7R2yNB4BROtqk8oyZh9BsxAE5O5O5Je0oHHgk 4yoQ== X-Gm-Message-State: AOJu0YyxZjg53s+yU+4c88jg81A0tF6/uKPMo5SPl74Z9N4YJwGY+RQu c2m3JhMqbIzD+SnGbcGSUsnmBuDtPicMt+HHgFTMvApApbvWiBfT+zILfMo6 X-Google-Smtp-Source: AGHT+IFID3KUyGxhGOVEN3wzLeqKbRytYCezOLtz4Xi5mst0KG2fSQs78wktjOB1ch4BRYOmkvllHQ== X-Received: by 2002:a05:651c:1692:b0:2d6:c7b5:989c with SMTP id bd18-20020a05651c169200b002d6c7b5989cmr7606470ljb.28.1712057325254; Tue, 02 Apr 2024 04:28:45 -0700 (PDT) Received: from localhost.localdomain (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id g18-20020a05600c4ed200b0041495d17992sm17621928wmq.34.2024.04.02.04.28.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 02 Apr 2024 04:28:45 -0700 (PDT) From: Iain Sandoe X-Google-Original-From: Iain Sandoe To: gcc-patches@gcc.gnu.org Subject: [pushed] testsuite, Darwin: Allow for an undefined symbol [PR114036]. Date: Tue, 2 Apr 2024 12:28:44 +0100 Message-Id: <20240402112844.86705-1-iain@sandoe.co.uk> X-Mailer: git-send-email 2.39.2 (Apple Git-143) MIME-Version: 1.0 X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: iain@sandoe.co.uk Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Tested on x86_64-darwin17,21,23 and on x86_64 and powerpc64 linux gnu, pushed to trunk, thanks Iain --- 8< --- Darwin's linker defaults to requiring all symbols to be defined at static link time (unless specifically noted or dynamic lookuo is enabled). For this test, we just need to note that the symbol is expected to be undefined. PR testsuite/114036 gcc/testsuite/ChangeLog: * gcc.misc-tests/gcov-14.c: Allow for 'Foo' to be undefined on Darwin link lines. Signed-off-by: Iain Sandoe --- gcc/testsuite/gcc.misc-tests/gcov-14.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.misc-tests/gcov-14.c b/gcc/testsuite/gcc.misc-tests/gcov-14.c index 2bebf7e4a93..61a9191c068 100644 --- a/gcc/testsuite/gcc.misc-tests/gcov-14.c +++ b/gcc/testsuite/gcc.misc-tests/gcov-14.c @@ -3,7 +3,7 @@ /* { dg-do run { target native } } */ /* { dg-options "-O2 -fprofile-arcs -ftest-coverage -fgnu89-inline" } */ /* The following line arranges that Darwin has behavior like elf weak import. */ -/* { dg-additional-options "-flat_namespace -undefined suppress" { target *-*-darwin* } } */ +/* { dg-additional-options "-Wl,-U,_Foo" { target *-*-darwin* } } */ /* { dg-require-weak "" } */ /* { dg-skip-if "undefined weak not supported" { { hppa*-*-hpux* } && { ! lp64 } } } */ /* { dg-skip-if "undefined weak not supported" { powerpc-ibm-aix* } } */