From patchwork Thu Feb 22 14:46:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 86218 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA2B63858437 for ; Thu, 22 Feb 2024 14:46:53 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 0C0293858D39 for ; Thu, 22 Feb 2024 14:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C0293858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C0293858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708613183; cv=none; b=bd7Q+BXVCQYuIjZYEB2O89qiS/O7a/vA5ZU0Pa7c6M4KyjFHJA8iXRDvJRfkuL1ogIBhjk7spvIw8Hc5OkXR1mmkOEzjzABA6SyAchVgleZBj0hXX5aPX4tSv7tcO+K5gc6kZeabiu/+kEPCyXjnPpGJBgN6i+kgnBSH6gac5XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708613183; c=relaxed/simple; bh=NHqS99Bt+eTOzR+c8TFsajslGQDIJvNuBFudvPkkH9o=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=tyfAn4B51KDvOpMXezpSQbpn/AnNqBm6JglJ/CUryQ7GgfLwi207TPmsI1O+cmU3alTmAVuZXfxuql63PfsI0GodsZyZMW1TmJuQwtVlyjaN42vBdy4fHL30bNB3X+nZaNQItSFx4b0/gPO5yIO1wTCPICIcel6ioMZvB7cFib8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE8DA1F461 for ; Thu, 22 Feb 2024 14:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708613181; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=aKs/Cgwtfrge4ZccUI51ULWTfXtRXvAf5M1flEPLpOM=; b=OJxWsLozqxDLm576U4Ez/hsRHSkgu4CI6FuJVVG1dol72/gcDm3V0W6hRLRWQXPY7oYYLR zaxKtNcLm8dqQl9QbpqJYGZRPxY5fztrhXrUhC7xl4aF8D6mBJOEhxRtEQjyvgUIV2UHdN BcSiNOFBB2N5EC72U7Exfd1eNJDT28w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708613181; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=aKs/Cgwtfrge4ZccUI51ULWTfXtRXvAf5M1flEPLpOM=; b=oYJ768l5MQCTP6rH97QFZ35A955fcLqIyqsbwqQ0QhnMrBigpm4rnXYvzXcz90wKHk0Vqr o8FfXBbGyauH9CCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708613180; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=aKs/Cgwtfrge4ZccUI51ULWTfXtRXvAf5M1flEPLpOM=; b=jad1mwgbEhS6wGA6VysKz/BcqtPtOTh0qq4d3eCKUN9d+/KG86WytZ+YmQnnhhOBc/4KqE WdwbT6NW50c2XplEeYpQJ82PVmlNhBXY7Wjgtwf8SpR1kr0UMhbbHt1eIWX1KJg97QJBSR TtUVZEPx7QpEy7TRDeM0R/YKquYIsRA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708613180; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=aKs/Cgwtfrge4ZccUI51ULWTfXtRXvAf5M1flEPLpOM=; b=ZmqHv9EYgFrfpJZ+/Kd8q187vrBkDcRhOTL6o+EN1RFCWKYUUvuzr425gGgYboHIOKmgQ5 U3x4aH7NmeOAkaAw== Date: Thu, 22 Feb 2024 15:46:20 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/114048 - ICE in copy_reference_ops_from_ref MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: 1.47 X-Spamd-Result: default: False [1.47 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.981]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_SHORT(3.00)[0.999]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.95)[99.78%] X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Message-Id: <20240222144653.EA2B63858437@sourceware.org> The following adds another omission to the assert verifying we're not running into spurious off == -1. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/114048 * tree-ssa-sccvn.cc (copy_reference_ops_from_ref): MEM_REF can also produce -1 off. * gcc.dg/torture/pr114048.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr114048.c | 25 +++++++++++++++++++++++++ gcc/tree-ssa-sccvn.cc | 2 ++ 2 files changed, 27 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/torture/pr114048.c diff --git a/gcc/testsuite/gcc.dg/torture/pr114048.c b/gcc/testsuite/gcc.dg/torture/pr114048.c new file mode 100644 index 00000000000..338000b3006 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr114048.c @@ -0,0 +1,25 @@ +/* { dg-do compile } */ + +typedef struct { + void *child[2]; + char otherbits; +} critbit0_node; + +int allprefixed_traverse(char *top) +{ + if (top) + { + critbit0_node *q = (void *)top - 1; + int direction = 0; + for (;; ++direction) + switch (allprefixed_traverse(q->child[direction])) + { + case 1: + break; + case 0: + return 0; + default: + return 1; + } + } +} diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc index 3e93685e80a..2587eb1c505 100644 --- a/gcc/tree-ssa-sccvn.cc +++ b/gcc/tree-ssa-sccvn.cc @@ -1185,6 +1185,8 @@ copy_reference_ops_from_ref (tree ref, vec *result) else { gcc_assert (known_ne (op.off, -1) + /* The constant offset can be -1. */ + || op.opcode == MEM_REF /* Out-of-bound indices can compute to a known -1 offset. */ || ((op.opcode == ARRAY_REF