From patchwork Tue Feb 6 09:55:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 85339 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 681EB3858C78 for ; Tue, 6 Feb 2024 09:58:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 92C073858D38; Tue, 6 Feb 2024 09:57:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92C073858D38 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92C073858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707213424; cv=none; b=MJoaIVAeybxzSZz7Xj8Z8YLXkvCbhTkO/Ob/5XgDjO4H8YyOKkV7m5maQu6HxwgmA4KG04KWdv06nFFkf7ycRLzlL1PNHJs11O0oYLsWakNa7MYck0LG8ayY74uI4zR0lgXo865kq2FOhsENhX/kduvlQo0Qyul53GwUU2iqpDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707213424; c=relaxed/simple; bh=Tk/lfGfKb2jddGB9ZniRfLFiy2Qpf0K13py8OnZZ2z0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZDW5VoqkKRgI8vyv9XKSPgM5AxQm9drdSBYyeSRLg5jevtpTBsBxoGQVHtSsYDFlSOw8G/3+bdIbNmCPQ4OcATHWAI0yDTJMddpAGq6i16YDhRNOfoXOfitUZ/ZkqZxGRAcAch8imn8FWEgN5Fb5aEkZ4v6rZtQ2MIQU1nwet6Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1707213420; bh=Tk/lfGfKb2jddGB9ZniRfLFiy2Qpf0K13py8OnZZ2z0=; h=From:To:Cc:Subject:Date:From; b=nf8FopWLTByTHv3rNv64uxknnzJD9Uf6qkYtSg6XJiopMIflVSkX/fkvCcSp1uI+g 0Jdra1+vEgdX9AqGsrGkDNvlpe7mhGj9KgSn22rJvxRfUOVvisbRumtu/B+6+hbiP/ c5JCs1HEPJZ8rifzPiSQUUhQ72ZNkN4EdQv2nSzI= Received: from stargazer.. (unknown [IPv6:240e:358:1145:1f00:dc73:854d:832e:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 00A5066A7F; Tue, 6 Feb 2024 04:56:56 -0500 (EST) From: Xi Ruoyao To: gcc-patches@gcc.gnu.org Cc: Jeff Law , chenglulu , i@xen0n.name, xuchenghua@loongson.cn, YunQiang Su , Xi Ruoyao Subject: [PATCH] testsuite: Add a test case for negating FP vectors containing zeros Date: Tue, 6 Feb 2024 17:55:28 +0800 Message-ID: <20240206095635.305252-1-xry111@xry111.site> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Recently I've fixed two wrong FP vector negate implementation which caused wrong sign bits in zeros in targets (r14-8786 and r14-8801). To prevent a similar issue from happening again, add a test case. Tested on x86_64 (with SSE2, AVX, AVX2, and AVX512F), AArch64, MIPS (with MSA), LoongArch (with LSX and LASX). gcc/testsuite: * gcc.dg/vect/vect-neg-zero.c: New test. --- Ok for trunk? gcc/testsuite/gcc.dg/vect/vect-neg-zero.c | 39 +++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/vect/vect-neg-zero.c diff --git a/gcc/testsuite/gcc.dg/vect/vect-neg-zero.c b/gcc/testsuite/gcc.dg/vect/vect-neg-zero.c new file mode 100644 index 00000000000..adb032f5c6a --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/vect-neg-zero.c @@ -0,0 +1,39 @@ +/* { dg-do run } */ +/* { dg-add-options ieee } */ +/* { dg-additional-options "-fsigned-zeros" } */ + +double x[4] = {-0.0, 0.0, -0.0, 0.0}; +float y[8] = {-0.0, 0.0, -0.0, 0.0, -0.0, -0.0, 0.0, 0.0}; + +static __attribute__ ((always_inline)) inline void +test (int factor) +{ + double a[4]; + float b[8]; + + asm ("" ::: "memory"); + + for (int i = 0; i < 2 * factor; i++) + a[i] = -x[i]; + + for (int i = 0; i < 4 * factor; i++) + b[i] = -y[i]; + +#pragma GCC novector + for (int i = 0; i < 2 * factor; i++) + if (__builtin_signbit (a[i]) == __builtin_signbit (x[i])) + __builtin_abort (); + +#pragma GCC novector + for (int i = 0; i < 4 * factor; i++) + if (__builtin_signbit (b[i]) == __builtin_signbit (y[i])) + __builtin_abort (); +} + +int +main (void) +{ + test (1); + test (2); + return 0; +}