From patchwork Tue Jan 16 22:19:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg McGary X-Patchwork-Id: 84219 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 081A03858C33 for ; Tue, 16 Jan 2024 22:20:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id CF1993858CDB for ; Tue, 16 Jan 2024 22:19:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF1993858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF1993858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705443582; cv=none; b=DI53JBkL3l8i31LsnciFbRA0mYNOKnJYxZtj/cYlq1/cy9qY2BzlHI/YvuatsAWI8JCU5xPtZhGtVNrHD8hp9oaTsCUaBNRbFXhVmH2et0IKVqJaMEe0TVeIQx37rqqoah/KiuedlW1ax5NCWD6/d6C4iJhK+hbI4g5L2QUtw7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705443582; c=relaxed/simple; bh=jrYGytFIXgyf5qannSKgK3VqHdy9hgDCkoOfatPhRgc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=URTf0fwgJlMElRcMUCwyYCQrlQICvEK4YvK0BD7BFL0oVRCMOnk6h+6LQFRH4jC46wuobpZ6QzoERUk7TkdwhvsTNDkSgfrXzW9zg91hjcvIhLpwykWdqurXNRGMrYijJOWhiCoa4yyT8PWB356ojSuvmS73W0XmkQJp3X0RmW0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1d426ad4433so63826655ad.0 for ; Tue, 16 Jan 2024 14:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1705443579; x=1706048379; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2oI3ULD6tgoQKZIjp+WXpAUkJy87+WJgn3KZu3vqlYk=; b=D622Yg1mEv0aMM+4fOGMzfrqXOoBh871JfRq0g01Jzg+rHEK35GtqEzQ0kPoUOFl2M vufBG6pdnbeV1yiikJSstzFpe3OnZV47cjpp7WBumhSwP5pDUZ8XEWlM/YZXZThmPji6 /963a0Pjze4r55heMghBebqjXnTqS3bAW9JPGNEXTskDYTKqL/hQVm7ZyCqxIiAkL376 YR+hmGrz6EtZML0JRfD2i9U72pyRy+5n0QAcaAyYbxvYwLqIeF97yFY4hxjuYtG4gbgf pfo7xL6EdoJ2tKZfhm8BbeJVjEGTRgFBwjrr+4BBipyZR3OwH/HGJn7B9nZbejMIE3zv uuWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705443579; x=1706048379; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2oI3ULD6tgoQKZIjp+WXpAUkJy87+WJgn3KZu3vqlYk=; b=tzqULtxV4t7MyOsIRH0MIcmaZGc2CyNcShw8hKtXUI/FIX1pYAPPB8KWbKoyzyfhFh l2HD0GNcW5h8o85MFcz/l0rTcbV/zT95sOsBIf9NGL03anWRJpDLT1vRXImLu3B4POpT i91fcgaLJlwj2tb4U2f7JaHly1BiVIVtnQ0dLs/y2dH1V/3KAkahgxyGIN2Uv5kwUXWg P+w1d0eRG7CLLLmqdxE9TNl7T1EJi4ts/0aeTMoHSM6+pKGuWzy07VCVZRYlANciASDx 0XMlmswS9XU2YsaTQffan7P46c7grQl7s9aibzclOwvkqI0kqpnUiv6JzRALVFeV4TUE gozA== X-Gm-Message-State: AOJu0YyGWKQ2ynpPmWsnG4/aNzW1bs6gQmd2ljwYGMJ9xdfQ2nyAZcDl /NqjBvfoPTVWSamF0GNiTBc1ATIueG5MyMXktbkGyRX8Mho1qA== X-Google-Smtp-Source: AGHT+IGbuLVM4W+n186FOLuDzcyD+PPYD2eO2iAFM6+IJGSWH6NJN/msICrVbQx3Jw2M8NiB/ycpYw== X-Received: by 2002:a17:902:7043:b0:1d6:ebf8:f3e5 with SMTP id h3-20020a170902704300b001d6ebf8f3e5mr244164plt.12.1705443579576; Tue, 16 Jan 2024 14:19:39 -0800 (PST) Received: from gkm.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id ky16-20020a170902f99000b001d5af7fbda0sm6898040plb.122.2024.01.16.14.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 14:19:39 -0800 (PST) From: Greg McGary To: gcc-patches@gcc.gnu.org, Greg McGary Cc: Greg McGary Subject: [PATCH] combine: Don't optimize SIGN_EXTEND of MEM on WORD_REGISTER_OPERATIONS targets [PR113010] Date: Tue, 16 Jan 2024 14:19:14 -0800 Message-Id: <20240116221914.267015-1-gkm@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org The sign bit of a sign-extending load cannot be known until runtime, so don't attempt to simplify it in the combiner. 2024-01-11 Greg McGary PR rtl-optimization/113010 * combine.cc (expand_compound_operation): Don't simplify SIGN_EXTEND of a MEM on WORD_REGISTER_OPERATIONS targets * gcc.c-torture/execute/pr113010.c: New test. --- gcc/combine.cc | 5 +++++ gcc/testsuite/gcc.c-torture/execute/pr113010.c | 9 +++++++++ 2 files changed, 14 insertions(+) create mode 100644 gcc/testsuite/gcc.c-torture/execute/pr113010.c diff --git a/gcc/combine.cc b/gcc/combine.cc index 812553c091e..ba587184dfc 100644 --- a/gcc/combine.cc +++ b/gcc/combine.cc @@ -7208,6 +7208,11 @@ expand_compound_operation (rtx x) if (len == 0) return x; + /* Sign-extending loads can never be simplified at compile time. */ + if (WORD_REGISTER_OPERATIONS && MEM_P (XEXP (x, 0)) + && load_extend_op (inner_mode) == SIGN_EXTEND) + return x; + break; case ZERO_EXTRACT: diff --git a/gcc/testsuite/gcc.c-torture/execute/pr113010.c b/gcc/testsuite/gcc.c-torture/execute/pr113010.c new file mode 100644 index 00000000000..a95c613c1df --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr113010.c @@ -0,0 +1,9 @@ +int minus_1 = -1; + +int +main () +{ + if ((0, 0xfffffffful) >= minus_1) + __builtin_abort (); + return 0; +}