From patchwork Mon Jan 15 13:34:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 84121 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5EB603858C54 for ; Mon, 15 Jan 2024 13:40:56 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D4D9B3858D28 for ; Mon, 15 Jan 2024 13:39:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4D9B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4D9B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705325976; cv=none; b=WbA1cPUNZeD1IcCNi06zvQGi9Wwk866rJQ4jYNIevuOT04Rz2stfZ2RBtDaKQVQsUerGdAAVmKQKPfXtldiI9AfRdTBlPq2PYUNefADS0EUuYWVgj6Gwzxoi3NtJLA+SMowEQLp77seB0q+0LGIbIwdQTKDETggnXoU6lDLFUy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705325976; c=relaxed/simple; bh=KdMK8Ig5zjC5XlTzeCjmgVLb8gHRfj61bHREEKOkmMs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=Nnw8FB+phqn/BmL0H8J/F1eLiA34Cq/O3FsXmqMpMLbqsX/UjXcvGCb5/5zOqmktd87fGt8kK1ga/tmGp9766b2XSGs1/EpFSbxXdLSK4YxyI+qTmJj4RcuY82x8oyFQQZVOLKFi4Tz0aXKEZYgSiJD++k61eOdzLh054ZF8eL8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F0B1B21E88 for ; Mon, 15 Jan 2024 13:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705325974; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=ZPSWvo854fjXuPnbcdPUUMS7PhLLJh9DGf7weI5xj4E=; b=gBBJlYBhXdHwUkydD0tVstR2LemQ45woFqLOJxxwHQPmlxr/sotM4nvcZNkCSbqain6LFr NrkGpbBeYkzNq8gCwsLeuY8eCkW9s8OcJrKCTVbd9Gf4WzggotaCj+90Wr4vORXAeTWTyx kLe3AMvyZsNANoTjsC1dO4+340gNP8c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705325974; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=ZPSWvo854fjXuPnbcdPUUMS7PhLLJh9DGf7weI5xj4E=; b=6eV/HUYiS2NN0pa+oMKQQUYxWrRXWrXkALDlZZOGifPFoB+qjuWhcCLU6hwLAJ+e7aJmX9 dXzUdmTIihQRQMBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705325974; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=ZPSWvo854fjXuPnbcdPUUMS7PhLLJh9DGf7weI5xj4E=; b=gBBJlYBhXdHwUkydD0tVstR2LemQ45woFqLOJxxwHQPmlxr/sotM4nvcZNkCSbqain6LFr NrkGpbBeYkzNq8gCwsLeuY8eCkW9s8OcJrKCTVbd9Gf4WzggotaCj+90Wr4vORXAeTWTyx kLe3AMvyZsNANoTjsC1dO4+340gNP8c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705325974; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=ZPSWvo854fjXuPnbcdPUUMS7PhLLJh9DGf7weI5xj4E=; b=6eV/HUYiS2NN0pa+oMKQQUYxWrRXWrXkALDlZZOGifPFoB+qjuWhcCLU6hwLAJ+e7aJmX9 dXzUdmTIihQRQMBg== Date: Mon, 15 Jan 2024 14:34:28 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/2] find_base_value part MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [2.40 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.00)[14.27%] X-Spam-Score: 2.40 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Message-Id: <20240115134056.5EB603858C54@sourceware.org> The following adjusts find_base_value similar as to what find_base_term was adjusted for PR113255. * alias.cc (known_base_value_p): Remove. (find_base_value): Remove PLUS/MINUS handling when both operands are not CONST_INT_P. --- gcc/alias.cc | 62 ++++------------------------------------------------ 1 file changed, 4 insertions(+), 58 deletions(-) diff --git a/gcc/alias.cc b/gcc/alias.cc index bdc119822b4..29b3ba82dba 100644 --- a/gcc/alias.cc +++ b/gcc/alias.cc @@ -1400,26 +1400,6 @@ unique_base_value_p (rtx x) return GET_CODE (x) == ADDRESS && GET_MODE (x) == Pmode; } -/* Return true if X is known to be a base value. */ - -static bool -known_base_value_p (rtx x) -{ - switch (GET_CODE (x)) - { - case LABEL_REF: - case SYMBOL_REF: - return true; - - case ADDRESS: - /* Arguments may or may not be bases; we don't know for sure. */ - return GET_MODE (x) != VOIDmode; - - default: - return false; - } -} - /* Inside SRC, the source of a SET, find a base address. */ static rtx @@ -1490,46 +1470,12 @@ find_base_value (rtx src) case PLUS: case MINUS: { - rtx temp, src_0 = XEXP (src, 0), src_1 = XEXP (src, 1); - - /* If either operand is a REG that is a known pointer, then it - is the base. */ - if (REG_P (src_0) && REG_POINTER (src_0)) - return find_base_value (src_0); - if (REG_P (src_1) && REG_POINTER (src_1)) - return find_base_value (src_1); - - /* If either operand is a REG, then see if we already have - a known value for it. */ - if (REG_P (src_0)) - { - temp = find_base_value (src_0); - if (temp != 0) - src_0 = temp; - } - - if (REG_P (src_1)) - { - temp = find_base_value (src_1); - if (temp!= 0) - src_1 = temp; - } - - /* If either base is named object or a special address - (like an argument or stack reference), then use it for the - base term. */ - if (src_0 != 0 && known_base_value_p (src_0)) - return src_0; - - if (src_1 != 0 && known_base_value_p (src_1)) - return src_1; + rtx src_0 = XEXP (src, 0), src_1 = XEXP (src, 1); - /* Guess which operand is the base address: - If either operand is a symbol, then it is the base. If - either operand is a CONST_INT, then the other is the base. */ - if (CONST_INT_P (src_1) || CONSTANT_P (src_0)) + /* If either operand is a CONST_INT, then the other is the base. */ + if (CONST_INT_P (src_1)) return find_base_value (src_0); - else if (CONST_INT_P (src_0) || CONSTANT_P (src_1)) + else if (CONST_INT_P (src_0)) return find_base_value (src_1); return 0;